Patch "x86/cpu/AMD: Apply the Erratum 688 fix when the BIOS doesn't" has been added to the 4.13-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
x86/cpu/AMD: Apply the Erratum 688 fix when the BIOS doesn't
to the 4.13-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
x86-cpu-amd-apply-the-erratum-688-fix-when-the-bios-doesn-t.patch
and it can be found in the queue-4.13 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
bfc1168de949cd3e9ca18c3480b5085deff1ea7cMon Sep 17 00:00:00 2001
From: Borislav Petkov <[email protected]>
Date: Sun, 22 Oct 2017 12:47:31 +0200
Subject: x86/cpu/AMD: Apply the Erratum 688 fix when the BIOS doesn't
From: Borislav Petkov <[email protected]>
commit bfc1168de949cd3e9ca18c3480b5085deff1ea7c upstream.
Some F14h machines have an erratum which, "under a highly specific and detailed set of internal timing conditions" can lead to skipping instructions and RIP corruption.
Add the fix for those machines when their BIOS doesn't apply it or there simply isn't BIOS update for them.
--- arch/x86/kernel/amd_nb.c | 41 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+)
arch/x86/kernel/amd_nb.c +41 -0
@@ -27,6 +27,8 @@ static const struct pci_device_id amd_ro {} }; +#define PCI_DEVICE_ID_AMD_CNB17H_F4 0x1704 +const struct pci_device_id amd_nb_misc_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_AMD ,PCI_DEVICE_ID_AMD_K8_NB_MISC ) }, {PCI_DEVICE (PCI_VENDOR_ID_AMD ,PCI_DEVICE_ID_AMD_10H_NB_MISC ) },
@@ -37,6 +39,7 @@ const struct pci_device_id amd_nb_misc_i { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_16H_NB_F3) }, { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_16H_M30H_NB_F3) }, { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_17H_DF_F3) }, + { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_CNB17H_F3) }, {} };EXPORT_SYMBOL_GPL (amd_nb_misc_ids);
@@ -48,6 +51,7 @@ static const struct pci_device_id amd_nb { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_16H_NB_F4) }, { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_16H_M30H_NB_F4) }, { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_17H_DF_F4) }, + { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_CNB17H_F4) }, {} };
@@ -402,11 +406,48 @@ void amd_flush_garts(void) }EXPORT_SYMBOL_GPL (amd_flush_garts); +static void __fix_erratum_688 (void *info) +{ +#define MSR_AMD64_IC_CFG 0xC0011021 + +msr_set_bit (MSR_AMD64_IC_CFG ,3 ); +msr_set_bit (MSR_AMD64_IC_CFG ,14 ); +} + +/* Apply erratum 688 fix so machines without a BIOS fix work. */ +static __init void fix_erratum_688 (void ) +{ +struct pci_dev *F4 ; +u32 val; + +if (boot_cpu_data.x86 !=0x14 ) +return ; + +if (!amd_northbridges.num) +return ; + +F4 =node_to_amd_nb (0 )->link; +if (!F4 ) +return ; + +if (pci_read_config_dword (F4 ,0x164 , &val)) +return ; + +if (val &BIT (2 )) +return ; + +on_each_cpu (__fix_erratum_688,NULL ,0 ); + +pr_info ("x86/cpu/AMD: CPU erratum 688 worked around\n" ); +} +static __init int init_amd_nbs (void ) {amd_cache_northbridges ();amd_cache_gart (); +fix_erratum_688 (); +return 0 ; }
Patches currently in stable-queue which might be from [email protected] are
queue-4.13/x86-cpu-amd-apply-the-erratum-688-fix-when-the-bios-doesn-t.patch