Skip to contentSkip to conversation

Patch "spi: uapi: spidev: add missing ioctl header" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Oct 30, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

spi: uapi: spidev: add missing ioctl header

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
spi-uapi-spidev-add-missing-ioctl-header.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From a2b4a79b88b24c49d98d45a06a014ffd22ada1a4 Mon Sep 17 00:00:00 2001

From: Baruch Siach <[email protected]>
Date: Sun, 10 Sep 2017 20:29:45 +0300
Subject: spi: uapi: spidev: add missing ioctl header

From: Baruch Siach <[email protected]>

commit a2b4a79b88b24c49d98d45a06a014ffd22ada1a4 upstream.

The SPI_IOC_MESSAGE() macro references _IOC_SIZEBITS. Add linux/ioctl.h to make sure this macro is defined. This fixes the following build failure of lcdproc with the musl libc:

In file included from .../sysroot/usr/include/sys/ioctl.h:7:0,

                 from hd44780-spi.c:31:
hd44780-spi.c: In function 'spi_transfer':
hd44780-spi.c:89:24: error: '_IOC_SIZEBITS' undeclared (first use in this function)
  status = ioctl(p->fd, SPI_IOC_MESSAGE(1), &xfer);
                        ^
---
 include/uapi/linux/spi/spidev.h |    1 +
 1 file changed, 1 insertion(+)
include/uapi/linux/spi/spidev.h +1 -0
@@ -23,6 +23,7 @@
 #define SPIDEV_H
 
 #include <linux/types.h>
+#include <linux/ioctl.h>
 
 /* User space versions of kernel symbols for SPI clocking modes,
  * matching <linux/spi/spi.h>

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/spi-uapi-spidev-add-missing-ioctl-header.patch