Skip to contentSkip to conversation

Patch "scsi: sg: Re-fix off by one in sg_fill_request_table()" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Oct 30, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

scsi: sg: Re-fix off by one in sg_fill_request_table()

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
scsi-sg-re-fix-off-by-one-in-sg_fill_request_table.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 587c3c9f286cee5c9cac38d28c8ae1875f4ec85b Mon Sep 17 00:00:00 2001

From: Ben Hutchings <[email protected]>
Date: Sun, 15 Oct 2017 18:16:33 +0100
Subject: scsi: sg: Re-fix off by one in sg_fill_request_table()

From: Ben Hutchings <[email protected]>

commit 587c3c9f286cee5c9cac38d28c8ae1875f4ec85b upstream.

Commit 109bade9c625 ("scsi: sg: use standard lists for sg_requests") introduced an off-by-one error in sg_ioctl(), which was fixed by commit bd46fc406b30 ("scsi: sg: off by one in sg_ioctl()").

Unfortunately commit 4759df905a47 ("scsi: sg: factor out sg_fill_request_table()") moved that code, and reintroduced the bug (perhaps due to a botched rebase). Fix it again.

Fixes 4759df905a47 ("scsi: sg: factor out sg_fill_request_table()")
---
 drivers/scsi/sg.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/sg.c +1 -1
@@ -837,7 +837,7 @@ sg_fill_request_table(Sg_fd *sfp, sg_req
 
 	val = 0;
 	list_for_each_entry(srp, &sfp->rq_list, entry) {
-		if (val > SG_MAX_QUEUE)
+		if (val >= SG_MAX_QUEUE)
 			break;
 		rinfo[val].req_state = srp->done + 1;
 		rinfo[val].problem =

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/scsi-sg-re-fix-off-by-one-in-sg_fill_request_table.patch