Skip to contentSkip to conversation

drm/amd/display: revert "enable GPU VM support"

PATCH In review Christian König 3 participants 3 messages Oct 30, 2017 2 messages not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amd/display: revert "enable GPU VM support"

From: Christian König <[email protected]>

This reverts commit aa7187c5c640559ebc02caa0191c0db46b55b4a6.

Disable GPU VM support again for now until it doesn't cause a warning on hardware which doesn't support it.

---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0 -2
index c13110f..e6ec130 100644
@@ -417,8 +417,6 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
 
 	init_data.dce_environment = DCE_ENV_PRODUCTION_DRV;
 
-	init_data.flags.gpu_vm_support = true;
-
 	if (amdgpu_dc_log)
 		init_data.log_mask = DC_DEFAULT_LOG_MASK;
 	else
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1509375358-32528-1-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org

Reviewed-by
#2 lore raw
Quoted 8 lines · Christian König

From: Christian König <[email protected]>

This reverts commit aa7187c5c640559ebc02caa0191c0db46b55b4a6.

Disable GPU VM support again for now until it doesn't cause a warning on hardware which doesn't support it.

I'll still try to hack DC to not blow up with this after which we can bring this back. Hopefully by end of the week.

Harry

Quoted 10 lines
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0 -0
index c13110f..e6ec130 100644

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static int amdgpu_dm_init(struct amdgpu_device *adev) · line 422

Quoted 8 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0 -2
@@ -417,8 +417,6 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
 
 	init_data.dce_environment = DCE_ENV_PRODUCTION_DRV;
 
-	init_data.flags.gpu_vm_support = true;
-
 	if (amdgpu_dc_log)
 		init_data.log_mask = DC_DEFAULT_LOG_MASK;
 	else

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): d935a949-2855-45de-c632-88a3c6b35022-5C7GfCeVMHo@public.gmane.org

#4 lore raw
Quoted 15 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Harry Wentland
Sent: Monday, October 30, 2017 11:02 AM
To: Christian König; [email protected]
Subject: Re: [PATCH] drm/amd/display: revert "enable GPU VM support"

Quoted 7 lines · Christian König

From: Christian König <[email protected]>

This reverts commit aa7187c5c640559ebc02caa0191c0db46b55b4a6.

Disable GPU VM support again for now until it doesn't cause a warning on hardware which doesn't support it.

Quoted 6 lines
Quoted 1 line

I'll still try to hack DC to not blow up with this after which we can bring this back. Hopefully by end of the week.

In the short term, can't we do something like:

if (adev->flags & AMDGPU_IS_APU && adev->asic_type >= CHIP_CARRIZO)

    init_data.flags.gpu_vm_support = true;

Alex

Quoted 17 lines

Harry

Review

Quoted 5 lines
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 --
 1 file changed, 2 deletions(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static int amdgpu_dm_init(struct amdgpu_device

Quoted 4 lines

index c13110f..e6ec130 100644

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0 -0
@@ -417,8 +417,6 @@ static int amdgpu_dm_init(struct amdgpu_device

*adev)

Quoted 3 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0 -0
 	init_data.dce_environment = DCE_ENV_PRODUCTION_DRV;
 
Quoted 10 lines

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static int amdgpu_dm_init(struct amdgpu_device *adev)

Quoted 6 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0 -2
-	init_data.flags.gpu_vm_support = true;
-
 	if (amdgpu_dc_log)
 		init_data.log_mask = DC_DEFAULT_LOG_MASK;
 	else
 

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx