Skip to contentSkip to conversation

armv8: ls1088: Enable SATA for ls1088

PATCH New York Sun 2 participants 2 messages Oct 31, 2017 – Nov 1, 2017 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

York Sun

author
#2 lore raw

PATCH v3 2/2 armv8: ls1088: Enable SATA for ls1088

Quoted 22 lines · Ashish Kumar
Signed-off-by Ashish Kumar <[email protected]>
Signed-off-by Amrita Kumari <[email protected]>

---
v2: Rebase to top
v3: Consolidate defines in common file

 include/configs/ls1088a_common.h | 11 +++++++++++
 1 file changed, 11 insertions(+)
include/configs/ls1088a_common.h +4 -0
index fa058f7..9d59472 100644
@@ -148,6 +148,17 @@ unsigned long long get_qixis_addr(void);
 /* Miscellaneous configurable options */
 #define CONFIG_SYS_LOAD_ADDR	(CONFIG_SYS_DDR_SDRAM_BASE + 0x10000000)
 
+/* SATA */
+#define CONFIG_LIBATA
+#define CONFIG_SCSI_AHCI
+#define CONFIG_SCSI_AHCI_PLAT

include/configs/ls1088a_common.h unsigned long long get_qixis_addr(void); · line 164

Quoted 10 lines
include/configs/ls1088a_common.h +7 -0
+#define CONFIG_SYS_SATA1		AHCI_BASE_ADDR1
+
+#define CONFIG_SYS_SCSI_MAX_SCSI_ID	1
+#define CONFIG_SYS_SCSI_MAX_LUN		1
+#define CONFIG_SYS_SCSI_MAX_DEVICE	(CONFIG_SYS_SCSI_MAX_SCSI_ID * \
+					CONFIG_SYS_SCSI_MAX_LUN)
+
 /* Physical Memory Map */
 #define CONFIG_CHIP_SELECTS_PER_CTRL	4

I see you use "imply SCSI" in Kconfig, wouldn't it be better to put #ifdef to guard above macros so it may be easier to turn off SATA by menuconfig and/or defconfig if needed?

York

#3 lore raw

PATCH v3 2/2 armv8: ls1088: Enable SATA for ls1088

Hello York,

Please see inline.

Regards
Ashish

-----Original Message-----
From: York Sun
Sent: Tuesday, October 31, 2017 8:37 PM
To: Ashish Kumar <[email protected]>; u-boot at lists.denx.de
Cc: Amrita Kumari <[email protected]>; Andy Tang <[email protected]>
Subject: Re: [Patch v3 2/2] armv8: ls1088: Enable SATA for ls1088

Quoted 23 lines · Ashish Kumar
Signed-off-by Ashish Kumar <[email protected]>
Signed-off-by Amrita Kumari <[email protected]>

---
v2: Rebase to top
v3: Consolidate defines in common file

 include/configs/ls1088a_common.h | 11 +++++++++++
 1 file changed, 11 insertions(+)
include/configs/ls1088a_common.h +4 -0
index fa058f7..9d59472 100644
@@ -148,6 +148,17 @@ unsigned long long get_qixis_addr(void);
 /* Miscellaneous configurable options */
 #define CONFIG_SYS_LOAD_ADDR	(CONFIG_SYS_DDR_SDRAM_BASE + 0x10000000)
 
+/* SATA */
+#define CONFIG_LIBATA
+#define CONFIG_SCSI_AHCI
+#define CONFIG_SCSI_AHCI_PLAT

include/configs/ls1088a_common.h unsigned long long get_qixis_addr(void); · line 164

Quoted 10 lines
include/configs/ls1088a_common.h +7 -0
+#define CONFIG_SYS_SATA1		AHCI_BASE_ADDR1
+
+#define CONFIG_SYS_SCSI_MAX_SCSI_ID	1
+#define CONFIG_SYS_SCSI_MAX_LUN		1
+#define CONFIG_SYS_SCSI_MAX_DEVICE	(CONFIG_SYS_SCSI_MAX_SCSI_ID * \
+					CONFIG_SYS_SCSI_MAX_LUN)
+
 /* Physical Memory Map */
 #define CONFIG_CHIP_SELECTS_PER_CTRL	4

I see you use "imply SCSI" in Kconfig, wouldn't it be better to put #ifdef to guard above macros so it may be easier to turn off SATA by menuconfig and/or defconfig if needed?

Quoted 1 line

You mean to add #ifdef CONFIG_SCSI here along with "imply SCSI" in Kconfig?

York