Skip to contentSkip to conversation

drm/i915: Generalize transcoder looping

PATCH Superseded Mika Kahola 3 participants 5 messages Nov 1, 2017 – Nov 2, 2017

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Generalize transcoder looping

To make looping through transcoders in intel_ddi.c more generic, let's switch to use 'for_each_pipe()' macro to do this.

---
 drivers/gpu/drm/i915/intel_ddi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_ddi.c +1 -1
index ace674c..3df991b 100644
@@ -1717,7 +1717,7 @@ bool intel_ddi_get_hw_state(struct intel_encoder *encoder,
 		goto out;
 	}
 
-	for (i = TRANSCODER_A; i <= TRANSCODER_C; i++) {
+	for_each_pipe(dev_priv, i) {
 		tmp = I915_READ(TRANS_DDI_FUNC_CTL(i));
 
 		if ((tmp & TRANS_DDI_PORT_MASK) == TRANS_DDI_SELECT_PORT(port)) {
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.BAT: failure for drm/i915: Generalize transcoder looping

== Series Details ==

== Series Details ==

Series: drm/i915: Generalize transcoder looping
URL : https://patchwork.freedesktop.org/series/32965/
State : failure

== Summary ==

Series 32965v1 drm/i915: Generalize transcoder looping
https://patchwork.freedesktop.org/api/1.0/series/32965/revisions/1/mbox/

Test gem_ctx_switch:

        Subgroup basic-default-heavy:
                pass       -> INCOMPLETE (fi-glk-dsi)
Test pm_backlight:
        Subgroup basic-brightness:
                incomplete -> PASS       (fi-glk-1) fdo#102035

fdo#102035 https://bugs.freedesktop.org/show_bug.cgi?id=102035

fi-bdw-5557u     total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:445s
fi-blb-e6850     total:289  pass:223  dwarn:1   dfail:0   fail:0   skip:65  time:383s
fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0   fail:0   skip:46  time:552s
fi-bwr-2160      total:289  pass:183  dwarn:0   dfail:0   fail:0   skip:106 time:276s
fi-bxt-dsi       total:289  pass:259  dwarn:0   dfail:0   fail:0   skip:30  time:507s
fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:503s
fi-byt-j1900     total:289  pass:253  dwarn:1   dfail:0   fail:0   skip:35  time:509s
fi-byt-n2820     total:289  pass:249  dwarn:1   dfail:0   fail:0   skip:39  time:489s
fi-elk-e7500     total:289  pass:229  dwarn:0   dfail:0   fail:0   skip:60  time:433s
fi-gdg-551       total:289  pass:178  dwarn:1   dfail:0   fail:1   skip:109 time:266s
fi-glk-1         total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:583s
fi-glk-dsi       total:32   pass:22   dwarn:0   dfail:0   fail:0   skip:9  
fi-hsw-4770      total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:428s
fi-hsw-4770r     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:432s
fi-ilk-650       total:289  pass:228  dwarn:0   dfail:0   fail:0   skip:61  time:427s
fi-ivb-3770      total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:466s
fi-kbl-7560u     total:289  pass:270  dwarn:0   dfail:0   fail:0   skip:19  time:578s
fi-kbl-7567u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:477s
fi-kbl-r         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:586s
fi-pnv-d510      total:289  pass:222  dwarn:1   dfail:0   fail:0   skip:66  time:571s
fi-skl-6260u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:460s
fi-skl-6600u     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:598s
fi-skl-6700hq    total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:648s
fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:517s
fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:501s
fi-snb-2520m     total:289  pass:250  dwarn:0   dfail:0   fail:0   skip:39  time:568s
fi-snb-2600      total:289  pass:249  dwarn:0   dfail:0   fail:0   skip:40  time:427s

fi-cfl-s failed to connect after reboot
fi-cnl-y failed to connect after reboot

ec9f75873be66e10cbcfa5ac1e32a79a82b6820c drm-tip: 2017y-10m-31d-23h-03m-56s UTC integration manifest f3ab852aa636 drm/i915: Generalize transcoder looping

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6289/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#2 lore raw
In reply to Mika Kahola
Quoted 13 lines · Mika Kahola

To make looping through transcoders in intel_ddi.c more generic, let's switch to use 'for_each_pipe()' macro to do this.

---
 drivers/gpu/drm/i915/intel_ddi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_ddi.c +0 -0
index ace674c..3df991b 100644

drivers/gpu/drm/i915/intel_ddi.c bool intel_ddi_get_hw_state(struct intel_encoder *encoder, · line 1720

Quoted 5 lines
drivers/gpu/drm/i915/intel_ddi.c +1 -1
@@ -1717,7 +1717,7 @@ bool intel_ddi_get_hw_state(struct intel_encoder *encoder,
 		goto out;
 	}
 
-	for (i = TRANSCODER_A; i <= TRANSCODER_C; i++) {
+	for_each_pipe(dev_priv, i) {

It gives me an uneasy feeling to conflate pipes and transcoders like this. I think we've tried to be more clear about the distinction elsewhere.

BR,
Jani.

Quoted 3 lines
drivers/gpu/drm/i915/intel_ddi.c +0 -0
 		tmp = I915_READ(TRANS_DDI_FUNC_CTL(i));
 
 		if ((tmp & TRANS_DDI_PORT_MASK) == TRANS_DDI_SELECT_PORT(port)) {
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw
Quoted 11 lines · Jani Nikula
Quoted 10 lines · Mika Kahola

To make looping through transcoders in intel_ddi.c more generic, let's switch
to use 'for_each_pipe()' macro to do this.

---
 drivers/gpu/drm/i915/intel_ddi.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines

drivers/gpu/drm/i915/intel_ddi.c bool intel_ddi_get_hw_state(struct intel_encoder *encoder, · line 1720

Quoted 12 lines
drivers/gpu/drm/i915/intel_ddi.c +0 -0
index ace674c..3df991b 100644
@@ -1717,7 +1717,7 @@ bool intel_ddi_get_hw_state(struct
 intel_encoder *encoder,
  		goto out;
  	}

drivers/gpu/drm/i915/intel_ddi.c +1 -1
-	for (i = TRANSCODER_A; i <= TRANSCODER_C; i++) {
+	for_each_pipe(dev_priv, i) {

It gives me an uneasy feeling to conflate pipes and transcoders like this. I think we've tried to be more clear about the distinction elsewhere.

I had a same kind of feeling myself. First, I was thinking of creating a new macro like for_each_transcoder() which would indicate that now we are dealing with transcoders instead of pipes. Maybe going to that direction here?

Quoted 9 lines

BR,
Jani.

Quoted 5 lines

  tmp = I915_READ(TRANS_DDI_FUNC_CTL(i));
  if ((tmp & TRANS_DDI_PORT_MASK) == TRANS_DDI_SELECT_PORT(port)) {

Signature · 6 lines
Mika Kahola - Intel OTC

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
maintainer
#4 lore raw
Quoted 27 lines · Mika Kahola
Quoted 11 lines · Jani Nikula
Quoted 10 lines · Mika Kahola

To make looping through transcoders in intel_ddi.c more generic, let's switch
to use 'for_each_pipe()' macro to do this.

---
 drivers/gpu/drm/i915/intel_ddi.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines

drivers/gpu/drm/i915/intel_ddi.c bool intel_ddi_get_hw_state(struct intel_encoder *encoder, · line 1720

Quoted 12 lines
drivers/gpu/drm/i915/intel_ddi.c +0 -0
index ace674c..3df991b 100644
@@ -1717,7 +1717,7 @@ bool intel_ddi_get_hw_state(struct
 intel_encoder *encoder,
  		goto out;
  	}

drivers/gpu/drm/i915/intel_ddi.c +1 -1
-	for (i = TRANSCODER_A; i <= TRANSCODER_C; i++) {
+	for_each_pipe(dev_priv, i) {

It gives me an uneasy feeling to conflate pipes and transcoders like this. I think we've tried to be more clear about the distinction elsewhere.

Quoted 4 lines

I had a same kind of feeling myself. First, I was thinking of creating a new macro like for_each_transcoder() which would indicate that now we are dealing with transcoders instead of pipes. Maybe going to that direction here?

That gets ugly fast too... just look at enum transcoder, and realize you don't want to iterate them all. And there's special casing for TRANSCODER_EDP above already.

Perhaps the easiest for now would be to use for_each_pipe() (and please make the variable enum pipe p or something instead of int i) and then do an explicit

	enum transcoder cpu_transcoder = (enum transcoder) p;

BR,
Jani.

Quoted 10 lines
Quoted 10 lines

BR,
Jani.

Quoted 5 lines

  tmp = I915_READ(TRANS_DDI_FUNC_CTL(i));
  if ((tmp & TRANS_DDI_PORT_MASK) == TRANS_DDI_SELECT_PORT(port)) {

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx