Skip to contentSkip to conversation

locking: fix typo

PATCH Applied pierre Kuo 2 participants 6 messages Nov 2, 2017 – Nov 3, 2017

lore
Share & tools
lore

pierre Kuo

author
#0 lore raw

PATCH 1/2 locking: fix typo

From: Pierre Kuo <[email protected]>

In 7.1.1.2 Local Locking Hierarchies, below left parenthesis seems better to be comma.

"before invoking the comparison function (which is unknown code from qsort()’s perspective," ^^^ change it as comma.

---
 locking/locking.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
locking/locking.tex +1 -1
index 12a0240..5921f50 100644
@@ -327,7 +327,7 @@ But the first thread holds Lock~C, so the second thread's call to
 Lock~B, resulting in deadlock.
 
 In contrast, if \co{qsort()} releases Lock~C before invoking the
-comparison function (which is unknown code from \co{qsort()}'s perspective,
+comparison function ,which is unknown code from \co{qsort()}'s perspective,
 then deadlock is avoided as shown in
 Figure~\ref{fig:lock:Local Locking Hierarchy for qsort()}.
 
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 2/2 SMPdesign: fix typo

From: Pierre Kuo <[email protected]>

In 6.5.1 Work-Queue Parallel Maze Solver, the line #4 and line #5 of listing 6.13 seem describe the cell 't' instead of cell 'n'.

---
 SMPdesign/beyond.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
SMPdesign/beyond.tex +2 -2
index 72862c5..88e2b31 100644
@@ -141,8 +141,8 @@ Line~20 initializes for the next pass through the outer loop.
 The pseudocode for \co{maze_try_visit_cell()} is shown on lines~1-12
 of Listing~\ref{lst:SMPdesign:SEQ Helper Pseudocode}
 (\path{maze.c}).
-Line~4 checks to see if cells \co{c} and \co{n} are adjacent and connected,
-while line~5 checks to see if cell \co{n} has not yet been visited.
+Line~4 checks to see if cells \co{c} and \co{t} are adjacent and connected,
+while line~5 checks to see if cell \co{t} has not yet been visited.
 The \co{celladdr()} function returns the address of the specified cell.
 If either check fails, line~6 returns failure.
 Line~7 indicates the next cell, line~8 records this cell in the next
Signature · 1 line
1.9.1
#2 lore raw
In reply to pierre Kuo
Quoted 10 lines · pierre Kuo

From: Pierre Kuo <[email protected]>

In 7.1.1.2 Local Locking Hierarchies, below left parenthesis seems better to be comma.

"before invoking the comparison function (which is unknown code from qsort()’s perspective," ^^^ change it as comma.

I queued and pushed both, thank you!

On the patch below, I interchanged the comma with the preceding space character.

Thanx, Paul

Quoted 25 lines
---
 locking/locking.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
locking/locking.tex +1 -1
index 12a0240..5921f50 100644
@@ -327,7 +327,7 @@ But the first thread holds Lock~C, so the second thread's call to
 Lock~B, resulting in deadlock.
 
 In contrast, if \co{qsort()} releases Lock~C before invoking the
-comparison function (which is unknown code from \co{qsort()}'s perspective,
+comparison function ,which is unknown code from \co{qsort()}'s perspective,
 then deadlock is avoided as shown in
 Figure~\ref{fig:lock:Local Locking Hierarchy for qsort()}.
 
Signature · 6 lines
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe perfbook" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#4 lore raw
Quoted 10 lines · pierre kuo

hi Paul:

Quoted 3 lines

On the patch below, I interchanged the comma with the preceding space character.

Got it.
BTW, I have another patch need ur review.
Would you mind to give some comment?
http://www.spinics.net/lists/perfbook/msg01522.html

Appreciate your help in advance.

I already did.

From my previous email: "I queued and pushed both, thank you!" So your second patch is applied unchanged. ;-)

Thanx, Paul

author
#5 lore raw

hi Paul:

Quoted 5 lines

I already did.

From my previous email: "I queued and pushed both, thank you!" So your second patch is applied unchanged. ;-)

sorry for unaware the "both" key word.
Thank U ^^