Skip to contentSkip to conversation

selftests: add "PASS" status in log for mqueue

PATCH In review Lei Yang 2 participants 2 messages Nov 5, 2017 – Nov 6, 2017 Kselftest

lore
Share & tools
lore

Lei Yang

author
#0 lore raw

PATCH 1/1 selftests: add "PASS" status in log for mqueue

It prints 'FAIL' status when test failed, but not print 'PASS' when test passed.

---
 tools/testing/selftests/mqueue/Makefile | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
tools/testing/selftests/mqueue/Makefile +4 -4
index 0f5e347..437b048 100644
@@ -5,12 +5,12 @@ TEST_GEN_PROGS := mq_open_tests mq_perf_tests
 include ../lib.mk
 
 override define RUN_TESTS
-	$(OUTPUT)/mq_open_tests /test1 || echo "selftests: mq_open_tests [FAIL]"
-	$(OUTPUT)//mq_perf_tests || echo "selftests: mq_perf_tests [FAIL]"
+	$(OUTPUT)/mq_open_tests /test1 && echo "selftests: mq_open_tests [PASS]" || echo "selftests: mq_open_tests [FAIL]"
+	$(OUTPUT)/mq_perf_tests && echo "selftests: mq_perf_tests [PASS]" || echo "selftests: mq_perf_tests [FAIL]"
 endef
 
 override define EMIT_TESTS
-	echo "./mq_open_tests /test1 || echo \"selftests: mq_open_tests [FAIL]\""
-	echo "./mq_perf_tests || echo \"selftests: mq_perf_tests [FAIL]\""
+	echo "./mq_open_tests /test1 && echo \"selftests: mq_open_tests [PASS]\" || echo \"selftests: mq_open_tests [FAIL]\""
+	echo "./mq_perf_tests && echo \"selftests: mq_perf_tests [PASS]\" || echo \"selftests: mq_perf_tests [FAIL]\""
 endef
 
Signature · 1 line
1.9.1
#1 lore raw
Quoted 20 lines · Lei Yang

It prints 'FAIL' status when test failed, but not print 'PASS' when test passed.

---
 tools/testing/selftests/mqueue/Makefile | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
tools/testing/selftests/mqueue/Makefile +1 -2
index 0f5e347..437b048 100644
@@ -5,12 +5,12 @@ TEST_GEN_PROGS := mq_open_tests mq_perf_tests
 include ../lib.mk
 
 override define RUN_TESTS
-	$(OUTPUT)/mq_open_tests /test1 || echo "selftests: mq_open_tests [FAIL]"
-	$(OUTPUT)//mq_perf_tests || echo "selftests: mq_perf_tests [FAIL]"
+	$(OUTPUT)/mq_open_tests /test1 && echo "selftests: mq_open_tests [PASS]" || echo "selftests: mq_open_tests [FAIL]"

tools/testing/selftests/mqueue/Makefile TEST_GEN_PROGS := mq_open_tests mq_perf_tests · line 16

Quoted 10 lines
tools/testing/selftests/mqueue/Makefile +3 -2
+	$(OUTPUT)/mq_perf_tests && echo "selftests: mq_perf_tests [PASS]" || echo "selftests: mq_perf_tests [FAIL]"
 endef
 
 override define EMIT_TESTS
-	echo "./mq_open_tests /test1 || echo \"selftests: mq_open_tests [FAIL]\""
-	echo "./mq_perf_tests || echo \"selftests: mq_perf_tests [FAIL]\""
+	echo "./mq_open_tests /test1 && echo \"selftests: mq_open_tests [PASS]\" || echo \"selftests: mq_open_tests [FAIL]\""
+	echo "./mq_perf_tests && echo \"selftests: mq_perf_tests [PASS]\" || echo \"selftests: mq_perf_tests [FAIL]\""
 endef
 

Thanks for the patch. I plan to get this into 4.15-rc1

-- Shuah