selftests: memfd_test.c: fix compilation warning.
PATCH 1/1 selftests: memfd_test.c: fix compilation warning.
Replace '%d' by '%zu' to fix the following compilation warning.
memfd_test.c:517:3: warning: format ‘%d’ expects argument of type ‘int’,but argument 2 has type ‘size_t’ [-Wformat=]
printf("malloc(%d) failed: %m\n", mfd_def_size * 8); ^memfd_test.c: In function ‘mfd_fail_grow_write’:
memfd_test.c:537:3: warning: format ‘%d’ expects argument of type ‘int’,but argument 2 has type ‘size_t’ [-Wformat=]
printf("malloc(%d) failed: %m\n", mfd_def_size * 8);
--- tools/testing/selftests/memfd/memfd_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/memfd/memfd_test.c +2 -2
@@ -514,7 +514,7 @@ static void mfd_assert_grow_write(int fd) buf =malloc (mfd_def_size *8 );if (!buf) { -printf ("malloc(%d) failed: %m\n" , mfd_def_size *8 ); +printf ("malloc(%zu) failed: %m\n" , mfd_def_size *8 );abort (); }
@@ -534,7 +534,7 @@ static void mfd_fail_grow_write(int fd) buf =malloc (mfd_def_size *8 );if (!buf) { -printf ("malloc(%d) failed: %m\n" , mfd_def_size *8 ); +printf ("malloc(%zu) failed: %m\n" , mfd_def_size *8 );abort (); }
Signature · 1 line
1.9.1
Quoted 31 lines · Lei Yang
Replace '%d' by '%zu' to fix the following compilation warning.
memfd_test.c:517:3: warning: format ‘%d’ expects argument of type ‘int’,but argument 2 has type ‘size_t’ [-Wformat=]
printf("malloc(%d) failed: %m\n", mfd_def_size * 8); ^
memfd_test.c: In function ‘mfd_fail_grow_write’:
memfd_test.c:537:3: warning: format ‘%d’ expects argument of type ‘int’,but argument 2 has type ‘size_t’ [-Wformat=]
printf("malloc(%d) failed: %m\n", mfd_def_size * 8);Signed-off-by Lei Yang <[email protected]>--- tools/testing/selftests/memfd/memfd_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/testing/selftests/memfd/memfd_test.c +1
-1@@ -514,7 +514,7 @@ static void mfd_assert_grow_write(int fd) buf =malloc (mfd_def_size *8 );if (!buf) { -printf ("malloc(%d) failed: %m\n" , mfd_def_size *8 ); +printf ("malloc(%zu) failed: %m\n" , mfd_def_size *8 );abort (); }
tools/testing/selftests/memfd/memfd_test.c static void mfd_fail_grow_write(int fd) · line 540
Quoted 8 lines
tools/testing/selftests/memfd/memfd_test.c +1
-1@@ -534,7 +534,7 @@ static void mfd_fail_grow_write(int fd) buf =malloc (mfd_def_size *8 );if (!buf) { -printf ("malloc(%d) failed: %m\n" , mfd_def_size *8 ); +printf ("malloc(%zu) failed: %m\n" , mfd_def_size *8 );abort (); }
Relates to gcc version perhaps. What's your gcc version?
thanks,
-- Shuah
Quoted 32 lines · Shuah Khan
Quoted 31 lines · Lei Yang
Replace '%d' by '%zu' to fix the following compilation warning.
memfd_test.c:517:3: warning: format ‘%d’ expects argument of type ‘int’,but argument 2 has type ‘size_t’ [-Wformat=]
printf("malloc(%d) failed: %m\n", mfd_def_size * 8); ^ memfd_test.c: In function ‘mfd_fail_grow_write’: memfd_test.c:537:3: warning: format ‘%d’ expects argument of type ‘int’,but argument 2 has type ‘size_t’ [-Wformat=] printf("malloc(%d) failed: %m\n", mfd_def_size * 8);Signed-off-by Lei Yang <[email protected]>--- tools/testing/selftests/memfd/memfd_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/testing/selftests/memfd/memfd_test.c +1
-1@@ -514,7 +514,7 @@ static void mfd_assert_grow_write(int fd) buf =malloc (mfd_def_size *8 );if (!buf) { -printf ("malloc(%d) failed: %m\n" , mfd_def_size *8 ); +printf ("malloc(%zu) failed: %m\n" , mfd_def_size *8 );abort (); }@@ -534,7 +534,7 @@ static void mfd_fail_grow_write(int fd)
Quoted 9 lines
tools/testing/selftests/memfd/memfd_test.c static void mfd_assert_grow_write(int fd) · line 520
Quoted 8 lines
tools/testing/selftests/memfd/memfd_test.c +1
-1buf =malloc (mfd_def_size *8 );if (!buf) { -printf ("malloc(%d) failed: %m\n" , mfd_def_size *8 ); +printf ("malloc(%zu) failed: %m\n" , mfd_def_size *8 );abort (); }Relates to gcc version perhaps. What's your gcc version?
$ cat /proc/version Linux version 3.16.0-30-generic (buildd@kissel) (gcc version 4.8.2 (Ubuntu 4.8.2-19ubuntu1) ) #40~14.04.1-Ubuntu SMP Thu Jan 15 17:43:14 UTC 2015
Lei
Quoted 2 lines
thanks,
-- Shuah
I got the same warning even with ubuntu new distro, this patch fixed this issue.
$ gcc --version gcc (Ubuntu 6.3.0-12ubuntu2) 6.3.0 20170406 Copyright (C) 2016 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
$ make -v GNU Make 4.1 Built for x86_64-pc-linux-gnu Copyright (C) 1988-2014 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. $ uname -a Linux pek-lyang0-u17 4.10.0-38-generic #42-Ubuntu SMP Tue Oct 10 13:24:27 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
---------------------
memfd_test.c: In function mfd_assert_grow_write:
memfd_test.c:517:19: warning: format %d expects argument of type int, but argument 2 has type size_t {aka long unsigned int} [-Wformat=]
printf("malloc(%d) failed: %m\n", mfd_def_size * 8);
^
memfd_test.c: In function mfd_fail_grow_write:
memfd_test.c:537:19: warning: format %d expects argument of type int,
but argument 2 has type size_t {aka long unsigned int} [-Wformat=]
printf("malloc(%d) failed: %m\n", mfd_def_size * 8);Lei
Quoted 42 lines · Shuah Khan
Quoted 31 lines · Lei Yang
Replace '%d' by '%zu' to fix the following compilation warning.
memfd_test.c:517:3: warning: format ‘%d’ expects argument of type ‘int’,but argument 2 has type ‘size_t’ [-Wformat=]
printf("malloc(%d) failed: %m\n", mfd_def_size * 8); ^ memfd_test.c: In function ‘mfd_fail_grow_write’: memfd_test.c:537:3: warning: format ‘%d’ expects argument of type ‘int’,but argument 2 has type ‘size_t’ [-Wformat=] printf("malloc(%d) failed: %m\n", mfd_def_size * 8);Signed-off-by Lei Yang <Lei.Yang at windriver.com>--- tools/testing/selftests/memfd/memfd_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/testing/selftests/memfd/memfd_test.c +1
-1@@ -514,7 +514,7 @@ static void mfd_assert_grow_write(int fd) buf =malloc (mfd_def_size *8 );if (!buf) { -printf ("malloc(%d) failed: %m\n" , mfd_def_size *8 ); +printf ("malloc(%zu) failed: %m\n" , mfd_def_size *8 );abort (); }tools/testing/selftests/memfd/memfd_test.c static void mfd_fail_grow_write(int fd) · line 540
Quoted 8 lines
tools/testing/selftests/memfd/memfd_test.c +1
-1@@ -534,7 +534,7 @@ static void mfd_fail_grow_write(int fd) buf =malloc (mfd_def_size *8 );if (!buf) { -printf ("malloc(%d) failed: %m\n" , mfd_def_size *8 ); +printf ("malloc(%zu) failed: %m\n" , mfd_def_size *8 );abort (); }Relates to gcc version perhaps. What's your gcc version?
Quoted 2 lines
thanks,
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 4 lines · Lei Yang
Replace '%d' by '%zu' to fix the following compilation warning.
memfd_test.c:517:3: warning: format ‘%d’ expects argument of type ‘int’,but argument 2 has type ‘size_t’ [-Wformat=]
Quoted 8 lines
printf("malloc(%d) failed: %m\n", mfd_def_size * 8); ^
memfd_test.c: In function ‘mfd_fail_grow_write’:
memfd_test.c:537:3: warning: format ‘%d’ expects argument of type ‘int’,but argument 2 has type ‘size_t’ [-Wformat=]
printf("malloc(%d) failed: %m\n", mfd_def_size * 8);Signed-off-by Lei Yang <Lei.Yang at windriver.com>
Thanks for the patch. Applied to linux-kselftest next for 4.15-rc1
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html