Skip to contentSkip to conversation

selftests: futex: fix compilation error

PATCH In review Lei Yang 2 participants 8 messages Nov 6, 2017 – Nov 8, 2017

Subsystems (2)
lore
Share & tools
lore

Lei Yang

author
#0 lore raw

PATCH 1/1 selftests: futex: fix compilation error

I run into below error when building futext /bin/sh: -c: line 5: syntax error: unexpected end of file

the closing ";" and "\" are necessary.
My OS is "Ubuntu 14.04.5 LTS"

---
 tools/testing/selftests/futex/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
tools/testing/selftests/futex/Makefile +3 -3
index f0c0369..943f3a2 100644
@@ -11,9 +11,9 @@ all:
 		BUILD_TARGET=$(OUTPUT)/$$DIR;	\
 		mkdir $$BUILD_TARGET  -p;	\
 		make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
-		if [ -e $$DIR/$(TEST_PROGS) ]; then
-			rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
-		fi
+		if [ -e $$DIR/$(TEST_PROGS) ]; then \
+			rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
+		fi \
 	done
 
 override define RUN_TESTS
Signature · 1 line
1.9.1
#1 lore raw
Quoted 19 lines · Lei Yang

I run into below error when building futext /bin/sh: -c: line 5: syntax error: unexpected end of file

the closing ";" and "\" are necessary.
My OS is "Ubuntu 14.04.5 LTS"

---
 tools/testing/selftests/futex/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
tools/testing/selftests/futex/Makefile +0 -0
index f0c0369..943f3a2 100644
@@ -11,9 +11,9 @@ all:
 		BUILD_TARGET=$(OUTPUT)/$$DIR;	\
 		mkdir $$BUILD_TARGET  -p;	\

tools/testing/selftests/futex/Makefile all: · line 19

Quoted 10 lines
tools/testing/selftests/futex/Makefile +3 -3
 		make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
-		if [ -e $$DIR/$(TEST_PROGS) ]; then
-			rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
-		fi
+		if [ -e $$DIR/$(TEST_PROGS) ]; then \
+			rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
+		fi \
 	done
 
 override define RUN_TESTS

Hmm. I don't see this error on linux_4.14-rc8?

Can you give more details on the gcc version you are using?

thanks,
-- Shuah

#2 lore raw
Quoted 28 lines · Shuah Khan
Quoted 27 lines · Lei Yang

I run into below error when building futext /bin/sh: -c: line 5: syntax error: unexpected end of file

the closing ";" and "\" are necessary.
My OS is "Ubuntu 14.04.5 LTS"

---
 tools/testing/selftests/futex/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
tools/testing/selftests/futex/Makefile +3 -3
index f0c0369..943f3a2 100644
@@ -11,9 +11,9 @@ all:
 		BUILD_TARGET=$(OUTPUT)/$$DIR;	\
 		mkdir $$BUILD_TARGET  -p;	\
 		make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
-		if [ -e $$DIR/$(TEST_PROGS) ]; then
-			rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
-		fi
+		if [ -e $$DIR/$(TEST_PROGS) ]; then \
+			rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
+		fi \
 	done
 
Quoted 6 lines

tools/testing/selftests/futex/Makefile all: · line 19

Quoted 2 lines
tools/testing/selftests/futex/Makefile +0 -0
 override define RUN_TESTS

Hmm. I don't see this error on linux_4.14-rc8?

Can you give more details on the gcc version you are using?

I meant gnumake version? I am not seeing the failure with what I am using

thanks,
-- Shuah

author
#3 lore raw
Quoted 29 lines · Shuah Khan
Quoted 28 lines · Shuah Khan
Quoted 27 lines · Lei Yang

I run into below error when building futext /bin/sh: -c: line 5: syntax error: unexpected end of file

the closing ";" and "\" are necessary.
My OS is "Ubuntu 14.04.5 LTS"

---
  tools/testing/selftests/futex/Makefile | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
tools/testing/selftests/futex/Makefile +3 -3
index f0c0369..943f3a2 100644
@@ -11,9 +11,9 @@ all:
  		BUILD_TARGET=$(OUTPUT)/$$DIR;	\
  		mkdir $$BUILD_TARGET  -p;	\
  		make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
-		if [ -e $$DIR/$(TEST_PROGS) ]; then
-			rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
-		fi
+		if [ -e $$DIR/$(TEST_PROGS) ]; then \
+			rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
+		fi \
  	done
 
Quoted 8 lines
Quoted 5 lines

tools/testing/selftests/futex/Makefile all: · line 19

Quoted 2 lines
tools/testing/selftests/futex/Makefile +0 -0
  override define RUN_TESTS

Hmm. I don't see this error on linux_4.14-rc8?

Can you give more details on the gcc version you are using?

I meant gnumake version? I am not seeing the failure with what I am using

$ make -v
GNU Make 3.81
Copyright (C) 2006  Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.

This program built for x86_64-pc-linux-gnu

Lei

Quoted 3 lines

thanks,
-- Shuah

#4 lore raw
Quoted 47 lines · lei yang
Quoted 32 lines · Shuah Khan
Quoted 31 lines · Shuah Khan
Quoted 25 lines · Lei Yang

I run into below error when building futext /bin/sh: -c: line 5: syntax error: unexpected end of file

the closing ";" and "\" are necessary.
My OS is "Ubuntu 14.04.5 LTS"

Signed-off-by Lei Yang <Lei.Yang at windriver.com>

---
  tools/testing/selftests/futex/Makefile | 6 +++---

  1 file changed, 3 insertions(+), 3 deletions(-)
tools/testing/selftests/futex/Makefile +3 -3
index f0c0369..943f3a2 100644
@@ -11,9 +11,9 @@ all:
           BUILD_TARGET=$(OUTPUT)/$$DIR;    \
           mkdir $$BUILD_TARGET  -p;    \
           make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
-        if [ -e $$DIR/$(TEST_PROGS) ]; then
-            rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
-        fi
+        if [ -e $$DIR/$(TEST_PROGS) ]; then \
+            rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
+        fi \
Quoted 3 lines

      done
    override define RUN_TESTS

Hmm. I don't see this error on linux_4.14-rc8?

Quoted 4 lines
Quoted 1 line

Can you give more details on the gcc version you are using?

I meant gnumake version? I am not seeing the failure with what I am using

$ make -v
GNU Make 3.81
Copyright (C) 2006  Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.
Quoted 5 lines

This program built for x86_64-pc-linux-gnu

Lei

I can't take patches that aren't tested on the latest kernel release. 3.16 is very old. I am not going reply to other patches you sent.

Please make sure the patches are based on the latest release and tested on it as well.

thanks,
-- Shuah

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#5 lore raw
Quoted 48 lines · Shuah Khan
Quoted 47 lines · lei yang
Quoted 32 lines · Shuah Khan
Quoted 31 lines · Shuah Khan
Quoted 18 lines · Lei Yang

I run into below error when building futext /bin/sh: -c: line 5: syntax error: unexpected end of file

the closing ";" and "\" are necessary.
My OS is "Ubuntu 14.04.5 LTS"

Signed-off-by Lei Yang <Lei.Yang at windriver.com>
---
   tools/testing/selftests/futex/Makefile | 6 +++---
   1 file changed, 3 insertions(+), 3 deletions(-)
tools/testing/selftests/futex/Makefile +0 -0
index f0c0369..943f3a2 100644
@@ -11,9 +11,9 @@ all:
           BUILD_TARGET=$(OUTPUT)/$$DIR;    \
           mkdir $$BUILD_TARGET  -p;    \

tools/testing/selftests/futex/Makefile all: · line 19

Quoted 10 lines
tools/testing/selftests/futex/Makefile +3 -3
           make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
-        if [ -e $$DIR/$(TEST_PROGS) ]; then
-            rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
-        fi
+        if [ -e $$DIR/$(TEST_PROGS) ]; then \
+            rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
+        fi \
       done
     override define RUN_TESTS
 

Hmm. I don't see this error on linux_4.14-rc8?

Quoted 3 lines
Quoted 1 line

Can you give more details on the gcc version you are using?

I meant gnumake version? I am not seeing the failure with what I am using

$ make -v
GNU Make 3.81
Copyright (C) 2006  Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.

This program built for x86_64-pc-linux-gnu

Quoted 7 lines
Quoted 2 lines

Lei

I can't take patches that aren't tested on the latest kernel release. 3.16 is very old. I am not going reply to other patches you sent.

Please make sure the patches are based on the latest release and tested on it as well.

this error only happens when use old version "make", it has nothing to do with the new or old kernel.

so the question is do we need to be compatible with old "make" ?

Lei

Quoted 10 lines

thanks,
-- Shuah

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

#6 lore raw
Quoted 56 lines · lei yang
Quoted 53 lines · Shuah Khan
Quoted 44 lines · lei yang
Quoted 32 lines · Shuah Khan
Quoted 31 lines · Shuah Khan
Quoted 25 lines · Lei Yang

I run into below error when building futext /bin/sh: -c: line 5: syntax error: unexpected end of file

the closing ";" and "\" are necessary.
My OS is "Ubuntu 14.04.5 LTS"

Signed-off-by Lei Yang <Lei.Yang at windriver.com>

---
   tools/testing/selftests/futex/Makefile | 6 +++---

   1 file changed, 3 insertions(+), 3 deletions(-)
tools/testing/selftests/futex/Makefile +3 -3
index f0c0369..943f3a2 100644
@@ -11,9 +11,9 @@ all:
            BUILD_TARGET=$(OUTPUT)/$$DIR;    \
            mkdir $$BUILD_TARGET  -p;    \
            make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
-        if [ -e $$DIR/$(TEST_PROGS) ]; then
-            rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
-        fi
+        if [ -e $$DIR/$(TEST_PROGS) ]; then \
+            rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
+        fi \
Quoted 3 lines

       done
     override define RUN_TESTS

Hmm. I don't see this error on linux_4.14-rc8?

Quoted 3 lines
Quoted 1 line

Can you give more details on the gcc version you are using?

I meant gnumake version? I am not seeing the failure with what I am using

$ make -v
GNU Make 3.81
Copyright (C) 2006  Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.
Quoted 5 lines

This program built for x86_64-pc-linux-gnu

Lei

I can't take patches that aren't tested on the latest kernel release. 3.16 is very old. I am not going reply to other patches you sent.

Quoted 9 lines
Quoted 2 lines

Please make sure the patches are based on the latest release and tested on it as well.

this error only happens when use old version "make", it has nothing to do with the new or old kernel.

so the question is  do we need to be compatible with old "make" ?

Lei

Like I said, Linux 3.16 kernel is very old and I won't take patches that are tested on it.

thanks,
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#7 lore raw
In reply to Shuah Khan
Quoted 28 lines · Shuah Khan
Quoted 27 lines · Lei Yang

I run into below error when building futext /bin/sh: -c: line 5: syntax error: unexpected end of file

the closing ";" and "\" are necessary.
My OS is "Ubuntu 14.04.5 LTS"

---
  tools/testing/selftests/futex/Makefile | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
tools/testing/selftests/futex/Makefile +3 -3
index f0c0369..943f3a2 100644
@@ -11,9 +11,9 @@ all:
  		BUILD_TARGET=$(OUTPUT)/$$DIR;	\
  		mkdir $$BUILD_TARGET  -p;	\
  		make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
-		if [ -e $$DIR/$(TEST_PROGS) ]; then
-			rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
-		fi
+		if [ -e $$DIR/$(TEST_PROGS) ]; then \
+			rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
+		fi \
  	done
 
Quoted 5 lines

tools/testing/selftests/futex/Makefile all: · line 19

Quoted 2 lines
tools/testing/selftests/futex/Makefile +0 -0
  override define RUN_TESTS

Hmm. I don't see this error on linux_4.14-rc8?

Can you give more details on the gcc version you are using?

$ cat /proc/version
Linux version 3.16.0-30-generic (buildd@kissel) (gcc version 4.8.2 (Ubuntu 4.8.2-19ubuntu1) ) #40~14.04.1-Ubuntu SMP Thu Jan 15 17:43:14 UTC 2015
$ uname -a
Linux pek-lyang0-d1 3.16.0-30-generic #40~14.04.1-Ubuntu SMP Thu Jan 15 17:43:14 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

I'm also surprised why nobody report this ? I thought it's because ksefltest community is not active :-)

Lei

Quoted 2 lines

thanks,
-- Shuah