x86, build: Make genimage.sh little more quite
PATCH 1/1 x86, build: Make genimage.sh little more quite
From: Changbin Du <[email protected]>
This change suppresses the 'dd' output and adds '-quite' parameter to mkisofs tool. None of the messages matter to the user. Now:
$ make isoimage ... Kernel: arch/x86/boot/bzImage is ready (#75) GENIMAGE arch/x86/boot/image.iso Using /usr/lib/ISOLINUX/isolinux.bin Using /usr/lib/syslinux/modules/bios/ldlinux.c32 Kernel: arch/x86/boot/image.iso is ready
--- arch/x86/boot/genimage.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/x86/boot/genimage.sh +3 -3
@@ -50,7 +50,7 @@ genbzdisk() { } genfdimage144() { - dd if=/dev/zero of=$FIMAGE bs=1024 count=1440 + dd if=/dev/zero of=$FIMAGE bs=1024 count=1440 2> /dev/null mformat v: syslinux $FIMAGE echo "$KCMDLINE" | mcopy - v:syslinux.cfg
@@ -61,7 +61,7 @@ genfdimage144() { } genfdimage288() { - dd if=/dev/zero of=$FIMAGE bs=1024 count=2880 + dd if=/dev/zero of=$FIMAGE bs=1024 count=2880 2> /dev/null mformat w: syslinux $FIMAGE echo "$KCMDLINE" | mcopy - W:syslinux.cfg
@@ -103,7 +103,7 @@ genisoimage() { if [ -f "$FDINITRD" ] ; then cp "$FDINITRD" $tmp_dir/initrd.img fi - mkisofs -J -r -input-charset=utf-8 -o $FIMAGE -b isolinux.bin \ + mkisofs -J -r -input-charset=utf-8 -quiet -o $FIMAGE -b isolinux.bin \ -c boot.cat -no-emul-boot -boot-load-size 4 -boot-info-table \ $tmp_dir isohybrid $FIMAGE 2>/dev/null || true
Signature · 1 line
2.7.4
Quoted 5 lines · * [email protected] <[email protected]> wrote:
From: Changbin Du <[email protected]>
This change suppresses the 'dd' output and adds '-quite' parameter to mkisofs tool. None of the messages matter to the user. Now:
Quoted 7 lines
$ make isoimage ... Kernel: arch/x86/boot/bzImage is ready (#75) GENIMAGE arch/x86/boot/image.iso Using /usr/lib/ISOLINUX/isolinux.bin Using /usr/lib/syslinux/modules/bios/ldlinux.c32 Kernel: arch/x86/boot/image.iso is ready
Could you please also remove the other unnecessary lines as well, from the default build log:
Quoted 3 lines
Using
/usr/lib/ISOLINUX/isolinux.bin
Using/usr/lib/syslinux/modules/bios/ldlinux.c32
Kernel:arch/x86/boot/image.isois ready
The build process is using a ton of files and we don't list them. Maybe print them when V=1, but not by default.
The only lines printed should be:
Quoted 2 lines
Kernel:
arch/x86/boot/bzImageis ready (#75)
GENIMAGEarch/x86/boot/image.iso
Users are totally not interested in the details. They want to see a single line of output about which file is being built, but that's it.
Thanks,
Ingo
Quoted 26 lines · Ingo Molnar
Quoted 5 lines · * [email protected] <[email protected]> wrote:
From: Changbin Du <[email protected]>
This change suppresses the 'dd' output and adds '-quite' parameter to mkisofs tool. None of the messages matter to the user. Now:
Quoted 7 lines
$ make isoimage ... Kernel: arch/x86/boot/bzImage is ready (#75) GENIMAGE arch/x86/boot/image.iso Using /usr/lib/ISOLINUX/isolinux.bin Using /usr/lib/syslinux/modules/bios/ldlinux.c32 Kernel: arch/x86/boot/image.iso is readyCould you please also remove the other unnecessary lines as well, from the default build log:
Quoted 3 lines
Using
/usr/lib/ISOLINUX/isolinux.bin
Using/usr/lib/syslinux/modules/bios/ldlinux.c32
Kernel:arch/x86/boot/image.isois readyThe build process is using a ton of files and we don't list them. Maybe print them when V=1, but not by default.
Quoted 8 lines
The only lines printed should be:
Quoted 2 lines
Kernel:
arch/x86/boot/bzImageis ready (#75)
GENIMAGEarch/x86/boot/image.isoUsers are totally not interested in the details. They want to see a single line of output about which file is being built, but that's it.
I agree with you. So I will remove the 'Using ...', and 'set -x' if V=1.
Quoted 3 lines
Thanks,
Ingo
Signature · 2 lines
Thanks, Changbin Du