Fix: Removed warning.
A message that is not in the archive (sent off-list or not yet received): 1510175310533.3725.5766@webmail3
Quoted 25 lines · Ola Næss Kaldestad
Removed unnecessary else statement after return.
Signed-off-by Ola N. Kaldestad <[email protected]>---
kernel/sysctl.c| 6 +++---1 file changed, 3 insertions(+), 3 deletions(-)kernel/sysctl.c +3
-3@@ -3093,10 +3093,10 @@ int proc_do_large_bitmap(struct ctl_table *table,int write, *lenp -= left; *ppos += *lenp;return 0 ; - }else { -kfree (tmp_bitmap); -return err; } + +kfree (tmp_bitmap); +return err; }
Quoted 2 lines
#else /*
CONFIG_PROC_SYSCTL*/
This patch appears to be white-space damaged. I think this could actually be improved further too, since the "if" case also does kfree(tmp_bitmap); and return err; (where err==0). Maybe just this, instead? (This patch will probably be whitespace damaged too, via gmail.)
kernel/sysctl.c +0 -0
@@ -3089,14 +3089,12 @@ int proc_do_large_bitmap(struct ctl_table
*table, int write,
else
bitmap_copy(bitmap, tmp_bitmap, bitmap_len);
}
- kfree(tmp_bitmap);
*lenp -= left;
*ppos += *lenp;
- return 0;
- } else {
- kfree(tmp_bitmap);
- return err;
}+
+ kfree(tmp_bitmap);
+ return err;
}
#else /* CONFIG_PROC_SYSCTL */
Signature · 2 lines
Kees Cook Pixel Security