GuC functions name/prototype update
Subsystems (2)
cover GuC functions name/prototype update
We want to have consistent function/structure/file naming and function parameter semantics. Suggestion from Michal Wajdeczko about using "genx_" prefix (or better _genx" suffix for all hw related structures types, offsets), "i915_" prefix for driver entry calls and "intel_" in all other seems to be the good scheme to go ahead. Also we need to adhere to practise of passing drm_i915_private to functions with "i915_" prefix and component structure to functions with "intel_" prefix. This series updates GuC submission related code with these changes.
With GuC submission being hardware interface for i915, we should name those functions with prefix "intel_guc" and pass struct intel_guc as parameter. Also i915_guc_client struct is kernel-hw interaction structure hence rename that to intel_guc_client.
With these changes GuC submission source files are now named with "intel_" prefix.
Please add to Cc as I might not have covered all interested in this change.
(Ignore checkpatch errors in patch 2&3 as they are not introduced by this series)
Sagar Arun Kamble (3):
drm/i915/guc: Update name and prototype of GuC submission related
functions
drm/i915/guc: Rename i915_guc_client struct to intel_guc_client drm/i915/guc: Rename i915_guc_submission.c|h to
intel_guc_submission.c|h
drivers/gpu/drm/i915/Makefile | 4 +- drivers/gpu/drm/i915/i915_debugfs.c | 6 +- drivers/gpu/drm/i915/i915_guc_submission.c | 1466 --------------------------- drivers/gpu/drm/i915/i915_guc_submission.h | 80 -- drivers/gpu/drm/i915/intel_guc.c | 2 +- drivers/gpu/drm/i915/intel_guc.h | 6 +- drivers/gpu/drm/i915/intel_guc_submission.c | 1463 ++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_guc_submission.h | 80 ++ drivers/gpu/drm/i915/intel_uc.c | 12 +- 9 files changed, 1558 insertions(+), 1561 deletions(-) delete mode 100644 drivers/gpu/drm/i915/i915_guc_submission.c delete mode 100644 drivers/gpu/drm/i915/i915_guc_submission.h create mode 100644 drivers/gpu/drm/i915/intel_guc_submission.c create mode 100644 drivers/gpu/drm/i915/intel_guc_submission.h
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
RFC 1/3 drm/i915/guc: Update name and prototype of GuC submission related functions
i915 GuC submission is hardware interface and GuC APIs that are not user facing should be intel_guc* hence we change GuC submission related functions name prefix to intel_guc. Also changed the parameter to these functions to intel_guc struct.
--- drivers/gpu/drm/i915/i915_guc_submission.c | 39 ++++++++++++++---------------- drivers/gpu/drm/i915/i915_guc_submission.h | 8 +++--- drivers/gpu/drm/i915/intel_uc.c | 10 ++++---- 3 files changed, 27 insertions(+), 30 deletions(-)
drivers/gpu/drm/i915/i915_guc_submission.c +18 -21
@@ -683,13 +683,13 @@ static void wait_for_guc_preempt_report(struct intel_engine_cs *engine) }/** -* i915_guc_submit() - Submit commands through GuC +* intel_guc_submit() - Submit commands through GuC * @engine: engine associated with the commands * * The only error here arises if the doorbell hardware isn't functioning * as expected, which really shouln't happen. */ -static void i915_guc_submit (struct intel_engine_cs *engine) +static void intel_guc_submit (struct intel_engine_cs *engine) {struct intel_guc *guc = &engine->i915->guc;struct intel_engine_execlists *const execlists = &engine->execlists;
@@ -722,7 +722,7 @@ static void port_assign(struct execlist_port *port,port_set (port,port_pack (i915_gem_request_get (rq),port_count (port))); } -static void i915_guc_dequeue (struct intel_engine_cs *engine) +static void intel_guc_dequeue (struct intel_engine_cs *engine) {struct intel_engine_execlists *const execlists = &engine->execlists;struct execlist_port *port = execlists->port;
@@ -793,13 +793,13 @@ static void i915_guc_dequeue(struct intel_engine_cs *engine)if (submit) {port_assign (port, last);execlists_set_active (execlists,EXECLISTS_ACTIVE_USER ); -i915_guc_submit (engine); +intel_guc_submit (engine); } unlock:spin_unlock_irq (&engine->timeline->lock); } -static void i915_guc_irq_handler (unsigned long data) +static void intel_guc_irq_handler (unsigned long data) {struct intel_engine_cs *const engine = (struct intel_engine_cs *)data;struct intel_engine_execlists *const execlists = &engine->execlists;
@@ -831,13 +831,13 @@ static void i915_guc_irq_handler(unsigned long data) }if (!execlists_is_active (execlists,EXECLISTS_ACTIVE_PREEMPT )) -i915_guc_dequeue (engine); +intel_guc_dequeue (engine); }/* * Everything below here is concerned with setup & teardown, and is * therefore not part of the somewhat time-critical batch-submission -* path of i915_guc_submit() above. +* path of intel_guc_submit() above. */ /* Check that a doorbell register is in the expected state */
@@ -1253,9 +1253,8 @@ static void guc_preempt_work_destroy(struct intel_guc *guc)* Set up the memory resources to be shared with the GuC (via the GGTT) * at firmware loading time. */ -int i915_guc_submission_init (struct drm_i915_private *dev_priv) +int intel_guc_submission_init (struct intel_guc *guc) { -struct intel_guc *guc = &dev_priv->guc;int ret;if (guc->stage_desc_pool)
@@ -1302,10 +1301,8 @@ int i915_guc_submission_init(struct drm_i915_private *dev_priv)return ret; } -void i915_guc_submission_fini (struct drm_i915_private *dev_priv) +void intel_guc_submission_fini (struct intel_guc *guc) { -struct intel_guc *guc = &dev_priv->guc; -guc_ads_destroy (guc);guc_preempt_work_destroy (guc);intel_guc_log_destroy (guc);
@@ -1381,19 +1378,19 @@ static void guc_interrupts_release(struct drm_i915_private *dev_priv) rps->pm_intrmsk_mbz &= ~ARAT_EXPIRED_INTRMSK ; } -static void i915_guc_submission_park (struct intel_engine_cs *engine) +static void intel_guc_submission_park (struct intel_engine_cs *engine) {intel_engine_unpin_breadcrumbs_irq (engine); } -static void i915_guc_submission_unpark (struct intel_engine_cs *engine) +static void intel_guc_submission_unpark (struct intel_engine_cs *engine) {intel_engine_pin_breadcrumbs_irq (engine); } -int i915_guc_submission_enable (struct drm_i915_private *dev_priv) +int intel_guc_submission_enable (struct intel_guc *guc) { -struct intel_guc *guc = &dev_priv->guc; +struct drm_i915_private *dev_priv =guc_to_i915 (guc);struct intel_engine_cs *engine;enum intel_engine_id id;int err;
@@ -1439,9 +1436,9 @@ int i915_guc_submission_enable(struct drm_i915_private *dev_priv)for_each_engine (engine, dev_priv, id) {struct intel_engine_execlists *const execlists = &engine->execlists; - execlists->irq_tasklet.func = i915_guc_irq_handler; - engine->park = i915_guc_submission_park; - engine->unpark = i915_guc_submission_unpark; + execlists->irq_tasklet.func = intel_guc_irq_handler; + engine->park = intel_guc_submission_park; + engine->unpark = intel_guc_submission_unpark; }return 0 ;
@@ -1451,9 +1448,9 @@ int i915_guc_submission_enable(struct drm_i915_private *dev_priv)return err; } -void i915_guc_submission_disable (struct drm_i915_private *dev_priv) +void intel_guc_submission_disable (struct intel_guc *guc) { -struct intel_guc *guc = &dev_priv->guc; +struct drm_i915_private *dev_priv =guc_to_i915 (guc);GEM_BUG_ON (dev_priv->gt.awake);/* GT should be parked first */
drivers/gpu/drm/i915/i915_guc_submission.h +4 -4
@@ -72,9 +72,9 @@ struct i915_guc_client { u64 submissions[I915_NUM_ENGINES]; }; -int i915_guc_submission_init (struct drm_i915_private *dev_priv); -int i915_guc_submission_enable (struct drm_i915_private *dev_priv); -void i915_guc_submission_disable (struct drm_i915_private *dev_priv); -void i915_guc_submission_fini (struct drm_i915_private *dev_priv); +int intel_guc_submission_init (struct intel_guc *guc); +int intel_guc_submission_enable (struct intel_guc *guc); +void intel_guc_submission_disable (struct intel_guc *guc); +void intel_guc_submission_fini (struct intel_guc *guc);#endif
drivers/gpu/drm/i915/intel_uc.c +5 -5
@@ -168,7 +168,7 @@ int intel_uc_init_hw(struct drm_i915_private *dev_priv)* This is stuff we need to have available at fw load time * if we are planning to enable submission later */ - ret =i915_guc_submission_init (dev_priv); + ret =intel_guc_submission_init (guc);if (ret) goto err_guc; }
@@ -217,7 +217,7 @@ int intel_uc_init_hw(struct drm_i915_private *dev_priv)if (i915_modparams.guc_log_level >=0 )gen9_enable_guc_interrupts (dev_priv); - ret =i915_guc_submission_enable (dev_priv); + ret =intel_guc_submission_enable (guc);if (ret) goto err_interrupts; }
@@ -246,7 +246,7 @@ int intel_uc_init_hw(struct drm_i915_private *dev_priv)guc_capture_load_err_log (guc); err_submission:if (i915_modparams.enable_guc_submission) -i915_guc_submission_fini (dev_priv); +intel_guc_submission_fini (guc); err_guc:i915_ggtt_disable_guc (dev_priv);
@@ -277,13 +277,13 @@ void intel_uc_fini_hw(struct drm_i915_private *dev_priv)return ;if (i915_modparams.enable_guc_submission) -i915_guc_submission_disable (dev_priv); +intel_guc_submission_disable (&dev_priv->guc);guc_disable_communication (&dev_priv->guc);if (i915_modparams.enable_guc_submission) {gen9_disable_guc_interrupts (dev_priv); -i915_guc_submission_fini (dev_priv); +intel_guc_submission_fini (&dev_priv->guc); }i915_ggtt_disable_guc (dev_priv);
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
RFC 2/3 drm/i915/guc: Rename i915_guc_client struct to intel_guc_client
In reply to Sagar Arun KambleGuC submission clients are currently being used in kernel only hence update the structure name to intel_guc_client.
--- drivers/gpu/drm/i915/i915_debugfs.c | 4 +- drivers/gpu/drm/i915/i915_guc_submission.c | 62 +++++++++++++++--------------- drivers/gpu/drm/i915/i915_guc_submission.h | 2 +- drivers/gpu/drm/i915/intel_guc.h | 6 +-- 4 files changed, 37 insertions(+), 37 deletions(-)
drivers/gpu/drm/i915/i915_debugfs.c +2 -2
@@ -2434,7 +2434,7 @@ static void i915_guc_log_info(struct seq_file *m,static void i915_guc_client_info (struct seq_file *m,struct drm_i915_private *dev_priv, -struct i915_guc_client *client) +struct intel_guc_client *client) {struct intel_engine_cs *engine;enum intel_engine_id id;
@@ -2499,7 +2499,7 @@ static int i915_guc_stage_pool(struct seq_file *m, void *data)struct drm_i915_private *dev_priv =node_to_i915 (m->private);const struct intel_guc *guc = &dev_priv->guc;struct guc_stage_desc *desc = guc->stage_desc_pool_vaddr; -struct i915_guc_client *client = guc->execbuf_client; +struct intel_guc_client *client = guc->execbuf_client;unsigned int tmp;int index;
drivers/gpu/drm/i915/i915_guc_submission.c +31 -31
239 lines not on this page · raw message
drivers/gpu/drm/i915/i915_guc_submission.h +1 -1
@@ -52,7 +52,7 @@* queue (a circular array of work items), again described in the process * descriptor. Work queue pages are mapped momentarily as required. */ -struct i915_guc_client { +struct intel_guc_client {struct i915_vma *vma;void *vaddr;struct i915_gem_context *owner;
drivers/gpu/drm/i915/intel_guc.h +3 -3
@@ -41,7 +41,7 @@ struct guc_preempt_work {/* * Top level structure of GuC. It handles firmware loading and manages client -* pool and doorbells. intel_guc owns a i915_guc_client to replace the legacy +* pool and doorbells. intel_guc owns a intel_guc_client to replace the legacy * ExecList submission. */ struct intel_guc {
@@ -62,8 +62,8 @@ struct intel_guc {struct i915_vma *shared_data;void *shared_data_vaddr; -struct i915_guc_client *execbuf_client; -struct i915_guc_client *preempt_client; +struct intel_guc_client *execbuf_client; +struct intel_guc_client *preempt_client;struct guc_preempt_work preempt_work[I915_NUM_ENGINES ];struct workqueue_struct *preempt_wq;
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
RFC 3/3 drm/i915/guc: Rename i915_guc_submission.c|h to intel_guc_submission.c|h
In reply to Sagar Arun KambleWith all component structures and functions named as intel_guc*, change the names of GuC submission source files.
--- drivers/gpu/drm/i915/Makefile | 4 +- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- drivers/gpu/drm/i915/i915_guc_submission.c | 1463 --------------------------- drivers/gpu/drm/i915/i915_guc_submission.h | 80 -- drivers/gpu/drm/i915/intel_guc.c | 2 +- drivers/gpu/drm/i915/intel_guc_submission.c | 1463 +++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_guc_submission.h | 80 ++ drivers/gpu/drm/i915/intel_uc.c | 2 +- 8 files changed, 1548 insertions(+), 1548 deletions(-) delete mode 100644 drivers/gpu/drm/i915/i915_guc_submission.c delete mode 100644 drivers/gpu/drm/i915/i915_guc_submission.h create mode 100644 drivers/gpu/drm/i915/intel_guc_submission.c create mode 100644 drivers/gpu/drm/i915/intel_guc_submission.h
drivers/gpu/drm/i915/Makefile +2 -2
@@ -83,10 +83,10 @@ i915-y += intel_uc.o \ intel_uc_fw.o \ intel_guc.o \ intel_guc_ct.o \ - intel_guc_log.o \ intel_guc_fw.o \ + intel_guc_log.o \ + intel_guc_submission.o \ intel_huc.o \ - i915_guc_submission.o # autogenerated null render state i915-y += intel_renderstate_gen6.o \
drivers/gpu/drm/i915/i915_debugfs.c +1 -1
@@ -30,7 +30,7 @@#include <linux/sort.h> #include <linux/sched/mm.h> #include "intel_drv.h" -#include "i915_guc_submission.h" +#include "intel_guc_submission.h" static inline struct drm_i915_private *node_to_i915 (struct drm_info_node *node) {
drivers/gpu/drm/i915/i915_guc_submission.c deleted +0 -1463
1,463 lines not on this page · raw message
drivers/gpu/drm/i915/i915_guc_submission.h deleted +0 -80
80 lines not on this page · raw message
drivers/gpu/drm/i915/intel_guc.c +1 -1
@@ -23,8 +23,8 @@*/ #include "intel_guc.h" +#include "intel_guc_submission.h" #include "i915_drv.h" -#include "i915_guc_submission.h" static void gen8_guc_raise_irq (struct intel_guc *guc) {
drivers/gpu/drm/i915/intel_guc_submission.c new file +1463 -0
1,428 lines not on this page · raw message
drivers/gpu/drm/i915/intel_guc_submission.h new file +80 -0
80 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Part of the diff is not shown here. View the raw message.
Quoting Sagar Arun Kamble (2017-11-10 09:59:44)
Quoted 10 lines
We want to have consistent function/structure/file naming and function parameter semantics. Suggestion from Michal Wajdeczko about using "
genx_" prefix (or better_genx" suffix for all hw related structures types, offsets), "i915_" prefix for driver entry calls and "intel_" in all other seems to be the good scheme to go ahead. Also we need to adhere to practise of passingdrm_i915_privateto functions with "i915_" prefix and component structure to functions with "intel_" prefix. This series updates GuC submission related code with these changes.
Quoted 6 lines
With GuC submission being hardware interface for i915, we should name those functions with prefix "
intel_guc" and pass structintel_gucas parameter. Alsoi915_guc_clientstruct is kernel-hw interaction structure hence rename that tointel_guc_client.
With these changes GuC submission source files are now named with "intel_" prefix.
Lgtm.
Having intel_guc_client be the HW facing struct, leaves i915_guc_client in case we ever need something to track uabi.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 18 lines · Chris Wilson
Quoting Sagar Arun Kamble (2017-11-10 09:59:44)
Quoted 10 lines
We want to have consistent function/structure/file naming and function parameter semantics. Suggestion from Michal Wajdeczko about using "
genx_" prefix (or better_genx" suffix for all hw related structures types, offsets), "i915_" prefix for driver entry calls and "intel_" in all other seems to be the good scheme to go ahead. Also we need to adhere to practise of passingdrm_i915_privateto functions with "i915_" prefix and component structure to functions with "intel_" prefix. This series updates GuC submission related code with these changes.Quoted 6 lines
With GuC submission being hardware interface for i915, we should name those functions with prefix "
intel_guc" and pass structintel_gucas parameter. Alsoi915_guc_clientstruct is kernel-hw interaction structure hence rename that tointel_guc_client.
With these changes GuC submission source files are now named with "intel_" prefix.
Quoted 4 lines
Lgtm.
Having
intel_guc_clientbe the HW facing struct, leavesi915_guc_clientin case we ever need something to track uabi.
Yep,
Please make sure that make htmldocs keeps working after the renames.
Under Documentation/gpu
i915.rst:.. kernel-doc:: drivers/gpu/drm/i915/intel_guc_loader.c i915.rst:.. kernel-doc:: drivers/gpu/drm/i915/intel_guc_loader.c i915.rst:.. kernel-doc:: drivers/gpu/drm/i915/i915_guc_submission.c i915.rst:.. kernel-doc:: drivers/gpu/drm/i915/i915_guc_submission.c i915.rst:.. kernel-doc:: drivers/gpu/drm/i915/intel_guc_fwif.h
With that fixed, the series is;
Regards, Joonas
Signature · 7 lines
Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: warning for GuC functions name/prototype update
In reply to Sagar Arun Kamble== Series Details ==
== Series Details ==
Series: GuC functions name/prototype update
URL : https://patchwork.freedesktop.org/series/33587/
State : warning
== Summary ==
Series 33587v1 GuC functions name/prototype update
https://patchwork.freedesktop.org/api/1.0/series/33587/revisions/1/mbox/
Test chamelium:
Subgroup dp-crc-fast:
pass -> FAIL (fi-kbl-7500u) fdo#102514
Test gem_exec_fence:
Subgroup basic-wait-default:
pass -> DMESG-WARN (fi-bsw-n3050)
Test gem_exec_reloc:
Subgroup basic-gtt-cpu-active:
fail -> PASS (fi-gdg-551) fdo#102582 +3
Subgroup basic-write-cpu-active:
fail -> PASS (fi-gdg-551) fdo#102582 +1fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fdo#102582 https://bugs.freedesktop.org/show_bug.cgi?id=102582
fdo#102582 https://bugs.freedesktop.org/show_bug.cgi?id=102582
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:440s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:453s fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:378s fi-bsw-n3050 total:289 pass:242 dwarn:1 dfail:0 fail:0 skip:46 time:548s fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:275s fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:506s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:507s fi-byt-j1900 total:289 pass:254 dwarn:0 dfail:0 fail:0 skip:35 time:498s fi-byt-n2820 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:489s fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:430s fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:266s fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:539s fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:428s fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:443s fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:425s fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:480s fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:463s fi-kbl-7500u total:289 pass:263 dwarn:1 dfail:0 fail:1 skip:24 time:472s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:525s fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:472s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:538s fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:568s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:449s fi-skl-6600u total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:545s fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:569s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:518s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:490s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:458s fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:559s fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:421s Blacklisted hosts: fi-cfl-s total:289 pass:254 dwarn:3 dfail:0 fail:0 skip:32 time:531s fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:554s fi-glk-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:491s
831ae3962a169aa94457f1c7742dd3591b394f70 drm-tip: 2017y-11m-09d-23h-29m-57s UTC integration manifest 2a39a05eb168 drm/i915/guc: Rename i915_guc_submission.c|h to intel_guc_submission.c|h b300c715a72b drm/i915/guc: Rename i915_guc_client struct to intel_guc_client c00084b7ebc5 drm/i915/guc: Update name and prototype of GuC submission related functions
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7052/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 10 lines · Sagar Arun Kamble
We want to have consistent function/structure/file naming and function parameter semantics. Suggestion from Michal Wajdeczko about using "
genx_" prefix (or better_genx" suffix for all hw related structures types, offsets), "i915_" prefix for driver entry calls and "intel_" in all other seems to be the good scheme to go ahead. Also we need to adhere to practise of passingdrm_i915_privateto functions with "i915_" prefix and component structure to functions with "intel_" prefix. This series updates GuC submission related code with these changes.
Quoted 7 lines
With GuC submission being hardware interface for i915, we should name those functions with prefix "
intel_guc" and pass structintel_gucas parameter. Alsoi915_guc_clientstruct is kernel-hw interaction structure hence rename that tointel_guc_client.
With these changes GuC submission source files are now named with "intel_" prefix.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx