memory hotplug: fix comments when add section
Subsystems (2)
PATCH 1/1 memory hotplug: fix comments when add section
Here, pfn_to_node should be page_to_nid.
Signed-off-by Fan Du <[email protected]>
--- mm/memory_hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/memory_hotplug.c +1 -1
@@ -265,7 +265,7 @@ static int __meminit __add_section(int nid, unsigned long phys_start_pfn,/* * Make all the pages reserved so that nobody will stumble over half * initialized state. -* FIXME: We also have to associate it with a node because pfn_to_node +* FIXME: We also have to associate it with a node because page_to_nid * relies on having page with the proper node. */ for (i =0 ; i <PAGES_PER_SECTION ; i++) {
Signature · 1 line
1.8.3.1
Quoted 3 lines · Fan Du
Here,
pfn_to_nodeshould bepage_to_nid.Signed-off-by Fan Du <[email protected]>
Yes, it is a typo. And the one worth fixing because this will make git grep great again
Acked-by Michal Hocko <[email protected]>
Quoted 19 lines
--- mm/memory_hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mm/memory_hotplug.c +1
-1@@ -265,7 +265,7 @@ static int __meminit __add_section(int nid, unsigned long phys_start_pfn,/* * Make all the pages reserved so that nobody will stumble over half * initialized state. -* FIXME: We also have to associate it with a node because pfn_to_node +* FIXME: We also have to associate it with a node because page_to_nid * relies on having page with the proper node. */ for (i =0 ; i <PAGES_PER_SECTION ; i++) {Signature · 1 line
1.8.3.1
Signature · 2 lines
Michal Hocko SUSE Labs