Patch "tun: allow positive return values on dev_get_valid_name() call" has been added to the 3.18-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
tun: allow positive return values on dev_get_valid_name() call
to the 3.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
tun-allow-positive-return-values-on-dev_get_valid_name-call.patch
and it can be found in the queue-3.18 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Thu Nov 16 15:48:06 CET 2017
From: Julien Gomes <[email protected]>
Date: Wed, 25 Oct 2017 11:50:50 -0700
Subject: tun: allow positive return values on dev_get_valid_name() call
From: Julien Gomes <[email protected]>
[ Upstream commit 5c25f65fd1e42685f7ccd80e0621829c105785d9 ]
If the name argument of dev_get_valid_name() contains "%d", it will try to assign it a unit number in __dev__alloc_name() and return either the unit number (>= 0) or an error code (< 0).
Considering positive values as error values prevent tun device creations relying this mechanism, therefor we should only consider negative values as errors here.
--- drivers/net/tun.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/tun.c +1 -1
@@ -1657,7 +1657,7 @@ static int tun_set_iff(struct net *net,if (!dev)return -ENOMEM ; err =dev_get_valid_name (net, dev, name); -if (err) +if (err <0 ) goto err_free_dev;dev_net_set (dev, net);
Patches currently in stable-queue which might be from [email protected] are
queue-3.18/tun-allow-positive-return-values-on-dev_get_valid_name-call.patch