Patch "ACPI / APEI: Remove arch_apei_flush_tlb_one()" has been added to the 4.4-stable tree

PATCH [email protected] 2 participants 4 messages Nov 25, 2017 – Nov 27, 2017

Subsystems (4)

Stable branch x86 ACPI ACPI component architecture (acpica)

lore

Share & tools

lore

[email protected]

author maintainer Applied

2017-11-25 13:54 UTC #0 lore raw

This is a note to let you know that I've just added the patch titled

ACPI / APEI: Remove arch_apei_flush_tlb_one()

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
acpi-apei-remove-arch_apei_flush_tlb_one.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 4a75aeacda3c2455954596593d89187df5420d0a Mon Sep 17 00:00:00 2001

From: James Morse <[email protected]>
Date: Mon, 6 Nov 2017 18:44:27 +0000
Subject: ACPI / APEI: Remove arch_apei_flush_tlb_one()

From: James Morse <[email protected]>

commit 4a75aeacda3c2455954596593d89187df5420d0a upstream.

Nothing calls arch_apei_flush_tlb_one() anymore, instead relying on __set_pte_vaddr() to do the invalidation when called from clear_fixmap() Remove arch_apei_flush_tlb_one().

Signed-off-by James Morse <[email protected]>

Reviewed-by Borislav Petkov <[email protected]>

Signed-off-by Rafael J. Wysocki <[email protected]>

Signed-off-by Greg Kroah-Hartman <[email protected]>

---
 arch/x86/kernel/acpi/apei.c |    5 -----
 include/acpi/apei.h         |    1 -
 2 files changed, 6 deletions(-)

arch/x86/kernel/acpi/apei.c +0 -5

@@ -55,8 +55,3 @@ void arch_apei_report_mem_error(int sev,
 	apei_mce_report_mem_error(sev, mem_err);
 #endif
 }
-
-void arch_apei_flush_tlb_one(unsigned long addr)
-{
-	__flush_tlb_one(addr);
-}

include/acpi/apei.h +0 -1

@@ -44,7 +44,6 @@ int erst_clear(u64 record_id);
 
 int arch_apei_enable_cmcff(struct acpi_hest_header *hest_hdr, void *data);
 void arch_apei_report_mem_error(int sev, struct cper_sec_mem_err *mem_err);
-void arch_apei_flush_tlb_one(unsigned long addr);
 
 #endif
 #endif

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/acpi-apei-remove-arch_apei_flush_tlb_one.patch

Greg KH

author maintainer

2017-11-25 18:06 UTC #1 lore raw

Quoted 8 lines · On Sat, Nov 25, 2017 at 02:54:08PM +0100, [email protected] wrote:

This is a note to let you know that I've just added the patch titled
ACPI / APEI: Remove arch_apei_flush_tlb_one()
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 7 lines

The filename of the patch is:
acpi-apei-remove-arch_apei_flush_tlb_one.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Dropped from all stable queues now. Why was this even a stable patch at all anyway? It doesn't fix anything...

greg k-h

James Morse

2017-11-27 10:11 UTC #2 lore raw

Hi Greg,

Quoted 13 lines · Greg KH

Quoted 12 lines · On Sat, Nov 25, 2017 at 02:54:08PM +0100, [email protected] wrote:
This is a note to let you know that I've just added the patch titled
ACPI / APEI: Remove arch_apei_flush_tlb_one()
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
acpi-apei-remove-arch_apei_flush_tlb_one.patch
and it can be found in the queue-4.4 subdirectory.

Quoted 6 lines

Quoted 3 lines
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Dropped from all stable queues now. Why was this even a stable patch at all anyway? It doesn't fix anything...

It looks like this series picked up a 'Cc: All applicable <[email protected]>' along the way. (Rafael?)

The first patch fixed the problem, the rest were clean-up, code we no longer needed and hooks that had no more users in v4.14.

I can provide backports back to v4.13, which is when arm64 got APEI support, but before then I have nothing to test it on...

Can I suggest dropping this series from the stable trees? (do you need me to reply to each email?)

Thanks,

James

Greg KH

author maintainer

2017-11-27 11:41 UTC #3 lore raw

Quoted 29 lines · James Morse

Hi Greg,
Quoted 13 lines · Greg KH
Quoted 12 lines · On Sat, Nov 25, 2017 at 02:54:08PM +0100, [email protected] wrote:
This is a note to let you know that I've just added the patch titled
ACPI / APEI: Remove arch_apei_flush_tlb_one()
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
acpi-apei-remove-arch_apei_flush_tlb_one.patch
and it can be found in the queue-4.4 subdirectory.
Quoted 6 lines
Quoted 3 lines
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Dropped from all stable queues now. Why was this even a stable patch at all anyway? It doesn't fix anything...
It looks like this series picked up a 'Cc: All applicable <[email protected]>' along the way. (Rafael?)
The first patch fixed the problem, the rest were clean-up, code we no longer needed and hooks that had no more users in v4.14.

Quoted 6 lines

I can provide backports back to v4.13, which is when arm64 got APEI support, but before then I have nothing to test it on...
Can I suggest dropping this series from the stable trees? (do you need me to reply to each email?)

As I don't see "patch series" in stable submissions given that it's just a bunch of patches out of order, yes, please respond to any patch that I have applied that you do not want to see applied.

thanks,

greg k-h