Patch "irqchip/gic-v3: Fix ppi-partitions lookup" has been added to the 4.9-stable tree
This is a note to let you know that I've just added the patch titled
irqchip/gic-v3: Fix ppi-partitions lookup
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
irqchip-gic-v3-fix-ppi-partitions-lookup.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
00ee9a1ca5080202bc37b44e998c3b2c74d45817Mon Sep 17 00:00:00 2001
From: Johan Hovold <[email protected]>
Date: Sat, 11 Nov 2017 17:51:25 +0100
Subject: irqchip/gic-v3: Fix ppi-partitions lookup
From: Johan Hovold <[email protected]>
commit 00ee9a1ca5080202bc37b44e998c3b2c74d45817 upstream.
Fix child-node lookup during initialisation, which ended up searching the whole device tree depth-first starting at the parent rather than just matching on its children.
To make things worse, the parent gic node was prematurely freed, while the ppi-partitions node was leaked.
--- drivers/irqchip/irq-gic-v3.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/irqchip/irq-gic-v3.c +6 -3
@@ -1022,18 +1022,18 @@ static void __init gic_populate_ppi_partint nr_parts;struct partition_affinity *parts; - parts_node =of_find_node_by_name (gic_node,"ppi-partitions" ); + parts_node =of_get_child_by_name (gic_node,"ppi-partitions" );if (!parts_node)return ; nr_parts =of_get_child_count (parts_node);if (!nr_parts) -return ; + goto out_put_node; parts =kzalloc (sizeof (*parts) * nr_parts,GFP_KERNEL );if (WARN_ON (!parts)) -return ; + goto out_put_node;for_each_child_of_node (parts_node, child_part) {struct partition_affinity *part;
@@ -1100,6 +1100,9 @@ static void __init gic_populate_ppi_part gic_data.ppi_descs[i] = desc; } + +out_put_node: +of_node_put (parts_node); }static void __init gic_of_setup_kvm_info (struct device_node *node)
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/irqchip-gic-v3-fix-ppi-partitions-lookup.patch