Skip to contentSkip to conversation

dma: MIC X100: Use PTR_ERR_OR_ZERO()

PATCH In review Vasyl Gomonovych 2 participants 2 messages Nov 27, 2017 – Dec 4, 2017 dmaengine

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dma: MIC X100: Use PTR_ERR_OR_ZERO()

Fix ptr_ret.cocci warnings:
drivers/dma/mic_x100_dma.c:483:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

---
 drivers/dma/mic_x100_dma.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/dma/mic_x100_dma.c +1 -3
index 5ba5714d0b7c..94d7bd7d2880 100644
@@ -480,9 +480,7 @@ static int mic_dma_setup_irq(struct mic_dma_chan *ch)
 		to_mbus_hw_ops(ch)->request_threaded_irq(to_mbus_device(ch),
 			mic_dma_intr_handler, mic_dma_thread_fn,
 			"mic dma_channel", ch, ch->ch_num);
-	if (IS_ERR(ch->cookie))
-		return PTR_ERR(ch->cookie);
-	return 0;
+	return PTR_ERR_OR_ZERO(ch->cookie);
 }
 
 static inline void mic_dma_free_irq(struct mic_dma_chan *ch)
Signature · 1 line
1.9.1
#1 lore raw
Quoted 6 lines · Vasyl Gomonovych

Fix ptr_ret.cocci warnings:
drivers/dma/mic_x100_dma.c:483:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Applied after fixing subystem name and driver tag

Signature · 1 line
~Vinod