Patch "[media] cec: when canceling a message, don't overwrite old status info" has been added to the 4.9-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
[media] cec: when canceling a message, don't overwrite old status info
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
cec-when-canceling-a-message-don-t-overwrite-old-status-info.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Tue Nov 28 10:49:28 CET 2017
From: Hans Verkuil <[email protected]>
Date: Fri, 9 Dec 2016 11:14:32 -0200
Subject: [media] cec: when canceling a message, don't overwrite old status info
From: Hans Verkuil <[email protected]>
[ Upstream commit 120476123646ba3619c90db7bcbc6f8eea53c990 ]
When a pending message was canceled (e.g. due to a timeout), then the old tx_status info was overwritten instead of ORed. The same happened with the tx_error_cnt field. So just modify them instead of overwriting them.
--- drivers/staging/media/cec/cec-adap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/media/cec/cec-adap.c +3 -3
@@ -288,10 +288,10 @@ static void cec_data_cancel(struct cec_d/* Mark it as an error */ data->msg.tx_ts =ktime_get_ns (); - data->msg.tx_status =CEC_TX_STATUS_ERROR | -CEC_TX_STATUS_MAX_RETRIES ; + data->msg.tx_status |=CEC_TX_STATUS_ERROR | +CEC_TX_STATUS_MAX_RETRIES ; + data->msg.tx_error_cnt++; data->attempts =0 ; - data->msg.tx_error_cnt =1 ;/* Queue transmitted message for monitoring purposes */ cec_queue_msg_monitor (data->adap, &data->msg,1 );
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/cec-cec_msg_give_features-should-abort-for-cec-version-2.patch queue-4.9/cec-update-log_addr-before-finishing-configuration.patch queue-4.9/cec-when-canceling-a-message-don-t-overwrite-old-status-info.patch