Skip to contentSkip to conversation

irq: Guard handle_bad_irq log messages

PATCH New Guenter Roeck 2 participants 2 messages Dec 2, 2017 – Dec 28, 2017 IRQ

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 irq: Guard handle_bad_irq log messages

An interrupt storm on a bad interrupt will cause the kernel log to be clogged.

[   60.089234] ->handle_irq():  ffffffffbe2f803f,
[   60.090455] 0xffffffffbf2af380
[   60.090510] handle_bad_irq+0x0/0x2e5
[   60.090522] ->irq_data.chip(): ffffffffbf2af380,
[   60.090553]    IRQ_NOPROBE set
[   60.090584] ->handle_irq():  ffffffffbe2f803f,
[   60.090590] handle_bad_irq+0x0/0x2e5
[   60.090596] ->irq_data.chip(): ffffffffbf2af380,
[   60.090602] 0xffffffffbf2af380
[   60.090608] ->action():           (null)
[   60.090779] handle_bad_irq+0x0/0x2e5

This was seen when running an upstream kernel on Acer Chromebook R11. The system was unstable as result.

Guard the log message with __printk_ratelimit to reduce the impact. This won't prevent the interrupt storm from happening, but at least the system remains stable.

---
v2: Move rate limiting into print_irq_desc()

 kernel/irq/debug.h | 5 +++++
 1 file changed, 5 insertions(+)
kernel/irq/debug.h +5 -0
index 17f05ef8f575..e4d3819a91cc 100644
@@ -12,6 +12,11 @@
 
 static inline void print_irq_desc(unsigned int irq, struct irq_desc *desc)
 {
+	static DEFINE_RATELIMIT_STATE(ratelimit, 5 * HZ, 5);
+
+	if (!__ratelimit(&ratelimit))
+		return;
+
 	printk("irq %d, desc: %p, depth: %d, count: %d, unhandled: %d\n",
 		irq, desc, desc->depth, desc->irq_count, desc->irqs_unhandled);
 	printk("->handle_irq():  %p, ", desc->handle_irq);
Signature · 1 line
2.7.4
#1 lore raw

[tip:irq/urgent] genirq: Guard handle_bad_irq log messages

genirq: Guard handle_bad_irq log messages
Commit-ID:  11bca0a83f83f6093d816295668e74ef24595944
Gitweb:     https://git.kernel.org/tip/11bca0a83f83f6093d816295668e74ef24595944
Author:     Guenter Roeck <[email protected]>
AuthorDate: Sat, 2 Dec 2017 09:13:04 -0800
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Thu, 28 Dec 2017 12:28:29 +0100

genirq: Guard handle_bad_irq log messages

An interrupt storm on a bad interrupt will cause the kernel log to be clogged.

[   60.089234] ->handle_irq():  ffffffffbe2f803f,
[   60.090455] 0xffffffffbf2af380
[   60.090510] handle_bad_irq+0x0/0x2e5
[   60.090522] ->irq_data.chip(): ffffffffbf2af380,
[   60.090553]    IRQ_NOPROBE set
[   60.090584] ->handle_irq():  ffffffffbe2f803f,
[   60.090590] handle_bad_irq+0x0/0x2e5
[   60.090596] ->irq_data.chip(): ffffffffbf2af380,
[   60.090602] 0xffffffffbf2af380
[   60.090608] ->action():           (null)
[   60.090779] handle_bad_irq+0x0/0x2e5

This was seen when running an upstream kernel on Acer Chromebook R11. The system was unstable as result.

Guard the log message with __printk_ratelimit to reduce the impact. This won't prevent the interrupt storm from happening, but at least the system remains stable.

---
 kernel/irq/debug.h | 5 +++++
 1 file changed, 5 insertions(+)
kernel/irq/debug.h +5 -0
index 17f05ef..e4d3819 100644
@@ -12,6 +12,11 @@
 
 static inline void print_irq_desc(unsigned int irq, struct irq_desc *desc)
 {
+	static DEFINE_RATELIMIT_STATE(ratelimit, 5 * HZ, 5);
+
+	if (!__ratelimit(&ratelimit))
+		return;
+
 	printk("irq %d, desc: %p, depth: %d, count: %d, unhandled: %d\n",
 		irq, desc, desc->depth, desc->irq_count, desc->irqs_unhandled);
 	printk("->handle_irq():  %p, ", desc->handle_irq);