FAILED: patch "[PATCH] drm/amd/powerplay: wrong control mode cause the fan spins" failed to apply to 4.14-stable tree
Subsystems (3)
[email protected]
maintainerThe patch below does not apply to the 4.14-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
Quoted 1 line
From
710931c2be5a784c0651111f54bd083e3681c309Mon Sep 17 00:00:00 2001
From: Evan Quan <[email protected]>
Date: Wed, 1 Nov 2017 16:52:08 +0800
Subject: [PATCH] drm/amd/powerplay: wrong control mode cause the fan spins
faster unnecessarily
The fan control mode can either be FDO_PWM_MODE_STATIC or FDO_PWM_MODE_STATIC_RPM. Setting it as AMD_FAN_CTRL_AUTO will cause the fan spin faster wrongly.
This can be reproduced by:
'# cat /sys/class/hwmon/hwmon0/pwm1
38
'# cat /sys/class/hwmon/hwmon0/pwm1_enable
2
'# echo "2" > /sys/class/hwmon/hwmon0/pwm1_enable
'# cat /sys/class/hwmon/hwmon0/pwm1
122
The fan speed get faster wrongly even with its original mode echo back.
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +1 -1
@@ -4234,7 +4234,7 @@ static void vega10_set_fan_control_mode(struct pp_hwmgr *hwmgr, uint32_t mode)vega10_fan_ctrl_stop_smc_fan_control (hwmgr);break ;case AMD_FAN_CTRL_AUTO : -if (!vega10_fan_ctrl_set_static_mode (hwmgr, mode)) +if (PP_CAP (PHM_PlatformCaps_MicrocodeFanControl))vega10_fan_ctrl_start_smc_fan_control (hwmgr);break ;default :