Skip to contentSkip to conversation

lib/igt_gt: Add sentinel to intel_execution_engines2

PATCH In review Petri Latvala 3 participants 4 messages Dec 5, 2017 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/igt_gt: Add sentinel to intel_execution_engines2

The for_each_engine_class_instance macro stops at e__->name being NULL, so add an object that is so.

Cc Tvrtko Ursulin <[email protected]>
Cc Chris Wilson <[email protected]>
---
 lib/igt_gt.c | 1 +
 1 file changed, 1 insertion(+)
lib/igt_gt.c +1 -0
index 4a8f541f..ad6e6205 100644
@@ -615,6 +615,7 @@ const struct intel_execution_engine2 intel_execution_engines2[] = {
 	{ "vcs0", I915_ENGINE_CLASS_VIDEO, 0 },
 	{ "vcs1", I915_ENGINE_CLASS_VIDEO, 1 },
 	{ "vecs0", I915_ENGINE_CLASS_VIDEO_ENHANCE, 0 },
+	{ }
 };
 
 unsigned int
Signature · 6 lines
2.14.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 1/1
#1 lore raw
Quoted 16 lines · Petri Latvala

The for_each_engine_class_instance macro stops at e__->name being NULL, so add an object that is so.

Cc Tvrtko Ursulin <[email protected]>
Cc Chris Wilson <[email protected]>
---
  lib/igt_gt.c | 1 +
  1 file changed, 1 insertion(+)
lib/igt_gt.c +0 -0
index 4a8f541f..ad6e6205 100644

lib/igt_gt.c const struct intel_execution_engine2 intel_execution_engines2[] = { · line 621

Quoted 7 lines
lib/igt_gt.c +1 -0
@@ -615,6 +615,7 @@ const struct intel_execution_engine2 intel_execution_engines2[] = {
  	{ "vcs0", I915_ENGINE_CLASS_VIDEO, 0 },
  	{ "vcs1", I915_ENGINE_CLASS_VIDEO, 1 },
  	{ "vecs0", I915_ENGINE_CLASS_VIDEO_ENHANCE, 0 },
+	{ }
  };
 
  unsigned int

Oh dear, well spotted.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

✓ Fi.CI.BAT: success for series starting with [1/1] lib/igt_gt: Add sentinel to intel_execution_engines2

In reply to Petri Latvala
== Series Details ==

== Series Details ==

Series: series starting with [1/1] lib/igt_gt: Add sentinel to intel_execution_engines2
URL : https://patchwork.freedesktop.org/series/34892/
State : success

== Summary ==

IGT patchset tested on top of latest successful build ece35d37e6b0afc0ba99f66179279960042c87bc tests/gem_seqno_wrap: Drop gem_seqno_wrap.c

with latest DRM-Tip kernel build CI_DRM_3456
84cd3d972bdd drm-tip: 2017y-12m-05d-08h-41m-59s UTC integration manifest

No testlist changes.

Test debugfs_test:

        Subgroup read_all_entries:
                dmesg-warn -> DMESG-FAIL (fi-elk-e7500) fdo#103989
Test gem_mmap_gtt:
        Subgroup basic-small-bo-tiledx:
                fail       -> PASS       (fi-gdg-551) fdo#102575
Test kms_chamelium:
        Subgroup dp-crc-fast:
                dmesg-fail -> PASS       (fi-kbl-7500u) fdo#103841

fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:440s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:443s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:386s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:518s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:282s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:507s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:514s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:492s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:475s
fi-elk-e7500     total:224  pass:163  dwarn:14  dfail:1   fail:0   skip:45 
fi-gdg-551       total:288  pass:179  dwarn:1   dfail:0   fail:0   skip:108 time:272s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:543s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:375s
fi-hsw-4770r     total:288  pass:224  dwarn:0   dfail:0   fail:0   skip:64  time:261s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:398s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:487s
fi-ivb-3770      total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:453s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:485s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:528s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:474s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:531s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:591s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:459s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:544s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:571s
fi-skl-6700k     total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:524s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:502s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:450s
fi-snb-2520m     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:557s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:426s
Blacklisted hosts:
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:611s
fi-cnl-y         total:235  pass:210  dwarn:0   dfail:0   fail:0   skip:24 
fi-glk-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:489s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_597/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

✗ Fi.CI.IGT: failure for series starting with [1/1] lib/igt_gt: Add sentinel to intel_execution_engines2

In reply to Petri Latvala
== Series Details ==

== Series Details ==

Series: series starting with [1/1] lib/igt_gt: Add sentinel to intel_execution_engines2
URL : https://patchwork.freedesktop.org/series/34892/
State : failure

== Summary ==

Test drv_module_reload:

        Subgroup basic-no-display:
                pass       -> DMESG-WARN (shard-hsw) fdo#102707 +1
Test gem_tiled_swapping:
        Subgroup non-threaded:
                incomplete -> PASS       (shard-hsw) fdo#104009
Test kms_flip:
        Subgroup flip-vs-modeset-vs-hang:
                pass       -> INCOMPLETE (shard-snb)

fdo#102707 https://bugs.freedesktop.org/show_bug.cgi?id=102707
fdo#104009 https://bugs.freedesktop.org/show_bug.cgi?id=104009

shard-hsw        total:2679 pass:1535 dwarn:2   dfail:0   fail:10  skip:1132 time:9431s
shard-snb        total:2652 pass:1298 dwarn:2   dfail:0   fail:12  skip:1339 time:7871s
Blacklisted hosts:
shard-apl        total:2679 pass:1680 dwarn:1   dfail:0   fail:21  skip:977 time:13648s
shard-kbl        total:2679 pass:1789 dwarn:9   dfail:0   fail:24  skip:857 time:10807s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_597/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx