Patch "tipc: fix cleanup at module unload" has been added to the 4.4-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
tipc: fix cleanup at module unload
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
tipc-fix-cleanup-at-module-unload.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Wed Dec 6 16:43:17 CET 2017
From: Parthasarathy Bhuvaragan <[email protected]>
Date: Tue, 24 Jan 2017 13:00:48 +0100
Subject: tipc: fix cleanup at module unload
From: Parthasarathy Bhuvaragan <[email protected]>
[ Upstream commit 35e22e49a5d6a741ebe7f2dd280b2052c3003ef7 ]
In tipc_server_stop(), we iterate over the connections with limiting factor as server's idr_in_use. We ignore the fact that this variable is decremented in tipc_close_conn(), leading to premature exit.
In this commit, we iterate until the we have no connections left.
--- net/tipc/server.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
net/tipc/server.c +1 -3
@@ -618,14 +618,12 @@ int tipc_server_start(struct tipc_servervoid tipc_server_stop (struct tipc_server *s) {struct tipc_conn *con; -int total =0 ;int id;spin_lock_bh (&s->idr_lock); -for (id =0 ; total < s->idr_in_use; id++) { +for (id =0 ; s->idr_in_use; id++) { con =idr_find (&s->conn_idr, id);if (con) { - total++;spin_unlock_bh (&s->idr_lock);tipc_close_conn (con);spin_lock_bh (&s->idr_lock);
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/tipc-fix-cleanup-at-module-unload.patch