Skip to contentSkip to conversation

ARM: dts: Add S2600WF BMC Machine

PATCH Superseded James Feist 2 participants 2 messages Dec 8, 2017 – Dec 11, 2017

Subsystems (3)
Device tree bindings Arm/Aspeed machine support Arm and arm64 SoC sub-architectures (common parts)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

James Feist

author
#0 lore raw

PATCH v4 1/1 ARM: dts: Add S2600WF BMC Machine

S2600WF is a Intel platform family with an Aspeed ast2500 BMC.

Signed-off-by James Feist <[email protected]>

---
changes since v3:
- use full product family name

 arch/arm/boot/dts/Makefile                     |   1 +
 arch/arm/boot/dts/aspeed-bmc-intel-s2600wf.dts | 128 +++++++++++++++++++++++++
 2 files changed, 129 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed-bmc-intel-s2600wf.dts
arch/arm/boot/dts/Makefile +1 -0
index 6d6c9eb..7c54fc8 100644
@@ -992,6 +992,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += aspeed-bmc-opp-palmetto.dtb \
 	aspeed-bmc-opp-lanyang.dtb \
 	aspeed-bmc-mellanox-msn.dtb \
 	aspeed-bmc-quanta-q71l.dtb \
+	aspeed-bmc-intel-s2600wf.dtb \
 	aspeed-ast2500-evb.dtb
 endif
arch/arm/boot/dts/aspeed-bmc-intel-s2600wf.dts new file +128 -0

128 lines not on this page · raw message

Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 1 line · James Feist

S2600WF is a Intel platform family with an Aspeed ast2500 BMC.

Thanks! I can search for that term and see what it is; that's much clearer.

I've been doing a bunch of work upstreaming device trees, and after taking a closer look I've seen some other nits in your patch. Please fix them up and we can get this merged.

arch/arm/boot/dts/aspeed-bmc-intel-s2600wf.dts

Quoted 29 lines
Signed-off-by James Feist <[email protected]>

---
changes since v3:
- use full product family name

 arch/arm/boot/dts/Makefile                     |   1 +
 arch/arm/boot/dts/aspeed-bmc-intel-s2600wf.dts | 128 +++++++++++++++++++++++++
 2 files changed, 129 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed-bmc-intel-s2600wf.dts
arch/arm/boot/dts/Makefile +1 -0
index 6d6c9eb..7c54fc8 100644
@@ -992,6 +992,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += aspeed-bmc-opp-palmetto.dtb \
        aspeed-bmc-opp-lanyang.dtb \
        aspeed-bmc-mellanox-msn.dtb \
        aspeed-bmc-quanta-q71l.dtb \
+       aspeed-bmc-intel-s2600wf.dtb \
        aspeed-ast2500-evb.dtb
 endif
arch/arm/boot/dts/aspeed-bmc-intel-s2600wf.dts new file +0 -0
new file mode 100644
index 0000000..ef0ba3c
@@ -0,0 +1,128 @@

Add a copyright header. The new way of doing this in kernel land is with the SPDX tag on the first line of your source file:

// SPDX-License-Identifier: GPL-2.0+

arch/arm/boot/dts/aspeed-bmc-intel-s2600wf.dts line 11

Quoted 11 lines
arch/arm/boot/dts/aspeed-bmc-intel-s2600wf.dts new file +11 -0
+/dts-v1/;
+
+#include "aspeed-g5.dtsi"
+
+/ {
+       model = "S2600WF BMC";
+       compatible = "intel,s2600wf-bmc", "aspeed,ast2500";
+
+       aliases {
+               serial4 = &uart5;
+       };

Drop this; all of the aliases are in aspeed-g5.dtsi.

Quoted 25 lines
arch/arm/boot/dts/aspeed-bmc-intel-s2600wf.dts new file +25 -0
+
+       chosen {
+               stdout-path = &uart5;
+               bootargs = "earlyprintk";
+       };
+
+       memory {
+               reg = <0x80000000 0x20000000>;
+       };
+
+       reserved-memory {
+               #address-cells = <1>;
+               #size-cells = <1>;
+               ranges;
+
+               vga_memory: framebuffer@7f000000 {
+                       no-map;
+                       reg = <0x7f000000 0x01000000>;
+               };
+       };
+
+       iio-hwmon {
+               compatible = "iio-hwmon";
+               io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>,
+                       <&adc 4>, <&adc 5>, <&adc 6>, <&adc 7>,

arch/arm/boot/dts/aspeed-bmc-intel-s2600wf.dts line 46

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-intel-s2600wf.dts new file +10 -0
+                       <&adc 8>, <&adc 9>, <&adc 10>, <&adc 11>,
+                       <&adc 12>, <&adc 13>, <&adc 14>, <&adc 15>;
+       };
+
+};
+
+&fmc {
+       status = "okay";
+       flash@0 {
+               status = "okay";

Most of the flash chips we are using support the fast-read property. Have you tried this with your system(s)?

m25p,fast-read

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts#n39

arch/arm/boot/dts/aspeed-bmc-intel-s2600wf.dts line 58

Quoted 12 lines
arch/arm/boot/dts/aspeed-bmc-intel-s2600wf.dts new file +12 -0
+#include "openbmc-flash-layout.dtsi"
+       };
+};
+
+&spi1 {
+       status = "okay";
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_spi1_default>;
+
+       flash@0 {
+               status = "okay";
+               label = "pnor";

Same here.

Quoted 3 lines
arch/arm/boot/dts/aspeed-bmc-intel-s2600wf.dts new file +3 -0
+       };
+};
+