WTF: patch "[PATCH] fw_cfg: fix driver remove" was seriously submitted to be applied to the 4.14-stable tree?
Subsystems (2)
[email protected]
maintainerThe patch below was submitted to be applied to the 4.14-stable tree.
I fail to see how this patch meets the stable kernel rules as found at Documentation/process/stable-kernel-rules.rst.
I could be totally wrong, and if so, please respond to <[email protected]> and let me know why this patch should be applied. Otherwise, it is now dropped from my patch queues, never to be seen again.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
Quoted 1 line
From
23f1b8d938c861ee0bbb786162f7ce0685f722ecMon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= <[email protected]>
Date: Mon, 20 Nov 2017 10:55:15 +0100
Subject: [PATCH] fw_cfg: fix driver remove
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
On driver remove(), all objects created during probe() should be removed, but sysfs qemu_fw_cfg/rev file was left. Also reorder functions to match probe() error cleanup code.
drivers/firmware/qemu_fw_cfg.c +2 -1
@@ -582,9 +582,10 @@ static int fw_cfg_sysfs_remove(struct platform_device *pdev) {pr_debug ("fw_cfg: unloading.\n" );fw_cfg_sysfs_cache_cleanup (); +sysfs_remove_file (fw_cfg_top_ko, &fw_cfg_rev_attr.attr); +fw_cfg_io_cleanup ();fw_cfg_kset_unregister_recursive (fw_cfg_fname_kset);fw_cfg_kobj_cleanup (fw_cfg_sel_ko); -fw_cfg_io_cleanup ();return 0 ; }