Patch "scsi: qla2xxx: Fix ql_dump_buffer" has been added to the 4.9-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
scsi: qla2xxx: Fix ql_dump_buffer
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
scsi-qla2xxx-fix-ql_dump_buffer.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Tue Dec 12 13:26:17 CET 2017
From: Joe Perches <[email protected]>
Date: Thu, 2 Mar 2017 17:14:47 -0800
Subject: scsi: qla2xxx: Fix ql_dump_buffer
From: Joe Perches <[email protected]>
[ Upstream commit 23456565acf6d452e0368f7380aecd584c019c67 ]
Recent printk changes for KERN_CONT cause this logging to be defectively emitted on multiple lines. Fix it.
Also reduces object size a trivial amount.
$ size drivers/scsi/qla2xxx/qla_dbg.o* text data bss dec hex filename 39125 0 0 39125 98d5 drivers/scsi/qla2xxx/qla_dbg.o.new 39164 0 0 39164 98fc drivers/scsi/qla2xxx/qla_dbg.o.old
--- drivers/scsi/qla2xxx/qla_dbg.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
drivers/scsi/qla2xxx/qla_dbg.c +4 -8
@@ -2707,13 +2707,9 @@ ql_dump_buffer(uint32_t level, scsi_qla_ "%-+5d 0 1 2 3 4 5 6 7 8 9 A B C D E F\n", size);ql_dbg (level, vha, id,"----- -----------------------------------------------\n" ); -for (cnt =0 ; cnt < size; cnt++, buf++) { -if (cnt %16 ==0 ) -ql_dbg (level, vha, id,"%04x:" , cnt & ~0xFU ); -printk (" %02x" , *buf); -if (cnt %16 ==15 ) -printk ("\n" ); +for (cnt =0 ; cnt < size; cnt +=16 ) { +ql_dbg (level, vha, id,"%04x: " , cnt); +print_hex_dump (KERN_CONT ,"" ,DUMP_PREFIX_NONE ,16 ,1 , + buf + cnt,min (16U , size - cnt), false); } -if (cnt %16 !=0 ) -printk ("\n" ); }
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/scsi-qla2xxx-fix-ql_dump_buffer.patch