Patch "irqchip/crossbar: Fix incorrect type of register size" has been added to the 3.18-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
irqchip/crossbar: Fix incorrect type of register size
to the 3.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
irqchip-crossbar-fix-incorrect-type-of-register-size.patch
and it can be found in the queue-3.18 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Thu Dec 14 21:30:47 CET 2017
From: Franck Demathieu <[email protected]>
Date: Mon, 6 Mar 2017 14:41:06 +0100
Subject: irqchip/crossbar: Fix incorrect type of register size
From: Franck Demathieu <[email protected]>
[ Upstream commit 4b9de5da7e120c7f02395da729f0ec77ce7a6044 ]
The 'size' variable is unsigned according to the dt-bindings. As this variable is used as integer in other places, create a new variable that allows to fix the following sparse issue (-Wtypesign):
drivers/irqchip/irq-crossbar.c:279:52: warning: incorrect type in argument 3 (different signedness)
drivers/irqchip/irq-crossbar.c:279:52: expected unsigned int [usertype] *out_value
drivers/irqchip/irq-crossbar.c:279:52: got int *<noident>
--- drivers/irqchip/irq-crossbar.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/irqchip/irq-crossbar.c +4 -4
@@ -176,7 +176,7 @@ static const struct irq_domain_ops routastatic int __init crossbar_of_init (struct device_node *node) {int i, size, reserved =0 ; -u32 max =0 , entry; +u32 max =0 , entry, reg_size;const __be32 *irqsr;int ret = -ENOMEM ;
@@ -253,9 +253,9 @@ static int __init crossbar_of_init(strucif (!cb->register_offsets) goto err_irq_map; -of_property_read_u32 (node,"ti,reg-size" , &size); +of_property_read_u32 (node,"ti,reg-size" , ®_size); -switch (size) { +switch (reg_size) {case 1 : cb->write = crossbar_writeb;break ;
@@ -281,7 +281,7 @@ static int __init crossbar_of_init(struccontinue ; cb->register_offsets[i] = reserved; - reserved += size; + reserved += reg_size; }of_property_read_u32 (node,"ti,irqs-safe-map" , &cb->safe_map);
Patches currently in stable-queue which might be from [email protected] are
queue-3.18/irqchip-crossbar-fix-incorrect-type-of-register-size.patch