Patch "ide: ide-atapi: fix compile error with defining macro DEBUG" has been added to the 4.14-stable tree
This is a note to let you know that I've just added the patch titled
ide: ide-atapi: fix compile error with defining macro DEBUG
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ide-ide-atapi-fix-compile-error-with-defining-macro-debug.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Tue Dec 12 10:32:42 CET 2017
From: Hongxu Jia <[email protected]>
Date: Fri, 10 Nov 2017 15:59:17 +0800
Subject: ide: ide-atapi: fix compile error with defining macro DEBUG
From: Hongxu Jia <[email protected]>
[ Upstream commit 8dc7a31fbce5e2dbbacd83d910da37105181b054 ]
Compile ide-atapi failed with defining macro "DEBUG"
...
|drivers/ide/ide-atapi.c:285:52: error: 'struct request' has no member named 'cmd'; did you mean 'csd'?
| debug_log("%s: rq->cmd[0]: 0x%x\n", __func__, rq->cmd[0]);
...
Since we split the scsi_request out of struct request, it missed do the same thing on debug_log
--- drivers/ide/ide-atapi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/ide/ide-atapi.c +3 -3
@@ -282,7 +282,7 @@ int ide_cd_expiry(ide_drive_t *drive)struct request *rq = drive->hwif->rq;unsigned long wait =0 ; -debug_log ("%s: rq->cmd[0]: 0x%x\n" , __func__, rq->cmd[0 ]); +debug_log ("%s: scsi_req(rq)->cmd[0]: 0x%x\n" , __func__,scsi_req (rq)->cmd[0 ]);/* * Some commands are *slow* and normally take a long time to complete.
@@ -463,7 +463,7 @@ static ide_startstop_t ide_pc_intr(ide_dreturn ide_do_reset (drive); } -debug_log ("[cmd %x]: check condition\n" , rq->cmd[0 ]); +debug_log ("[cmd %x]: check condition\n" ,scsi_req (rq)->cmd[0 ]);/* Retry operation */ ide_retry_pc (drive);
@@ -531,7 +531,7 @@ static ide_startstop_t ide_pc_intr(ide_dide_pad_transfer (drive, write, bcount);debug_log ("[cmd %x] transferred %d bytes, padded %d bytes, resid: %u\n" , - rq->cmd[0 ], done, bcount,scsi_req (rq)->resid_len); +scsi_req (rq)->cmd[0 ], done, bcount,scsi_req (rq)->resid_len);/* And set the interrupt handler again */ ide_set_handler (drive, ide_pc_intr, timeout);
Patches currently in stable-queue which might be from [email protected] are
queue-4.14/ide-ide-atapi-fix-compile-error-with-defining-macro-debug.patch