Skip to contentSkip to conversation

Patch "mfd: mxs-lradc: Fix error handling in mxs_lradc_probe()" has been added to the 4.14-stable tree

PATCH [email protected] 1 participant 1 message Dec 18, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

mfd: mxs-lradc: Fix error handling in mxs_lradc_probe()

to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
mfd-mxs-lradc-fix-error-handling-in-mxs_lradc_probe.patch
and it can be found in the queue-4.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Mon Dec 18 13:28:59 CET 2017

From: Alexey Khoroshilov <[email protected]>
Date: Sat, 14 Oct 2017 01:06:56 +0300
Subject: mfd: mxs-lradc: Fix error handling in mxs_lradc_probe()

From: Alexey Khoroshilov <[email protected]>

[ Upstream commit 362741a21a5c4b9ee31e75ce28d63c6d238a745c ]

There is the only path, where mxs_lradc_probe() leaves clk undisabled, since it does return instead of goto err_clk.

Found by Linux Driver Verification project (linuxtesting.org).

---
 drivers/mfd/mxs-lradc.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/mfd/mxs-lradc.c +4 -2
@@ -196,8 +196,10 @@ static int mxs_lradc_probe(struct platfo
 	platform_set_drvdata(pdev, lradc);
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!res)
-		return -ENOMEM;
+	if (!res) {
+		ret = -ENOMEM;
+		goto err_clk;
+	}
 
 	switch (lradc->soc) {
 	case IMX23_LRADC:

Patches currently in stable-queue which might be from [email protected] are

queue-4.14/mfd-mxs-lradc-fix-error-handling-in-mxs_lradc_probe.patch