Skip to contentSkip to conversation

Patch "drm/omap: fix dmabuf mmap for dma_alloc'ed buffers" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Dec 18, 2017

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

drm/omap: fix dmabuf mmap for dma_alloc'ed buffers

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
drm-omap-fix-dmabuf-mmap-for-dma_alloc-ed-buffers.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Mon Dec 18 14:47:43 CET 2017

From: Tomi Valkeinen <[email protected]>
Date: Tue, 28 Feb 2017 10:11:45 +0200
Subject: drm/omap: fix dmabuf mmap for dma_alloc'ed buffers

From: Tomi Valkeinen <[email protected]>

[ Upstream commit 9fa1d7537242bd580ffa99c4725a0407096aad26 ]

omap_gem_dmabuf_mmap() returns an error (with a WARN) when called for a buffer which is allocated with dma_alloc_*(). This prevents dmabuf mmap from working on SoCs without DMM, e.g. AM4 and OMAP3.

I could not find any reason for omap_gem_dmabuf_mmap() rejecting such buffers, and just removing the if() fixes the limitation.

---
 drivers/gpu/drm/omapdrm/omap_gem_dmabuf.c |    3 ---
 1 file changed, 3 deletions(-)
drivers/gpu/drm/omapdrm/omap_gem_dmabuf.c +0 -3
@@ -142,9 +142,6 @@ static int omap_gem_dmabuf_mmap(struct d
 	struct drm_gem_object *obj = buffer->priv;
 	int ret = 0;
 
-	if (WARN_ON(!obj->filp))
-		return -EINVAL;
-
 	ret = drm_gem_mmap_obj(obj, omap_gem_mmap_size(obj), vma);
 	if (ret < 0)
 		return ret;

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/drm-omap-fix-dmabuf-mmap-for-dma_alloc-ed-buffers.patch