Skip to contentSkip to conversation

Patch "crypto: lrw - Fix an error handling path in 'create()'" has been added to the 4.14-stable tree

PATCH [email protected] 1 participant 1 message Dec 20, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

crypto: lrw - Fix an error handling path in 'create()'

to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
crypto-lrw-fix-an-error-handling-path-in-create.patch
and it can be found in the queue-4.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Wed Dec 20 18:17:52 CET 2017

From: Christophe Jaillet <[email protected]>
Date: Sun, 8 Oct 2017 11:39:49 +0200
Subject: crypto: lrw - Fix an error handling path in 'create()'

From: Christophe Jaillet <[email protected]>

[ Upstream commit 616129cc6e75fb4da6681c16c981fa82dfe5e4c7 ]

All error handling paths 'goto err_drop_spawn' except this one. In order to avoid some resources leak, we should do it as well here.

Fixes 700cb3f5fe75 ("crypto: lrw - Convert to skcipher")
---
 crypto/lrw.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
crypto/lrw.c +4 -2
@@ -610,8 +610,10 @@ static int create(struct crypto_template
 		ecb_name[len - 1] = 0;
 
 		if (snprintf(inst->alg.base.cra_name, CRYPTO_MAX_ALG_NAME,
-			     "lrw(%s)", ecb_name) >= CRYPTO_MAX_ALG_NAME)
-			return -ENAMETOOLONG;
+			     "lrw(%s)", ecb_name) >= CRYPTO_MAX_ALG_NAME) {
+			err = -ENAMETOOLONG;
+			goto err_drop_spawn;
+		}
 	}
 
 	inst->alg.base.cra_flags = alg->base.cra_flags & CRYPTO_ALG_ASYNC;

Patches currently in stable-queue which might be from [email protected] are

queue-4.14/crypto-lrw-fix-an-error-handling-path-in-create.patch queue-4.14/igb-check-memory-allocation-failure.patch