Patch "ixgbe: fix use of uninitialized padding" has been added to the 4.14-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
ixgbe: fix use of uninitialized padding
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ixgbe-fix-use-of-uninitialized-padding.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Wed Dec 20 18:17:52 CET 2017
From: Emil Tantilov <[email protected]>
Date: Mon, 11 Sep 2017 14:21:31 -0700
Subject: ixgbe: fix use of uninitialized padding
From: Emil Tantilov <[email protected]>
[ Upstream commit dcfd6b839c998bc9838e2a47f44f37afbdf3099c ]
This patch is resolving Coverity hits where padding in a structure could be used uninitialized.
- Initialize fwd_cmd.pad/2 before ixgbe_calculate_checksum()
- Initialize buffer.pad2/3 before ixgbe_hic_unlocked()
--- drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 4 ++-- drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/ixgbe/ixgbe_common.c +2 -2
@@ -3781,10 +3781,10 @@ s32 ixgbe_set_fw_drv_ver_generic(struct fw_cmd.ver_build = build; fw_cmd.ver_sub = sub; fw_cmd.hdr.checksum =0 ; - fw_cmd.hdr.checksum =ixgbe_calculate_checksum ((u8 *)&fw_cmd, - (FW_CEM_HDR_LEN + fw_cmd.hdr.buf_len)); fw_cmd.pad =0 ; fw_cmd.pad2 =0 ; + fw_cmd.hdr.checksum =ixgbe_calculate_checksum ((u8 *)&fw_cmd, + (FW_CEM_HDR_LEN + fw_cmd.hdr.buf_len));for (i =0 ; i <=FW_CEM_MAX_RETRIES ; i++) { ret_val = ixgbe_host_interface_command(hw, &fw_cmd,
drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c +2 -0
@@ -900,6 +900,8 @@ static s32 ixgbe_read_ee_hostif_buffer_X/* convert offset from words to bytes */ buffer.address =cpu_to_be32 ((offset + current_word) *2 ); buffer.length =cpu_to_be16 (words_to_read *2 ); + buffer.pad2 =0 ; + buffer.pad3 =0 ; status =ixgbe_hic_unlocked (hw, (u32 *)&buffer,sizeof (buffer),IXGBE_HI_COMMAND_TIMEOUT );
Patches currently in stable-queue which might be from [email protected] are
queue-4.14/ixgbe-fix-use-of-uninitialized-padding.patch