Skip to contentSkip to conversation

Patch "optee: fix invalid of_node_put() in optee_driver_init()" has been added to the 4.14-stable tree

PATCH [email protected] 1 participant 1 message Dec 20, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

optee: fix invalid of_node_put() in optee_driver_init()

to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
optee-fix-invalid-of_node_put-in-optee_driver_init.patch
and it can be found in the queue-4.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From f044113113dd95ba73916bde10e804d3cdfa2662 Mon Sep 17 00:00:00 2001

From: Jens Wiklander <[email protected]>
Date: Mon, 9 Oct 2017 11:11:49 +0200
Subject: optee: fix invalid of_node_put() in optee_driver_init()

From: Jens Wiklander <[email protected]>

commit f044113113dd95ba73916bde10e804d3cdfa2662 upstream.

The first node supplied to of_find_matching_node() has its reference counter decreased as part of call to that function. In optee_driver_init() after calling of_find_matching_node() it's invalid to call of_node_put() on the supplied node again.

So remove the invalid call to of_node_put().

---
 drivers/tee/optee/core.c |    1 -
 1 file changed, 1 deletion(-)
drivers/tee/optee/core.c +0 -1
@@ -590,7 +590,6 @@ static int __init optee_driver_init(void
 		return -ENODEV;
 
 	np = of_find_matching_node(fw_np, optee_match);
-	of_node_put(fw_np);
 	if (!np)
 		return -ENODEV;
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.14/optee-fix-invalid-of_node_put-in-optee_driver_init.patch