perf tools: Get correct max value of format attribute
PATCH 1/1 perf tools: Get correct max value of format attribute
Currently, the maximum value of every format attribute is not being correctly set.
For eg:
cat /sys/devices/cpu/format/umask
config:8-15
This implies the max_value of umask should be 0xff
./perf stat –e cpu/umask=0x100/ sleep 1
Performance counter stats for '../rets-128.bin':
0 cpu/umask=0x100/
0.109157272 seconds time elapsedworks just fine(0x100 > 0xff). Whereas,
./perf stat –e cpu/umask=0xff01/ sleep 1
event syntax error: 'cpu/umask=0xff01/'
\___ value too big for format, maximum is
65280(0xff00)
The maximum value is set to 0xff00 instead of 0xff.
This patch fixes the pmu_format_max_value() function to return the correct maximum value.
Acked-by Jiri Olsa <[email protected]>
Signed-off-by Megha Dey <[email protected]>
--- tools/perf/util/pmu.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
tools/perf/util/pmu.c +1 -7
@@ -777,13 +777,7 @@ static void pmu_format_value(unsigned long *format, __u64 value, __u64 *v,static __u64 pmu_format_max_value (const unsigned long *format) { -__u64 w =0 ; -int fbit; - -for_each_set_bit (fbit, format,PERF_PMU_FORMAT_BITS ) - w |= (1ULL << fbit); - -return w; +return (1ULL <<bitmap_weight (format,PERF_PMU_FORMAT_BITS )) -1 ; }/*
Signature · 1 line
1.9.1