Skip to contentSkip to conversation

Patch "platform/x86: asus-wireless: send an EV_SYN/SYN_REPORT between state changes" has been added to the 4.14-stable tree

PATCH [email protected] 1 participant 1 message Dec 21, 2017

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

platform/x86: asus-wireless: send an EV_SYN/SYN_REPORT between state changes

to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
platform-x86-asus-wireless-send-an-ev_syn-syn_report-between-state-changes.patch
and it can be found in the queue-4.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From bff5bf9db1c9453ffd0a78abed3e2d040c092fd9 Mon Sep 17 00:00:00 2001

From: Peter Hutterer <[email protected]>
Date: Mon, 4 Dec 2017 10:26:17 +1000
Subject: platform/x86: asus-wireless: send an EV_SYN/SYN_REPORT between state changes

From: Peter Hutterer <[email protected]>

commit bff5bf9db1c9453ffd0a78abed3e2d040c092fd9 upstream.

Sending the switch state change twice within the same frame is invalid evdev protocol and only works if the client handles keys immediately as well. Processing events immediately is incorrect, it forces a fake order of events that does not exist on the device.

Recent versions of libinput changed to only process the device state and SYN_REPORT time, so now the key event is lost.

https://bugs.freedesktop.org/show_bug.cgi?id=104041

---
 drivers/platform/x86/asus-wireless.c |    1 +
 1 file changed, 1 insertion(+)
drivers/platform/x86/asus-wireless.c +1 -0
@@ -118,6 +118,7 @@ static void asus_wireless_notify(struct
 		return;
 	}
 	input_report_key(data->idev, KEY_RFKILL, 1);
+	input_sync(data->idev);
 	input_report_key(data->idev, KEY_RFKILL, 0);
 	input_sync(data->idev);
 }

Patches currently in stable-queue which might be from [email protected] are

queue-4.14/platform-x86-asus-wireless-send-an-ev_syn-syn_report-between-state-changes.patch