Skip to contentSkip to conversation

drm: fix tainted kernel caused by drm_panel_orientation_quirks.c

PATCH In review David Lechner 3 participants 3 messages Dec 21, 2017 – Dec 23, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: fix tainted kernel caused by drm_panel_orientation_quirks.c

drm_panel_orientation_quirks.c introduced in commit 404d1a3edc38 ("drm:
Add panel orientation quirks, v6.") taints the kernel when compiled as a module. Fix this by adding MODULE_LICENSE().

---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/drm_panel_orientation_quirks.c +3 -0
index 901a4e9..1f2af70 100644
@@ -9,6 +9,7 @@
  */
 
 #include <linux/dmi.h>
+#include <linux/module.h>
 #include <drm/drm_connector.h>
 
 #ifdef CONFIG_DMI
@@ -172,3 +173,5 @@ int drm_get_panel_orientation_quirk(int width, int height)
 EXPORT_SYMBOL(drm_get_panel_orientation_quirk);
 
 #endif
+
+MODULE_LICENSE("Dual MIT/GPL");
Signature · 6 lines
2.7.4

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 5 lines · David Lechner

drm_panel_orientation_quirks.c introduced in commit 404d1a3edc38 ("drm:
Add panel orientation quirks, v6.") taints the kernel when compiled as a module. Fix this by adding MODULE_LICENSE().

Thank you for taking care of this, looks good to me:

Regards,

Hans

Quoted 23 lines
---
  drivers/gpu/drm/drm_panel_orientation_quirks.c | 3 +++
  1 file changed, 3 insertions(+)
drivers/gpu/drm/drm_panel_orientation_quirks.c +3 -0
index 901a4e9..1f2af70 100644
@@ -9,6 +9,7 @@
   */
 
  #include <linux/dmi.h>
+#include <linux/module.h>
  #include <drm/drm_connector.h>
 
  #ifdef CONFIG_DMI
@@ -172,3 +173,5 @@ int drm_get_panel_orientation_quirk(int width, int height)
  EXPORT_SYMBOL(drm_get_panel_orientation_quirk);
 
  #endif
+
+MODULE_LICENSE("Dual MIT/GPL");
#2 lore raw
In reply to David Lechner

Hi,

Quoted 5 lines · David Lechner

drm_panel_orientation_quirks.c introduced in commit 404d1a3edc38 ("drm:
Add panel orientation quirks, v6.") taints the kernel when compiled as a module. Fix this by adding MODULE_LICENSE().

Thank you, I've pushed this patch to drm-misc-next.

Regards,

Hans

Quoted 18 lines
---
  drivers/gpu/drm/drm_panel_orientation_quirks.c | 3 +++
  1 file changed, 3 insertions(+)
drivers/gpu/drm/drm_panel_orientation_quirks.c +1 -0
index 901a4e9..1f2af70 100644
@@ -9,6 +9,7 @@
   */
 
  #include <linux/dmi.h>
+#include <linux/module.h>
  #include <drm/drm_connector.h>
 
  #ifdef CONFIG_DMI

drivers/gpu/drm/drm_panel_orientation_quirks.c int drm_get_panel_orientation_quirk(int width, int height) · line 177

Quoted 5 lines
drivers/gpu/drm/drm_panel_orientation_quirks.c +2 -0
@@ -172,3 +173,5 @@ int drm_get_panel_orientation_quirk(int width, int height)
  EXPORT_SYMBOL(drm_get_panel_orientation_quirk);
 
  #endif
+
+MODULE_LICENSE("Dual MIT/GPL");

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel