Patch "acpi, nfit: fix health event notification" has been added to the 4.9-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
acpi, nfit: fix health event notification
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
acpi-nfit-fix-health-event-notification.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
adf6895754e2503d994a765535fd1813f8834674Mon Sep 17 00:00:00 2001
From: Dan Williams <[email protected]>
Date: Thu, 30 Nov 2017 19:42:52 -0800
Subject: acpi, nfit: fix health event notification
From: Dan Williams <[email protected]>
commit adf6895754e2503d994a765535fd1813f8834674 upstream.
Integration testing with a BIOS that generates injected health event notifications fails to communicate those events to userspace. The nfit driver neglects to link the ACPI DIMM device with the necessary driver data so acpi_nvdimm_notify() fails this lookup:
nfit_mem = dev_get_drvdata(dev);
if (nfit_mem && nfit_mem->flags_attr)
sysfs_notify_dirent(nfit_mem->flags_attr);Add the necessary linkage when installing the notification handler and clean it up when the nfit driver instance is torn down.
--- drivers/acpi/nfit/core.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
drivers/acpi/nfit/core.c +8 -1
@@ -1390,6 +1390,11 @@ static int acpi_nfit_add_dimm(struct acp dev_name(&adev_dimm->dev));return -ENXIO ; } +/* +* Record nfit_mem for the notification path to track back to +* the nfit sysfs attributes for this dimm device object. +*/ +dev_set_drvdata (&adev_dimm->dev, nfit_mem);/* * Until standardization materializes we need to consider 4
@@ -1446,9 +1451,11 @@ static void shutdown_dimm_notify(void *dsysfs_put (nfit_mem->flags_attr); nfit_mem->flags_attr =NULL ; } -if (adev_dimm) +if (adev_dimm) {acpi_remove_notify_handler (adev_dimm->handle,ACPI_DEVICE_NOTIFY , acpi_nvdimm_notify); +dev_set_drvdata (&adev_dimm->dev,NULL ); + } }mutex_unlock (&acpi_desc->init_mutex); }
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/libnvdimm-pfn-fix-start_pad-handling-for-aligned-namespaces.patch queue-4.9/libnvdimm-dax-fix-1gb-aligned-namespaces-vs-physical-misalignment.patch queue-4.9/acpi-nfit-fix-health-event-notification.patch