drivers/fbtft: Fix indentation
Subsystems (2)
PATCH 3/3 drivers/fbtft: Fix indentation
--- drivers/staging/fbtft/fbtft-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/fbtft/fbtft-core.c +2 -2
@@ -1377,8 +1377,8 @@ int fbtft_probe_common(struct fbtft_display *display, par->fbtftops.write_register = fbtft_write_reg16_bus16; else dev_warn(dev, -"no default functions for regwidth=%d and buswidth=%d\n" , - display->regwidth, display->buswidth); +"no default functions for regwidth=%d and buswidth=%d\n" , + display->regwidth, display->buswidth);/* write_vmem() functions */ if (display->buswidth ==8 )
Signature · 1 line
2.7.4
Greg Kroah-Hartman
maintainerQuoted 6 lines · Luis Gerhorst
Signed-off-by Luis Gerhorst <[email protected]>Acked-by Jonny Schaefer <[email protected]>--- drivers/staging/fbtft/fbtft-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
I can't take a patch without any changelog text at all, sorry.
greg k-h
PATCH v2 1/1 drivers/fbtft: Fix indentation
From: Luis Gerhorst <[email protected]>
This fixes the checkpatch message:
CHECK: Alignment should match open parenthesis #1380: FILE: drivers/staging/fbtft/fbtft-core.c:1380:
+ dev_warn(dev,
+ "no default functions for regwidth=%d and buswidth=%d\n",
---
Changes since v1:
- Add patch description
--- drivers/staging/fbtft/fbtft-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/fbtft/fbtft-core.c +2 -2
@@ -1377,8 +1377,8 @@ int fbtft_probe_common(struct fbtft_display *display, par->fbtftops.write_register = fbtft_write_reg16_bus16; else dev_warn(dev, -"no default functions for regwidth=%d and buswidth=%d\n" , - display->regwidth, display->buswidth); +"no default functions for regwidth=%d and buswidth=%d\n" , + display->regwidth, display->buswidth);/* write_vmem() functions */ if (display->buswidth ==8 )
Signature · 1 line
2.7.4
Quoted 9 lines · Jonny Schaefer
From: Luis Gerhorst <[email protected]>
This fixes the checkpatch message:
CHECK: Alignment should match open parenthesis #1380: FILE:
drivers/staging/fbtft/fbtft-core.c:1380:
+ dev_warn(dev,
+ "no default functions for regwidth=%d and buswidth=%d\n",
Perhaps:
Checkpatch emits CHECK: Alignment should match open parenthesis
Align code to open parenthesis.
Reasoning:
Patch description should describe the problem then describe what the patch does (in imperative mood). Better advice is given in Documentation/process/submitting-patches.rst section 2
Hope this helps,
Tobin.