drm/i915/guc: Move GuC WOPCM related code into separate files
Subsystems (2)
PATCH v5 1/6 drm/i915/guc: Move GuC WOPCM related code into separate files
intel_guc_reg.h should only include definition for GuC registers and related register bits. GuC WOPCM related values should not be defined in intel_guc_reg.h
This patch creates a better file structure by moving GuC WOPCM related definitions int to a new header intel_guc_wopcm.h and moving GuC WOPCM related functions to a new source file intel_guc_wopcm.c
--- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/intel_guc.c | 11 -------- drivers/gpu/drm/i915/intel_guc.h | 2 +- drivers/gpu/drm/i915/intel_guc_reg.h | 4 --- drivers/gpu/drm/i915/intel_guc_wopcm.c | 47 ++++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_guc_wopcm.h | 39 ++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_uc.c | 2 +- drivers/gpu/drm/i915/intel_uc_fw.c | 2 +- 8 files changed, 90 insertions(+), 18 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_guc_wopcm.c create mode 100644 drivers/gpu/drm/i915/intel_guc_wopcm.h
drivers/gpu/drm/i915/Makefile +1 -0
@@ -88,6 +88,7 @@ i915-y += intel_uc.o \ intel_guc_fw.o \ intel_guc_log.o \ intel_guc_submission.o \ + intel_guc_wopcm.o \ intel_huc.o # autogenerated null render state
drivers/gpu/drm/i915/intel_guc.c +0 -11
@@ -496,14 +496,3 @@ struct i915_vma *intel_guc_allocate_vma(struct intel_guc *guc, u32 size)i915_gem_object_put (obj);return vma; } - -u32 intel_guc_wopcm_size (struct drm_i915_private *dev_priv) -{ -u32 wopcm_size =GUC_WOPCM_TOP ; - -/* On BXT, the top of WOPCM is reserved for RC6 context */ -if (IS_GEN9_LP (dev_priv)) - wopcm_size -=BXT_GUC_WOPCM_RC6_RESERVED ; - -return wopcm_size; -}
drivers/gpu/drm/i915/intel_guc.h +1 -1
@@ -31,6 +31,7 @@#include "intel_guc_ct.h" #include "intel_guc_log.h" #include "intel_guc_reg.h" +#include "intel_guc_wopcm.h" #include "intel_uc_fw.h" #include "i915_vma.h"
@@ -130,6 +131,5 @@ int intel_guc_auth_huc(struct intel_guc *guc, u32 rsa_offset);int intel_guc_suspend (struct drm_i915_private *dev_priv);int intel_guc_resume (struct drm_i915_private *dev_priv);struct i915_vma *intel_guc_allocate_vma (struct intel_guc *guc,u32 size); -u32 intel_guc_wopcm_size (struct drm_i915_private *dev_priv);#endif
drivers/gpu/drm/i915/intel_guc_reg.h +0 -4
@@ -68,7 +68,6 @@#define DMA_GUC_WOPCM_OFFSET _MMIO(0xc340)#define HUC_LOADING_AGENT_VCR (0<<1)#define HUC_LOADING_AGENT_GUC (1<<1) -#define GUC_WOPCM_OFFSET_VALUE 0x80000/* 512KB */ #define GUC_MAX_IDLE_COUNT _MMIO(0xC3E4)#define HUC_STATUS2 _MMIO(0xD3B0)
@@ -76,9 +75,6 @@/* Defines WOPCM space available to GuC firmware */ #define GUC_WOPCM_SIZE _MMIO(0xc050) -/* GuC addresses below GUC_WOPCM_TOP don't map through the GTT */ -#define GUC_WOPCM_TOP (0x80 << 12)/* 512KB */ -#define BXT_GUC_WOPCM_RC6_RESERVED (0x10 << 12)/* 64KB */ /* GuC addresses above GUC_GGTT_TOP also don't map through the GTT */ #define GUC_GGTT_TOP 0xFEE00000
drivers/gpu/drm/i915/intel_guc_wopcm.c new file +47 -0
47 lines not on this page · raw message
drivers/gpu/drm/i915/intel_guc_wopcm.h new file +39 -0
@@ -0,0 +1,39 @@ +/* +* Copyright © 2017 Intel Corporation +* +* Permission is hereby granted, free of charge, to any person obtaining a +* copy of this software and associated documentation files (the "Software"), +* to deal in the Software without restriction, including without limitation +* the rights to use, copy, modify, merge, publish, distribute, sublicense, +* and/or sell copies of the Software, and to permit persons to whom the +* Software is furnished to do so, subject to the following conditions: +* +* The above copyright notice and this permission notice (including the next +* paragraph) shall be included in all copies or substantial portions of the +* Software. +* +* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL +* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING +* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS +* IN THE SOFTWARE. +* +*/ + +#ifndef _INTEL_GUC_WOPCM_H_ +#define _INTEL_GUC_WOPCM_H_ + +#include <linux/types.h> + +struct intel_guc ; + +#define GUC_WOPCM_OFFSET_VALUE 0x80000/* 512KB */ +/* GuC addresses below GUC_WOPCM_TOP don't map through the GTT */ +#define GUC_WOPCM_TOP (0x80 << 12)/* 512KB */ +#define BXT_GUC_WOPCM_RC6_RESERVED (0x10 << 12)/* 64KB */ + +u32 intel_guc_wopcm_size (struct intel_guc *guc); + +#endif
drivers/gpu/drm/i915/intel_uc.c +1 -1
@@ -274,7 +274,7 @@ int intel_uc_init_hw(struct drm_i915_private *dev_priv)gen9_reset_guc_interrupts (dev_priv);/* init WOPCM */ -I915_WRITE (GUC_WOPCM_SIZE ,intel_guc_wopcm_size (dev_priv)); +I915_WRITE (GUC_WOPCM_SIZE ,intel_guc_wopcm_size (guc));I915_WRITE (DMA_GUC_WOPCM_OFFSET ,GUC_WOPCM_OFFSET_VALUE |HUC_LOADING_AGENT_GUC );
drivers/gpu/drm/i915/intel_uc_fw.c +1 -1
@@ -97,7 +97,7 @@ void intel_uc_fw_fetch(struct drm_i915_private *dev_priv,/* Header and uCode will be loaded to WOPCM */ size = uc_fw->header_size + uc_fw->ucode_size; -if (size >intel_guc_wopcm_size (dev_priv)) { +if (size >intel_guc_wopcm_size (&dev_priv->guc)) {DRM_WARN ("%s: Firmware is too large to fit in WOPCM\n" ,intel_uc_fw_type_repr (uc_fw->type)); err = -E2BIG ;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v5 2/6 drm/i915/guc: Rename guc_ggtt_offset to intel_guc_ggtt_offset
GuC related exported functions should start with "intel_guc_" prefix and pass intel_guc as the first parameter since its guc related. Current guc_ggtt_offset() failed to follow this code convention.
This patch renames the guc_ggtt_offset to intel_guc_ggtt_offset and updates the related code to pass intel_guc pointer to this function call. so that we have a unified coding style for GuC code.
--- drivers/gpu/drm/i915/intel_guc.c | 12 +++++++----- drivers/gpu/drm/i915/intel_guc.h | 10 ++++++++-- drivers/gpu/drm/i915/intel_guc_ads.c | 25 +++++++++++++------------ drivers/gpu/drm/i915/intel_guc_ct.c | 5 +++-- drivers/gpu/drm/i915/intel_guc_fw.c | 2 +- drivers/gpu/drm/i915/intel_guc_log.c | 2 +- drivers/gpu/drm/i915/intel_guc_submission.c | 10 +++++----- drivers/gpu/drm/i915/intel_huc.c | 6 ++++-- 8 files changed, 42 insertions(+), 30 deletions(-)
drivers/gpu/drm/i915/intel_guc.c +7 -5
@@ -256,8 +256,10 @@ void intel_guc_init_params(struct intel_guc *guc)/* If GuC submission is enabled, set up additional parameters here */ if (USES_GUC_SUBMISSION (dev_priv)) { -u32 ads =guc_ggtt_offset (guc->ads_vma) >>PAGE_SHIFT ; -u32 pgs =guc_ggtt_offset (dev_priv->guc.stage_desc_pool); +u32 ads =intel_guc_ggtt_offset (guc, + guc->ads_vma) >>PAGE_SHIFT ; +u32 pgs =intel_guc_ggtt_offset (guc, + dev_priv->guc.stage_desc_pool);u32 ctx_in_16 =GUC_MAX_STAGE_DESCRIPTORS /16 ; params[GUC_CTL_DEBUG ] |= ads <<GUC_ADS_ADDR_SHIFT ;
@@ -405,7 +407,7 @@ int intel_guc_suspend(struct drm_i915_private *dev_priv) data[0 ] =INTEL_GUC_ACTION_ENTER_S_STATE ;/* any value greater than GUC_POWER_D0 */ data[1 ] =GUC_POWER_D1 ; - data[2 ] =guc_ggtt_offset (guc->shared_data); + data[2 ] =intel_guc_ggtt_offset (guc, guc->shared_data);return intel_guc_send (guc, data,ARRAY_SIZE (data)); }
@@ -428,7 +430,7 @@ int intel_guc_reset_engine(struct intel_guc *guc, data[3 ] =0 ; data[4 ] =0 ; data[5 ] = guc->execbuf_client->stage_id; - data[6 ] =guc_ggtt_offset (guc->shared_data); + data[6 ] =intel_guc_ggtt_offset (guc, guc->shared_data);return intel_guc_send (guc, data,ARRAY_SIZE (data)); }
@@ -450,7 +452,7 @@ int intel_guc_resume(struct drm_i915_private *dev_priv) data[0 ] =INTEL_GUC_ACTION_EXIT_S_STATE ; data[1 ] =GUC_POWER_D0 ; - data[2 ] =guc_ggtt_offset (guc->shared_data); + data[2 ] =intel_guc_ggtt_offset (guc, guc->shared_data);return intel_guc_send (guc, data,ARRAY_SIZE (data)); }
drivers/gpu/drm/i915/intel_guc.h +8 -2
@@ -101,13 +101,19 @@ static inline void intel_guc_notify(struct intel_guc *guc) guc->notify (guc); } -/* +/* intel_guc_ggtt_offset() - Get the GGTT offset of @vma. +* @guc: intel guc. +* @vma: i915 graphics virtual memory area. +* * GuC does not allow any gfx GGTT address that falls into range [0, WOPCM_TOP), * which is reserved for Boot ROM, SRAM and WOPCM. Currently this top address is * 512K. In order to exclude 0-512K address space from GGTT, all gfx objects * used by GuC is pinned with PIN_OFFSET_BIAS along with size of WOPCM. +* +* Return: GGTT offset that meets the GuC gfx address requirement. */ -static inline u32 guc_ggtt_offset (struct i915_vma *vma) +static inline u32 intel_guc_ggtt_offset (struct intel_guc *guc, +struct i915_vma *vma) {u32 offset =i915_ggtt_offset (vma);
drivers/gpu/drm/i915/intel_guc_ads.c +13 -12
@@ -113,17 +113,6 @@ int intel_guc_ads_create(struct intel_guc *guc) blob->reg_state.white_list[engine->guc_id].count =0 ; } -/* -* The GuC requires a "Golden Context" when it reinitialises -* engines after a reset. Here we use the Render ring default -* context, which must already exist and be pinned in the GGTT, -* so its address won't change after we've told the GuC where -* to find it. Note that we have to skip our header (1 page), -* because our GuC shared data is there. -*/ - blob->ads.golden_context_lrca = -guc_ggtt_offset (dev_priv->kernel_context->engine[RCS ].state) + - skipped_offset;/* * The GuC expects us to exclude the portion of the context image that
@@ -135,11 +124,23 @@ int intel_guc_ads_create(struct intel_guc *guc) blob->ads.eng_state_size[engine->guc_id] = engine->context_size - skipped_size; - base =guc_ggtt_offset (vma); + base =intel_guc_ggtt_offset (guc, vma); blob->ads.scheduler_policies = base +ptr_offset (blob, policies); blob->ads.reg_state_buffer = base +ptr_offset (blob, reg_state_buffer); blob->ads.reg_state_addr = base +ptr_offset (blob, reg_state); +/* +* The GuC requires a "Golden Context" when it reinitialises +* engines after a reset. Here we use the Render ring default +* context, which must already exist and be pinned in the GGTT, +* so its address won't change after we've told the GuC where +* to find it. Note that we have to skip our header (1 page), +* because our GuC shared data is there. +*/ + vma = dev_priv->kernel_context->engine[RCS ].state; + blob->ads.golden_context_lrca =intel_guc_ggtt_offset (guc, vma) + + skipped_offset; +kunmap (page);return 0 ;
drivers/gpu/drm/i915/intel_guc_ct.c +3 -2
@@ -156,7 +156,8 @@ static int ctch_init(struct intel_guc *guc, err =PTR_ERR (blob); goto err_vma; } -DRM_DEBUG_DRIVER ("CT: vma base=%#x\n" ,guc_ggtt_offset (ctch->vma)); +DRM_DEBUG_DRIVER ("CT: vma base=%#x\n" , +intel_guc_ggtt_offset (guc, ctch->vma));/* store pointers to desc and cmds */ for (i =0 ; i <ARRAY_SIZE (ctch->ctbs); i++) {
@@ -202,7 +203,7 @@ static int ctch_open(struct intel_guc *guc, }/* vma should be already allocated and map'ed */ - base =guc_ggtt_offset (ctch->vma); + base =intel_guc_ggtt_offset (guc, ctch->vma);/* (re)initialize descriptors * cmds buffers are in the second half of the blob page
drivers/gpu/drm/i915/intel_guc_fw.c +1 -1
@@ -165,7 +165,7 @@ static int guc_xfer_ucode(struct intel_guc *guc, struct i915_vma *vma)I915_WRITE (DMA_COPY_SIZE , guc_fw->header_size + guc_fw->ucode_size);/* Set the source address for the new blob */ - offset =guc_ggtt_offset (vma) + guc_fw->header_offset; + offset =intel_guc_ggtt_offset (guc, vma) + guc_fw->header_offset;I915_WRITE (DMA_ADDR_0_LOW ,lower_32_bits (offset));I915_WRITE (DMA_ADDR_0_HIGH ,upper_32_bits (offset) &0xFFFF );
drivers/gpu/drm/i915/intel_guc_log.c +1 -1
@@ -549,7 +549,7 @@ int intel_guc_log_create(struct intel_guc *guc) (GUC_LOG_ISR_PAGES <<GUC_LOG_ISR_SHIFT ) | (GUC_LOG_CRASH_PAGES <<GUC_LOG_CRASH_SHIFT ); - offset =guc_ggtt_offset (vma) >>PAGE_SHIFT ;/* in pages */ + offset =intel_guc_ggtt_offset (guc, vma) >>PAGE_SHIFT ;/* in pages */ guc->log.flags = (offset <<GUC_LOG_BUF_ADDR_SHIFT ) | flags;return 0 ;
drivers/gpu/drm/i915/intel_guc_submission.c +5 -5
@@ -375,8 +375,8 @@ static void guc_stage_desc_init(struct intel_guc *guc, lrc->context_desc =lower_32_bits (ce->lrc_desc);/* The state page is after PPHWSP */ - lrc->ring_lrca = -guc_ggtt_offset (ce->state) +LRC_STATE_PN *PAGE_SIZE ; + lrc->ring_lrca =intel_guc_ggtt_offset (guc, ce->state) + +LRC_STATE_PN *PAGE_SIZE ;/* XXX: In direct submission, the GuC wants the HW context id * here. In proxy submission, it wants the stage id
@@ -384,7 +384,7 @@ static void guc_stage_desc_init(struct intel_guc *guc, lrc->context_id = (client->stage_id <<GUC_ELC_CTXID_OFFSET ) | (guc_engine_id <<GUC_ELC_ENGINE_OFFSET ); - lrc->ring_begin =guc_ggtt_offset (ce->ring->vma); + lrc->ring_begin =intel_guc_ggtt_offset (guc, ce->ring->vma); lrc->ring_end = lrc->ring_begin + ce->ring->size -1 ; lrc->ring_next_free_location = lrc->ring_begin; lrc->ring_current_tail_pointer_value =0 ;
@@ -400,7 +400,7 @@ static void guc_stage_desc_init(struct intel_guc *guc,* The doorbell, process descriptor, and workqueue are all parts * of the client object, which the GuC will reference via the GGTT */ - gfx_addr =guc_ggtt_offset (client->vma); + gfx_addr =intel_guc_ggtt_offset (guc, client->vma); desc->db_trigger_phy =sg_dma_address (client->vma->pages->sgl) + client->doorbell_offset; desc->db_trigger_cpu =ptr_to_u64 (__get_doorbell (client));
@@ -596,7 +596,7 @@ static void inject_preempt_context(struct work_struct *work) data[3 ] = engine->guc_id; data[4 ] = guc->execbuf_client->priority; data[5 ] = guc->execbuf_client->stage_id; - data[6 ] =guc_ggtt_offset (guc->shared_data); + data[6 ] =intel_guc_ggtt_offset (guc, guc->shared_data);if (WARN_ON (intel_guc_send (guc, data,ARRAY_SIZE (data)))) { execlists_clear_active(&engine->execlists,
drivers/gpu/drm/i915/intel_huc.c +4 -2
@@ -137,7 +137,8 @@ static int huc_ucode_xfer(struct intel_uc_fw *huc_fw, struct i915_vma *vma)intel_uncore_forcewake_get (dev_priv,FORCEWAKE_ALL );/* Set the source address for the uCode */ - offset =guc_ggtt_offset (vma) + huc_fw->header_offset; + offset =intel_guc_ggtt_offset (&dev_priv->guc, vma) + + huc_fw->header_offset;I915_WRITE (DMA_ADDR_0_LOW ,lower_32_bits (offset));I915_WRITE (DMA_ADDR_0_HIGH ,upper_32_bits (offset) &0xFFFF );
@@ -213,7 +214,8 @@ int intel_huc_auth(struct intel_huc *huc) } ret =intel_guc_auth_huc (guc, -guc_ggtt_offset (vma) + huc->fw.rsa_offset); +intel_guc_ggtt_offset (guc, vma) + + huc->fw.rsa_offset);if (ret) {DRM_ERROR ("HuC: GuC did not ack Auth request %d\n" , ret); goto out;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v5 3/6 drm/i915/guc: Implement dynamic GuC WOPCM offset and size
In reply to Jackie LiHardware may have specific restrictions on GuC WOPCM size versus HuC firmware size. With static GuC WOPCM size, there's no way to adjust the GuC WOPCM partition size based on the actual HuC firmware size, so that GuC/HuC loading failure would occur even if there was enough WOPCM space for both GuC and HuC firmware.
This patch enables the dynamic calculation of the GuC WOPCM aperture size used by GuC and HuC firmware. GuC WOPCM offset is set to HuC size + reserved WOPCM size. GuC WOPCM size is set to total WOPCM size - GuC WOPCM offset - RC6CTX size. In this case, GuC WOPCM offset will be updated based on the size of HuC firmware while GuC WOPCM size will be set to use all the remaining WOPCM space.
v2:
- Removed intel_wopcm_init (Ville/Sagar/Joonas)
- Renamed and Moved the intel_wopcm_partition into intel_guc (Sagar)
- Removed unnecessary function calls (Joonas)
- Init GuC WOPCM partition as soon as firmware fetching is completed
v3:
- Fixed indentation issues (Chris)
- Removed layering violation code (Chris/Michal)
- Created separat files for GuC wopcm code (Michal)
- Used inline function to avoid code duplication (Michal)
v4:
- Preset the GuC WOPCM top during early GuC init (Chris)
- Fail intel_uc_init_hw() as soon as GuC WOPCM partitioning failed
v5:
- Moved GuC DMA WOPCM register updating code into intel_guc_wopcm.c
- Took care of the locking status before writing to GuC DMA Write-Once registers. (Joonas)
--- drivers/gpu/drm/i915/i915_gem_context.c | 9 +-- drivers/gpu/drm/i915/intel_guc.c | 5 +- drivers/gpu/drm/i915/intel_guc.h | 12 ++-- drivers/gpu/drm/i915/intel_guc_wopcm.c | 105 +++++++++++++++++++++++++++++--- drivers/gpu/drm/i915/intel_guc_wopcm.h | 40 ++++++++++-- drivers/gpu/drm/i915/intel_huc.c | 2 +- drivers/gpu/drm/i915/intel_uc.c | 11 +++- drivers/gpu/drm/i915/intel_uc_fw.c | 11 +++- drivers/gpu/drm/i915/intel_uc_fw.h | 16 +++++ 9 files changed, 179 insertions(+), 32 deletions(-)
drivers/gpu/drm/i915/i915_gem_context.c +5 -4
@@ -312,12 +312,13 @@ __create_hw_context(struct drm_i915_private *dev_priv, ctx->desc_template =default_desc_template (dev_priv, dev_priv->mm.aliasing_ppgtt); -/* GuC requires the ring to be placed above GUC_WOPCM_TOP. If GuC is not -* present or not in use we still need a small bias as ring wraparound -* at offset 0 sometimes hangs. No idea why. +/* +* GuC requires the ring to be placed above GuC WOPCM top. If GuC is not +- * present or not in use we still need a small bias as ring wraparound +- * at offset 0 sometimes hangs. No idea why. */ if (USES_GUC (dev_priv)) - ctx->ggtt_offset_bias =GUC_WOPCM_TOP ; + ctx->ggtt_offset_bias = dev_priv->guc.wopcm.top;else ctx->ggtt_offset_bias =I915_GTT_PAGE_SIZE ;
drivers/gpu/drm/i915/intel_guc.c +3 -2
@@ -64,6 +64,7 @@ void intel_guc_init_early(struct intel_guc *guc) {intel_guc_fw_init_early (guc);intel_guc_ct_init_early (&guc->ct); +intel_guc_wopcm_init_early (&guc->wopcm);mutex_init (&guc->send_mutex); guc->send = intel_guc_send_nop;
@@ -465,7 +466,7 @@ int intel_guc_resume(struct drm_i915_private *dev_priv)* This is a wrapper to create an object for use with the GuC. In order to * use it inside the GuC, an object needs to be pinned lifetime, so we allocate * both some backing storage and a range inside the Global GTT. We must pin -* it in the GGTT somewhere other than than [0, GUC_WOPCM_TOP) because that +* it in the GGTT somewhere other than than [0, GuC WOPCM top) because that * range is reserved inside GuC. * * Return: A i915_vma if successful, otherwise an ERR_PTR.
@@ -486,7 +487,7 @@ struct i915_vma *intel_guc_allocate_vma(struct intel_guc *guc, u32 size) goto err; ret =i915_vma_pin (vma,0 ,PAGE_SIZE , -PIN_GLOBAL |PIN_OFFSET_BIAS |GUC_WOPCM_TOP ); +PIN_GLOBAL |PIN_OFFSET_BIAS | guc->wopcm.top);if (ret) { vma =ERR_PTR (ret); goto err;
drivers/gpu/drm/i915/intel_guc.h +7 -5
@@ -49,6 +49,7 @@ struct intel_guc {struct intel_uc_fw fw;struct intel_guc_log log;struct intel_guc_ct ct; +struct intel_guc_wopcm wopcm;/* Log snapshot if GuC errors during load */ struct drm_i915_gem_object *load_err_log;
@@ -105,10 +106,10 @@ static inline void intel_guc_notify(struct intel_guc *guc)* @guc: intel guc. * @vma: i915 graphics virtual memory area. * -* GuC does not allow any gfx GGTT address that falls into range [0, WOPCM_TOP), -* which is reserved for Boot ROM, SRAM and WOPCM. Currently this top address is -* 512K. In order to exclude 0-512K address space from GGTT, all gfx objects -* used by GuC is pinned with PIN_OFFSET_BIAS along with size of WOPCM. +* GuC does not allow any gfx GGTT address that falls into range +* [0, GuC WOPCM top), which is reserved for Boot ROM, SRAM and WOPCM. +* All gfx objects used by GuC is pinned with PIN_OFFSET_BIAS along with +* top of WOPCM. * * Return: GGTT offset that meets the GuC gfx address requirement. */
@@ -117,7 +118,8 @@ static inline u32 intel_guc_ggtt_offset(struct intel_guc *guc, {u32 offset =i915_ggtt_offset (vma); -GEM_BUG_ON (offset <GUC_WOPCM_TOP ); +GEM_BUG_ON (!guc->wopcm.valid); +GEM_BUG_ON (offset < guc->wopcm.top);GEM_BUG_ON (range_overflows_t (u64, offset, vma->size,GUC_GGTT_TOP ));return offset;
drivers/gpu/drm/i915/intel_guc_wopcm.c +95 -10
118 lines not on this page · raw message
drivers/gpu/drm/i915/intel_guc_wopcm.h +35 -5
@@ -29,11 +29,41 @@struct intel_guc ; -#define GUC_WOPCM_OFFSET_VALUE 0x80000/* 512KB */ -/* GuC addresses below GUC_WOPCM_TOP don't map through the GTT */ -#define GUC_WOPCM_TOP (0x80 << 12)/* 512KB */ -#define BXT_GUC_WOPCM_RC6_RESERVED (0x10 << 12)/* 64KB */ +/* Default WOPCM size 1MB */ +#define WOPCM_DEFAULT_SIZE (0x1 << 20) +/* Reserved WOPCM size 16KB */ +#define WOPCM_RESERVED_SIZE (0x4000) +/* GUC WOPCM Offset need to be 16KB aligned */ +#define WOPCM_OFFSET_ALIGNMENT (0x4000) +/* 8KB stack reserved for GuC FW*/ +#define GUC_WOPCM_STACK_RESERVED (0x2000) +/* 24KB WOPCM reserved for RC6 CTX on BXT */ +#define BXT_WOPCM_RC6_RESERVED (0x6000) -u32 intel_guc_wopcm_size (struct intel_guc *guc); +#define GEN9_GUC_WOPCM_DELTA 4 +#define GEN9_GUC_WOPCM_OFFSET (0x24000) + +struct intel_guc_wopcm { +u32 offset; +u32 size; +u32 top; +bool valid; +}; + +/* +* intel_guc_wopcm_init_early() - Early initialization of the GuC WOPCM. +* @wopcm: GuC WOPCM. +* +* Setup the GuC WOPCM top to the top of the overall WOPCM. This will guarantee +* that the allocation of the GuC accessible objects won't fall into WOPCM when +* GuC partition isn't present. +* +*/ +static inline void intel_guc_wopcm_init_early (struct intel_guc_wopcm *wopcm) +{ + wopcm->top =WOPCM_DEFAULT_SIZE ; +} + +int intel_guc_wopcm_init (struct intel_guc *guc,u32 guc_size,u32 huc_size);#endif
drivers/gpu/drm/i915/intel_huc.c +1 -1
@@ -206,7 +206,7 @@ int intel_huc_auth(struct intel_huc *huc)return -ENOEXEC ; vma =i915_gem_object_ggtt_pin (huc->fw.obj,NULL ,0 ,0 , -PIN_OFFSET_BIAS |GUC_WOPCM_TOP ); +PIN_OFFSET_BIAS | guc->wopcm.top);if (IS_ERR (vma)) { ret =PTR_ERR (vma);DRM_ERROR ("HuC: Failed to pin huc fw object %d\n" , ret);
drivers/gpu/drm/i915/intel_uc.c +9 -2
@@ -217,6 +217,9 @@ void intel_uc_fini_wq(struct drm_i915_private *dev_priv)int intel_uc_init (struct drm_i915_private *dev_priv) {struct intel_guc *guc = &dev_priv->guc; +struct intel_huc *huc = &dev_priv->huc; +u32 guc_fw_size =intel_uc_fw_get_size (&guc->fw); +u32 huc_fw_size =intel_uc_fw_get_size (&huc->fw);int ret;if (!USES_GUC (dev_priv))
@@ -225,6 +228,10 @@ int intel_uc_init(struct drm_i915_private *dev_priv)if (!HAS_GUC (dev_priv))return -ENODEV ; + ret =intel_guc_wopcm_init (guc, guc_fw_size, huc_fw_size); +if (ret) +return ret; + ret =intel_guc_init (guc);if (ret)return ret;
@@ -274,9 +281,9 @@ int intel_uc_init_hw(struct drm_i915_private *dev_priv)gen9_reset_guc_interrupts (dev_priv);/* init WOPCM */ -I915_WRITE (GUC_WOPCM_SIZE ,intel_guc_wopcm_size (guc)); +I915_WRITE (GUC_WOPCM_SIZE , guc->wopcm.size);I915_WRITE (DMA_GUC_WOPCM_OFFSET , -GUC_WOPCM_OFFSET_VALUE |HUC_LOADING_AGENT_GUC ); + guc->wopcm.offset |HUC_LOADING_AGENT_GUC );/* WaEnableuKernelHeaderValidFix:skl */ /* WaEnableGuCBootHashCheckNotSet:skl,bxt,kbl */
drivers/gpu/drm/i915/intel_uc_fw.c +8 -3
@@ -95,9 +95,13 @@ void intel_uc_fw_fetch(struct drm_i915_private *dev_priv, uc_fw->ucode_offset = uc_fw->header_offset + uc_fw->header_size; uc_fw->ucode_size = (css->size_dw - css->header_size_dw) *sizeof (u32); -/* Header and uCode will be loaded to WOPCM */ +/* +* Header and uCode will be loaded to WOPCM +* Only check the size against the overall available WOPCM here. Will +* continue to check the size during WOPCM partition calculation. +*/ size = uc_fw->header_size + uc_fw->ucode_size; -if (size >intel_guc_wopcm_size (&dev_priv->guc)) { +if (size >WOPCM_DEFAULT_SIZE ) {DRM_WARN ("%s: Firmware is too large to fit in WOPCM\n" ,intel_uc_fw_type_repr (uc_fw->type)); err = -E2BIG ;
@@ -207,6 +211,7 @@ int intel_uc_fw_upload(struct intel_uc_fw *uc_fw,int (*xfer)(struct intel_uc_fw *uc_fw, struct i915_vma *vma)) { +struct drm_i915_private *i915 =to_i915 (uc_fw->obj->base.dev);struct i915_vma *vma;int err;
@@ -230,7 +235,7 @@ int intel_uc_fw_upload(struct intel_uc_fw *uc_fw, } vma =i915_gem_object_ggtt_pin (uc_fw->obj,NULL ,0 ,0 , -PIN_OFFSET_BIAS |GUC_WOPCM_TOP ); +PIN_OFFSET_BIAS | i915->guc.wopcm.top);if (IS_ERR (vma)) { err =PTR_ERR (vma); DRM_DEBUG_DRIVER("%s fw ggtt-pin err=%d\n",
drivers/gpu/drm/i915/intel_uc_fw.h +16 -0
@@ -115,6 +115,22 @@ static inline bool intel_uc_fw_is_selected(struct intel_uc_fw *uc_fw)return uc_fw->path !=NULL ; } +/* +* intel_uc_fw_get_size() - Get the size of the firmware. +* @uc_fw: intel_uc_fw structure. +* +* Get the size of the firmware that will be placed in WOPCM. +* +* Return: Zero on invalid firmware status. actual size on success. +*/ +static inline u32 intel_uc_fw_get_size (struct intel_uc_fw *uc_fw) +{ +if (uc_fw->fetch_status !=INTEL_UC_FIRMWARE_SUCCESS ) +return 0 ; + +return uc_fw->header_size + uc_fw->ucode_size; +} +void intel_uc_fw_fetch (struct drm_i915_private *dev_priv,struct intel_uc_fw *uc_fw); int intel_uc_fw_upload(struct intel_uc_fw *uc_fw,
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v5 4/6 drm/i915/guc: Add WOPCM partitioning support for CNL
In reply to Jackie LiCNL has different WOPCM size and hardware restriction on GuC WOPCM size.
This patch returns the correct WOPCM reserved size on CNL and adds the GuC WOPCM size check for CNL.
--- drivers/gpu/drm/i915/intel_guc_wopcm.c | 21 +++++++++++++++++++++ drivers/gpu/drm/i915/intel_guc_wopcm.h | 3 +++ 2 files changed, 24 insertions(+)
drivers/gpu/drm/i915/intel_guc_wopcm.c +21 -0
@@ -33,6 +33,9 @@ static inline u32 guc_reserved_wopcm_size(struct intel_guc *guc)if (IS_GEN9_LP (i915))return BXT_WOPCM_RC6_RESERVED ; +if (IS_GEN10 (i915)) +return CNL_WOPCM_RESERVED ; +return 0 ; }
@@ -58,6 +61,21 @@ static inline int gen9_wocpm_size_check(struct drm_i915_private *i915)return 0 ; } +static inline int cnl_a0_wopcm_size_check (struct drm_i915_private *i915) +{ +struct intel_guc_wopcm *wopcm = &i915->guc.wopcm; +u32 huc_size =intel_uc_fw_get_size (&i915->huc.fw); + +/* +* On CNL A0, hardware requires guc size to be larger than or equal to +* HuC kernel size. +*/ +if (unlikely (wopcm->size -GEN10_GUC_WOPCM_OFFSET < huc_size)) +return -E2BIG ; + +return 0 ; +} +static inline int guc_wopcm_size_check (struct intel_guc *guc) {struct drm_i915_private *i915 =guc_to_i915 (guc);
@@ -65,6 +83,9 @@ static inline int guc_wopcm_size_check(struct intel_guc *guc)if (IS_GEN9 (i915))return gen9_wocpm_size_check (i915); +if (IS_CNL_REVID (i915,CNL_REVID_A0 ,CNL_REVID_A0 )) +return cnl_a0_wopcm_size_check (i915); +return 0 ; }
drivers/gpu/drm/i915/intel_guc_wopcm.h +3 -0
@@ -39,9 +39,12 @@ struct intel_guc;#define GUC_WOPCM_STACK_RESERVED (0x2000)/* 24KB WOPCM reserved for RC6 CTX on BXT */ #define BXT_WOPCM_RC6_RESERVED (0x6000) +/* 36KB WOPCM reserved on CNL */ +#define CNL_WOPCM_RESERVED (0x9000)#define GEN9_GUC_WOPCM_DELTA 4#define GEN9_GUC_WOPCM_OFFSET (0x24000) +#define GEN10_GUC_WOPCM_OFFSET (0x4000)struct intel_guc_wopcm {u32 offset;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v5 5/6 drm/i915/guc: Check the locking status of GuC WOPCM registers
In reply to Jackie LiGuC WOPCM registers are write-once registers. Current driver code accesses these registers without checking the accessibility to these registers, this will lead unpredictable driver behaviors if these registers were touch by other components (such as faulty BIOS code).
This patch moves the GuC WOPCM register updating operations into intel_guc_wopcm.c and adds checks before and after the write to GuC WOPCM registers to make sure the driver is in a known state before and after writing to these write-once registers.
--- drivers/gpu/drm/i915/intel_guc.h | 2 +- drivers/gpu/drm/i915/intel_guc_reg.h | 1 + drivers/gpu/drm/i915/intel_guc_wopcm.c | 66 ++++++++++++++++++++++++++++++++-- drivers/gpu/drm/i915/intel_guc_wopcm.h | 14 +++++++- drivers/gpu/drm/i915/intel_uc.c | 5 +-- 5 files changed, 79 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/intel_guc.h +1 -1
@@ -118,7 +118,7 @@ static inline u32 intel_guc_ggtt_offset(struct intel_guc *guc, {u32 offset =i915_ggtt_offset (vma); -GEM_BUG_ON (!guc->wopcm.valid); +GEM_BUG_ON (!(guc->wopcm.flags &INTEL_GUC_WOPCM_VALID ));GEM_BUG_ON (offset < guc->wopcm.top);GEM_BUG_ON (range_overflows_t (u64, offset, vma->size,GUC_GGTT_TOP ));
drivers/gpu/drm/i915/intel_guc_reg.h +1 -0
@@ -75,6 +75,7 @@/* Defines WOPCM space available to GuC firmware */ #define GUC_WOPCM_SIZE _MMIO(0xc050) +#define GUC_WOPCM_REG_LOCKED (1<<0)/* GuC addresses above GUC_GGTT_TOP also don't map through the GTT */ #define GUC_GGTT_TOP 0xFEE00000
drivers/gpu/drm/i915/intel_guc_wopcm.c +63 -3
87 lines not on this page · raw message
drivers/gpu/drm/i915/intel_guc_wopcm.h +13 -1
@@ -46,11 +46,22 @@ struct intel_guc;#define GEN9_GUC_WOPCM_OFFSET (0x24000)#define GEN10_GUC_WOPCM_OFFSET (0x4000) +/* GuC WOPCM flags*/ +#define INTEL_GUC_WOPCM_VALID BIT(0) +#define INTEL_GUC_WOPCM_HW_UPDATED BIT(1) + +/* +* intel_guc_wopcm - GuC WOPCM related settings. +* @offset: GuC WOPCM offset. +* @size: size of GuC WOPCM for GuC firmware. +* @top: start of Non GuC WOPCM memory. +* @flags: bitmap of INTEL_GUC_WOPCM_<foo>. +*/ struct intel_guc_wopcm {u32 offset;u32 size;u32 top; -bool valid; +u32 flags; };/*
@@ -68,5 +79,6 @@ static inline void intel_guc_wopcm_init_early(struct intel_guc_wopcm *wopcm) }int intel_guc_wopcm_init (struct intel_guc *guc,u32 guc_size,u32 huc_size); +void intel_guc_wopcm_init_hw (struct intel_guc *guc);#endif
drivers/gpu/drm/i915/intel_uc.c +1 -4
@@ -280,10 +280,7 @@ int intel_uc_init_hw(struct drm_i915_private *dev_priv)guc_disable_communication (guc);gen9_reset_guc_interrupts (dev_priv); -/* init WOPCM */ -I915_WRITE (GUC_WOPCM_SIZE , guc->wopcm.size); -I915_WRITE (DMA_GUC_WOPCM_OFFSET , - guc->wopcm.offset |HUC_LOADING_AGENT_GUC ); +intel_guc_wopcm_init_hw (guc);/* WaEnableuKernelHeaderValidFix:skl */ /* WaEnableGuCBootHashCheckNotSet:skl,bxt,kbl */
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v5 6/6 HAX Enable GuC Submission for CI
In reply to Jackie Li--- drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++-- drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/i915_params.h | 2 +- drivers/gpu/drm/i915/intel_guc_wopcm.c | 6 ++++++ 4 files changed, 10 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/i915_gem_gtt.c +2 -2
@@ -3550,7 +3550,7 @@ int i915_ggtt_enable_hw(struct drm_i915_private *dev_priv)void i915_ggtt_enable_guc (struct drm_i915_private *i915) { -GEM_BUG_ON (i915->ggtt.invalidate != gen6_ggtt_invalidate); +// GEM_BUG_ON(i915->ggtt.invalidate != gen6_ggtt_invalidate); i915->ggtt.invalidate = guc_ggtt_invalidate;
@@ -3560,7 +3560,7 @@ void i915_ggtt_enable_guc(struct drm_i915_private *i915)void i915_ggtt_disable_guc (struct drm_i915_private *i915) {/* We should only be called after i915_ggtt_enable_guc() */ -GEM_BUG_ON (i915->ggtt.invalidate != guc_ggtt_invalidate); +// GEM_BUG_ON(i915->ggtt.invalidate != guc_ggtt_invalidate); i915->ggtt.invalidate = gen6_ggtt_invalidate;
drivers/gpu/drm/i915/i915_params.c +1 -1
@@ -152,7 +152,7 @@ i915_param_named_unsafe(edp_vswing, int, 0400,i915_param_named_unsafe (enable_guc, int,0400 ,"Enable GuC load for GuC submission and/or HuC load. " "Required functionality can be selected using bitmask values. " -"(-1=auto, 0=disable [default], 1=GuC submission, 2=HuC load)" ); +"(-1=auto [default], 0=disable, 1=GuC submission, 2=HuC load)" );i915_param_named (guc_log_level, int,0400 ,"GuC firmware logging level (-1:disabled (default), 0-3:enabled)" );
drivers/gpu/drm/i915/i915_params.h +1 -1
@@ -47,7 +47,7 @@ struct drm_printer; param(int, disable_power_well, -1) \ param(int, enable_ips, 1) \ param(int, invert_brightness, 0) \ - param(int, enable_guc, 0) \ + param(int, enable_guc, -1) \ param(int, guc_log_level, -1) \ param(char *, guc_firmware_path, NULL) \param (char *, huc_firmware_path, NULL) \
drivers/gpu/drm/i915/intel_guc_wopcm.c +6 -0
@@ -138,6 +138,9 @@ int intel_guc_wopcm_init(struct intel_guc *guc, u32 guc_fw_size,u32 offset, size, top;int err; +DRM_DEBUG_DRIVER ("guc_fw size %u, huc_fw_size %u\n" , guc_fw_size, + huc_fw_size); +GEM_BUG_ON (guc->wopcm.flags &INTEL_GUC_WOPCM_VALID );if (!guc_fw_size)
@@ -194,6 +197,9 @@ void intel_guc_wopcm_init_hw(struct intel_guc *guc) {u32 locked =guc_wopcm_locked (guc); +DRM_DEBUG_DRIVER ("locked = %s, flags = %#x\n" ,yesno (locked), + guc->wopcm.flags); +GEM_BUG_ON (!(guc->wopcm.flags &INTEL_GUC_WOPCM_VALID ));/*
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for series starting with [v5,1/6] drm/i915/guc: Move GuC WOPCM related code into separate files
In reply to Jackie Li== Series Details ==
== Series Details ==
Series: series starting with [v5,1/6] drm/i915/guc: Move GuC WOPCM related code into separate files
URL : https://patchwork.freedesktop.org/series/36158/
State : failure
== Summary ==
Series 36158v1 series starting with [v5,1/6] drm/i915/guc: Move GuC WOPCM related code into separate files
https://patchwork.freedesktop.org/api/1.0/series/36158/revisions/1/mbox/
Test debugfs_test:
Subgroup read_all_entries:
dmesg-warn -> FAIL (fi-elk-e7500) fdo#103989 +1
incomplete -> PASS (fi-snb-2520m) fdo#103713
Test drv_module_reload:
Subgroup basic-reload:
pass -> DMESG-FAIL (fi-skl-6260u)
pass -> DMESG-FAIL (fi-skl-6600u)
pass -> DMESG-FAIL (fi-skl-6700hq)
pass -> DMESG-FAIL (fi-skl-6700k2)
pass -> DMESG-FAIL (fi-skl-6770hq)
pass -> DMESG-FAIL (fi-bxt-dsi)
pass -> DMESG-FAIL (fi-bxt-j4205)
pass -> DMESG-FAIL (fi-kbl-7500u)
pass -> DMESG-FAIL (fi-kbl-7560u)
pass -> DMESG-FAIL (fi-kbl-7567u)
pass -> DMESG-FAIL (fi-kbl-r)
Subgroup basic-no-display:
pass -> FAIL (fi-skl-6260u)
pass -> FAIL (fi-skl-6600u)
pass -> FAIL (fi-skl-6700hq)
pass -> FAIL (fi-skl-6700k2)
pass -> FAIL (fi-skl-6770hq)
pass -> FAIL (fi-bxt-dsi)
pass -> FAIL (fi-bxt-j4205)
pass -> FAIL (fi-kbl-7500u)
pass -> FAIL (fi-kbl-7560u)
pass -> FAIL (fi-kbl-7567u)
pass -> FAIL (fi-kbl-r)
Subgroup basic-reload-inject:
pass -> INCOMPLETE (fi-skl-6260u)
pass -> INCOMPLETE (fi-skl-6600u)
pass -> INCOMPLETE (fi-skl-6700hq)
pass -> INCOMPLETE (fi-skl-6700k2)
pass -> INCOMPLETE (fi-skl-6770hq)
pass -> INCOMPLETE (fi-bxt-dsi)
pass -> INCOMPLETE (fi-bxt-j4205)
pass -> INCOMPLETE (fi-kbl-7500u)
pass -> INCOMPLETE (fi-kbl-7560u)
pass -> INCOMPLETE (fi-kbl-7567u)
pass -> INCOMPLETE (fi-kbl-r)fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:419s fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:372s fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:485s fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:279s fi-bxt-dsi total:287 pass:255 dwarn:0 dfail:1 fail:1 skip:29 fi-bxt-j4205 total:287 pass:256 dwarn:0 dfail:1 fail:1 skip:28 fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:467s fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:461s fi-elk-e7500 total:224 pass:167 dwarn:10 dfail:0 fail:1 skip:45 fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:276s fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:508s fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:390s fi-hsw-4770r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:399s fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:411s fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:447s fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:411s fi-kbl-7500u total:287 pass:260 dwarn:1 dfail:1 fail:1 skip:23 fi-kbl-7560u total:287 pass:266 dwarn:0 dfail:1 fail:1 skip:18 fi-kbl-7567u total:287 pass:265 dwarn:0 dfail:1 fail:1 skip:19 fi-kbl-r total:287 pass:257 dwarn:1 dfail:1 fail:1 skip:26 fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:583s fi-skl-6260u total:287 pass:265 dwarn:0 dfail:1 fail:1 skip:19 fi-skl-6600u total:287 pass:258 dwarn:0 dfail:1 fail:1 skip:26 fi-skl-6700hq total:287 pass:259 dwarn:0 dfail:1 fail:1 skip:25 fi-skl-6700k2 total:287 pass:261 dwarn:0 dfail:1 fail:1 skip:23 fi-skl-6770hq total:287 pass:265 dwarn:0 dfail:1 fail:1 skip:19 fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:519s fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:398s Blacklisted hosts: fi-cfl-s2 total:287 pass:259 dwarn:0 dfail:1 fail:1 skip:25 fi-cnl-y total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:611s fi-glk-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:470s
70afdd6e5dfe93544afc231645c09084ec508b01 drm-tip: 2018y-01m-08d-13h-41m-31s UTC integration manifest a59565e1d2ca HAX Enable GuC Submission for CI7d43f257c213 drm/i915/guc: Check the locking status of GuC WOPCM registers 965b466e9fad drm/i915/guc: Add WOPCM partitioning support for CNLc7a3c9b9eb96 drm/i915/guc: Implement dynamic GuC WOPCM offset and size58746b8d86bc drm/i915/guc: Rename guc_ggtt_offset to intel_guc_ggtt_offset 3ee361050487 drm/i915/guc: Move GuC WOPCM related code into separate files
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7625/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx