USB TYPEC: RT1711H Type-C Chip Driver

PATCH In review shufan_lee(李書帆) 2 participants 5 messages Jan 9, 2018 – Jan 10, 2018

Subsystems (4)

Device tree bindings USB USB Type-C class Arm/HiSilicon SoC support

lore

Share & tools

lore

shufan_lee(李書帆)

author

2018-01-09 03:23 UTC #0 lore raw

PATCH 1/1 USB TYPEC: RT1711H Type-C Chip Driver

From: ShuFan Lee <[email protected]>

Richtek RT1711H Type-C chip driver that works with Type-C Port Controller Manager to provide USB PD and USB Type-C functionalities.

Signed-off-by ShuFan Lee <[email protected]>

---

Documentation/devicetree/bindings/usb/richtek,rt1711h.txt |   38
arch/arm64/boot/dts/hisilicon/rt1711h.dtsi                |   11
drivers/usb/typec/Kconfig                                 |    2
drivers/usb/typec/Makefile                                |    1
drivers/usb/typec/rt1711h/Kconfig                         |    7
drivers/usb/typec/rt1711h/Makefile                        |    2
drivers/usb/typec/rt1711h/rt1711h.c                       | 2241 ++++++++++
drivers/usb/typec/rt1711h/rt1711h.h                       |  300 +
8 files changed, 2602 insertions(+)

Documentation/devicetree/bindings/usb/richtek,rt1711h.txt new file +38 -0

new file mode 100644
index 0000000..c28299c
@@ -0,0 +1,38 @@
+Richtek RT1711H Type-C Port Controller.
+
+Required properties:
+- compatible : Must be "richtek,typec_rt1711h";
+- reg : Must be 0x4e, it's default slave address of RT1711H.
+- rt,intr_gpio : IRQ GPIO pin that's connected to RT1711H interrupt.
+
+Optional node:
+- rt,name : Name used for registering IRQ and creating kthread.
+    If this property is not specified, "default" will be applied.
+- rt,def_role : Default port role (TYPEC_SINK(0) or TYPEC_SOURCE(1)).
+Set to TYPEC_NO_PREFERRED_ROLE(-1) if no default role.
+If this property is not specified, TYPEC_SINK will be applied.
+- rt,port_type : Port type (TYPEC_PORT_DFP(0), TYPEC_PORT_UFP(1),
+ or TYPEC_PORT_DRP(2)). If this property is not specified,
+ TYPEC_PORT_DRP will be applied.
+- rt,max_snk_mv : Maximum acceptable sink voltage in mV.
+  If this property is not specified, 5000mV will be applied.
+- rt,max_snk_ma : Maximum sink current in mA.
+  If this property is not specified, 3000mA will be applied.
+- rt,max_snk_mw : Maximum required sink power in mW.
+  If this property is not specified, 15000mW will be applied.
+- rt,operating_snk_mw : Required operating sink power in mW.
+If this property is not specified,
+2500mW will be applied.
+- rt,try_role_hw : True if try.{Src,Snk} is implemented in hardware.
+   If this property is not specified, False will be applied.
+
+Example:
+rt1711h@4e {
+status = "ok";
+compatible = "richtek,typec_rt1711h";
+reg = <0x4e>;
+rt,intr_gpio = <&gpio26 0 0x0>;
+rt,name = "rt1711h";
+rt,port_type = <2>; /* 0: DFP, 1: UFP, 2: DRP */
+rt,def_role = <0>; /* 0: SNK, 1: SRC, -1: TYPEC_NO_PREFERRED_ROLE */
+};

arch/arm64/boot/dts/hisilicon/rt1711h.dtsi new file +11 -0

new file mode 100644
index 0000000..4196cc0
@@ -0,0 +1,11 @@
+&i2c7 {
+rt1711h@4e {
+status = "ok";
+compatible = "richtek,typec_rt1711h";
+reg = <0x4e>;
+rt,intr_gpio = <&gpio26 0 0x0>;
+rt,name = "rt1711h";
+rt,port_type = <2>; /* 0: DFP, 1: UFP, 2: DRP */
+rt,def_role = <0>; /* 0: SNK, 1: SRC */
+};
+};

drivers/usb/typec/Kconfig +2 -0

index bcb2744..7bede0b 100644
@@ -56,6 +56,8 @@ if TYPEC_TCPM
 
 source "drivers/usb/typec/fusb302/Kconfig"
 
+source "drivers/usb/typec/rt1711h/Kconfig"
+
 config TYPEC_WCOVE
 tristate "Intel WhiskeyCove PMIC USB Type-C PHY driver"
 depends on ACPI

drivers/usb/typec/Makefile +1 -0

index bb3138a..e3aaf3c 100644
@@ -2,6 +2,7 @@
 obj-$(CONFIG_TYPEC)+= typec.o
 obj-$(CONFIG_TYPEC_TCPM)+= tcpm.o
 obj-y+= fusb302/
+obj-$(CONFIG_TYPEC_RT1711H)+= rt1711h/
 obj-$(CONFIG_TYPEC_WCOVE)+= typec_wcove.o
 obj-$(CONFIG_TYPEC_UCSI)+= ucsi/
 obj-$(CONFIG_TYPEC_TPS6598X)+= tps6598x.o

drivers/usb/typec/rt1711h/Kconfig new file +7 -0

new file mode 100644
index 0000000..2fbfff5
@@ -0,0 +1,7 @@
+config TYPEC_RT1711H
+tristate "Richtek RT1711H Type-C chip driver"
+depends on I2C && POWER_SUPPLY
+help
+  The Richtek RT1711H   Type-C chip driver that works with
+  Type-C Port Controller Manager to provide USB PD and USB
+  Type-C functionalities.

drivers/usb/typec/rt1711h/Makefile new file +2 -0

new file mode 100644
index 0000000..5fab8ae
@@ -0,0 +1,2 @@
+# SPDX-License-Identifier: GPL-2.0
+obj-$(CONFIG_TYPEC_RT1711H)+= rt1711h.o

drivers/usb/typec/rt1711h/rt1711h.c new file +2241 -0

2,241 lines not on this page · raw message

drivers/usb/typec/rt1711h/rt1711h.h new file +300 -0

300 lines not on this page · raw message

Best Regards,
*****************************************
Shu-Fan Lee
Richtek Technology Corporation
TEL: +886-3-5526789 #2359
FAX: +886-3-5526612
*****************************************
************* Email Confidentiality Notice ********************

The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you!

Randy Dunlap

2018-01-09 06:19 UTC #1 lore raw

Quoted 9 lines · shufan_lee(李書帆)

From: ShuFan Lee <[email protected]>
Richtek RT1711H Type-C chip driver that works with Type-C Port Controller Manager to provide USB PD and USB Type-C functionalities.
Signed-off-by ShuFan Lee <[email protected]>
---

Quoted 9 lines

Documentation/devicetree/bindings/usb/richtek,rt1711h.txt |   38
arch/arm64/boot/dts/hisilicon/rt1711h.dtsi                |   11
drivers/usb/typec/Kconfig                                 |    2
drivers/usb/typec/Makefile                                |    1
drivers/usb/typec/rt1711h/Kconfig                         |    7
drivers/usb/typec/rt1711h/Makefile                        |    2
drivers/usb/typec/rt1711h/rt1711h.c                       | 2241 ++++++++++
drivers/usb/typec/rt1711h/rt1711h.h                       |  300 +
8 files changed, 2602 insertions(+)

Hi,
It looks like your mail client or your mail server (or something else) ate all of the tabs that would make this patch look normal.

When you have that fixed, I guess that you should also Cc: the linux-usb mailing list with the patch.

Thanks.

Quoted 4 lines

************* Email Confidentiality Notice ********************
The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you!

Signature · 1 line

~Randy

shufan_lee(李書帆)

author

2018-01-09 08:46 UTC #2 lore raw

Hi Randy,

I've checked the email and tabs are still there.

Would your mind providing an example of what you see and highlight the incorrect format?

Thank you!

Best Regards,
*****************************
Shu-Fan Lee
Richtek Technology Corporation
TEL: +886-3-5526789 #2359
FAX: +886-3-5526612
*****************************

-----Original Message-----
From: Randy Dunlap [mailto:[email protected]]
Sent: Tuesday, January 09, 2018 2:19 PM
To: shufan_lee(李書帆); [email protected]
Cc: [email protected]; cy_huang(黃啟原)
Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

Quoted 7 lines · shufan_lee(李書帆)

From: ShuFan Lee <[email protected]>
Richtek RT1711H Type-C chip driver that works with Type-C Port Controller Manager to provide USB PD and USB Type-C functionalities.
Signed-off-by ShuFan Lee <[email protected]> ---

Quoted 9 lines

Documentation/devicetree/bindings/usb/richtek,rt1711h.txt |   38
arch/arm64/boot/dts/hisilicon/rt1711h.dtsi                |   11
drivers/usb/typec/Kconfig                                 |    2
drivers/usb/typec/Makefile                                |    1
drivers/usb/typec/rt1711h/Kconfig                         |    7
drivers/usb/typec/rt1711h/Makefile                        |    2
drivers/usb/typec/rt1711h/rt1711h.c                       | 2241 ++++++++++
drivers/usb/typec/rt1711h/rt1711h.h                       |  300 +
8 files changed, 2602 insertions(+)

Hi,
It looks like your mail client or your mail server (or something else) ate all of the tabs that would make this patch look normal.

When you have that fixed, I guess that you should also Cc: the linux-usb mailing list with the patch.

Thanks.

Quoted 4 lines

************* Email Confidentiality Notice ********************
The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you!

--
~Randy
************* Email Confidentiality Notice ********************

Randy Dunlap

2018-01-09 17:26 UTC #3 lore raw

Quoted 9 lines · shufan_lee(李書帆)

Hi Randy,
I've checked the email and tabs are still there.
Would your mind providing an example of what you see and highlight the incorrect format?
Thank you!
Best Regards,

Please see your message in the email archive at:
https://marc.info/?l=linux-kernel&m=151546820509868&w=2

Is that how it was supposed to be formatted?

Thanks.

Quoted 51 lines

*****************************
Shu-Fan Lee
Richtek Technology Corporation
TEL: +886-3-5526789 #2359
FAX: +886-3-5526612
*****************************
-----Original Message-----
From: Randy Dunlap [mailto:[email protected]]
Sent: Tuesday, January 09, 2018 2:19 PM
To: shufan_lee(李書帆); [email protected]
Cc: [email protected]; cy_huang(黃啟原)
Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver
Quoted 7 lines · shufan_lee(李書帆)
From: ShuFan Lee <[email protected]>
Richtek RT1711H Type-C chip driver that works with Type-C Port Controller Manager to provide USB PD and USB Type-C functionalities.
Signed-off-by ShuFan Lee <[email protected]> ---
Quoted 9 lines
Documentation/devicetree/bindings/usb/richtek,rt1711h.txt |   38
arch/arm64/boot/dts/hisilicon/rt1711h.dtsi                |   11
drivers/usb/typec/Kconfig                                 |    2
drivers/usb/typec/Makefile                                |    1
drivers/usb/typec/rt1711h/Kconfig                         |    7
drivers/usb/typec/rt1711h/Makefile                        |    2
drivers/usb/typec/rt1711h/rt1711h.c                       | 2241 ++++++++++
drivers/usb/typec/rt1711h/rt1711h.h                       |  300 +
8 files changed, 2602 insertions(+)
Hi,
It looks like your mail client or your mail server (or something else) ate all of the tabs that would make this patch look normal.
When you have that fixed, I guess that you should also Cc: the linux-usb mailing list with the patch.
Thanks.
Quoted 4 lines
************* Email Confidentiality Notice ********************
The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you!
--
~Randy
************* Email Confidentiality Notice ********************
The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you!

Signature · 1 line

~Randy

shufan_lee(李書帆)

author

2018-01-10 02:50 UTC #4 lore raw

Hi Randy,

It is different. It seems that format is changed after sending.

I'll try to fix that and send again, thank you!

Best Regards,
*****************************
Shu-Fan Lee
Richtek Technology Corporation
TEL: +886-3-5526789 #2359
FAX: +886-3-5526612
*****************************

-----Original Message-----
From: Randy Dunlap [mailto:[email protected]]
Sent: Wednesday, January 10, 2018 1:26 AM
To: shufan_lee(李書帆); [email protected]
Cc: [email protected]; cy_huang(黃啟原)
Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

Quoted 9 lines · shufan_lee(李書帆)

Hi Randy,
I've checked the email and tabs are still there.
Would your mind providing an example of what you see and highlight the incorrect format?
Thank you!
Best Regards,

Please see your message in the email archive at:
https://marc.info/?l=linux-kernel&m=151546820509868&w=2

Is that how it was supposed to be formatted?

Thanks.

Quoted 45 lines

*****************************
Shu-Fan Lee
Richtek Technology Corporation
TEL: +886-3-5526789 #2359
FAX: +886-3-5526612
*****************************
-----Original Message-----
From: Randy Dunlap [mailto:[email protected]]
Sent: Tuesday, January 09, 2018 2:19 PM
To: shufan_lee(李書帆); [email protected]
Cc: [email protected]; cy_huang(黃啟原)
Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver
Quoted 7 lines · shufan_lee(李書帆)
From: ShuFan Lee <[email protected]>
Richtek RT1711H Type-C chip driver that works with Type-C Port Controller Manager to provide USB PD and USB Type-C functionalities.
Signed-off-by ShuFan Lee <[email protected]> ---
Quoted 9 lines
Documentation/devicetree/bindings/usb/richtek,rt1711h.txt |   38
arch/arm64/boot/dts/hisilicon/rt1711h.dtsi                |   11
drivers/usb/typec/Kconfig                                 |    2
drivers/usb/typec/Makefile                                |    1
drivers/usb/typec/rt1711h/Kconfig                         |    7
drivers/usb/typec/rt1711h/Makefile                        |    2
drivers/usb/typec/rt1711h/rt1711h.c                       | 2241 ++++++++++
drivers/usb/typec/rt1711h/rt1711h.h                       |  300 +
8 files changed, 2602 insertions(+)
Hi,
It looks like your mail client or your mail server (or something else) ate all of the tabs that would make this patch look normal.
When you have that fixed, I guess that you should also Cc: the linux-usb mailing list with the patch.
Thanks.
Quoted 4 lines
************* Email Confidentiality Notice ********************
The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you!

Quoted 6 lines

--
~Randy
************* Email Confidentiality Notice ********************
The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you!

--
~Randy
************* Email Confidentiality Notice ********************