ASoC: Remove mfld dead code
Subsystems (3)
cover ASoC: Remove mfld dead code
Medfield machine was not compiling for long on mainline. Since no one complained, lets remove the dead code and associated codec.
Vinod Koul (2):
ASoC: Intel: remove mfld_machine
ASoC: sn95031: remove this code
sound/soc/codecs/Kconfig | 4 - sound/soc/codecs/Makefile | 1 - sound/soc/codecs/sn95031.c | 936 ---------------------------------- sound/soc/codecs/sn95031.h | 133 ----- sound/soc/intel/boards/Kconfig | 14 - sound/soc/intel/boards/mfld_machine.c | 430 ---------------- 6 files changed, 1518 deletions(-) delete mode 100644 sound/soc/codecs/sn95031.c delete mode 100644 sound/soc/codecs/sn95031.h delete mode 100644 sound/soc/intel/boards/mfld_machine.c
Signature · 1 line
2.7.4
PATCH 1/2 ASoC: Intel: remove mfld_machine
mfld_machine was not getting compiled due to missed Makefile changes. Since no one complained it is safe to assume that it is not being used, so remove it
--- sound/soc/intel/boards/Kconfig | 14 -- sound/soc/intel/boards/mfld_machine.c | 430 ---------------------------------- 2 files changed, 444 deletions(-) delete mode 100644 sound/soc/intel/boards/mfld_machine.c
sound/soc/intel/boards/Kconfig +0 -14
@@ -12,20 +12,6 @@ menuconfig SND_SOC_INTEL_MACH if SND_SOC_INTEL_MACH -if SND_SST_ATOM_HIFI2_PLATFORM_PCI - -config SND_MFLD_MACHINE - tristate "Medfield (Intel MID)" - depends on INTEL_SCU_IPC - select SND_SOC_SN95031 - help - This adds support for ASoC machine driver for Intel(R) MID Medfield platform - used as alsa device in audio substem in Intel(R) MID devices - Say Y if you have such a device. - If unsure select "N". - -endif ## SND_SST_ATOM_HIFI2_PLATFORM_PCI - if SND_SOC_INTEL_HASWELL config SND_SOC_INTEL_HASWELL_MACH
sound/soc/intel/boards/mfld_machine.c deleted +0 -430
430 lines not on this page · raw message
Signature · 1 line
2.7.4
Mark Brown
maintainerApplied "ASoC: Intel: remove mfld_machine" to the asoc tree
The patch
ASoC: Intel: remove mfld_machine
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
05f4434bc13030ca67f229b8defd37f12a05d1faMon Sep 17 00:00:00 2001
From: Vinod Koul <[email protected]>
Date: Wed, 10 Jan 2018 15:59:34 +0530
Subject: [PATCH] ASoC: Intel: remove mfld_machine
mfld_machine was not getting compiled due to missed Makefile changes. Since no one complained it is safe to assume that it is not being used, so remove it
--- sound/soc/intel/boards/Kconfig | 14 -- sound/soc/intel/boards/mfld_machine.c | 430 ---------------------------------- 2 files changed, 444 deletions(-) delete mode 100644 sound/soc/intel/boards/mfld_machine.c
sound/soc/intel/boards/Kconfig +0 -14
@@ -12,20 +12,6 @@ menuconfig SND_SOC_INTEL_MACH if SND_SOC_INTEL_MACH -if SND_SST_ATOM_HIFI2_PLATFORM_PCI - -config SND_MFLD_MACHINE - tristate "Medfield (Intel MID)" - depends on INTEL_SCU_IPC - select SND_SOC_SN95031 - help - This adds support for ASoC machine driver for Intel(R) MID Medfield platform - used as alsa device in audio substem in Intel(R) MID devices - Say Y if you have such a device. - If unsure select "N". - -endif ## SND_SST_ATOM_HIFI2_PLATFORM_PCI - if SND_SOC_INTEL_HASWELL config SND_SOC_INTEL_HASWELL_MACH
sound/soc/intel/boards/mfld_machine.c deleted +0 -430
430 lines not on this page · raw message
Signature · 1 line
2.15.1
PATCH 2/2 ASoC: sn95031: remove this code
In reply to Vinod KoulThis codec was used in MFLD systems in the PMIC chip, we no longer have users for this, so remove it
--- sound/soc/codecs/Kconfig | 4 - sound/soc/codecs/Makefile | 1 - sound/soc/codecs/sn95031.c | 936 --------------------------------------------- sound/soc/codecs/sn95031.h | 133 ------- 4 files changed, 1074 deletions(-) delete mode 100644 sound/soc/codecs/sn95031.c delete mode 100644 sound/soc/codecs/sn95031.h
sound/soc/codecs/Kconfig +0 -4
@@ -133,7 +133,6 @@ config SND_SOC_ALL_CODECS select SND_SOC_SGTL5000 if I2C select SND_SOC_SI476X if MFD_SI476X_CORE select SND_SOC_SIRF_AUDIO_CODEC - select SND_SOC_SN95031 if INTEL_SCU_IPC select SND_SOC_SPDIF select SND_SOC_SSM2518 if I2C select SND_SOC_SSM2602_SPI if SPI_MASTER
@@ -818,9 +817,6 @@ config SND_SOC_SIRF_AUDIO_CODEC tristate "SiRF SoC internal audio codec" select REGMAP_MMIO -config SND_SOC_SN95031 - tristate - config SND_SOC_SPDIF tristate "S/PDIF CODEC"
sound/soc/codecs/Makefile +0 -1
@@ -140,7 +140,6 @@ snd-soc-sigmadsp-i2c-objs := sigmadsp-i2c.o snd-soc-sigmadsp-regmap-objs := sigmadsp-regmap.o snd-soc-si476x-objs := si476x.o snd-soc-sirf-audio-codec-objs := sirf-audio-codec.o -snd-soc-sn95031-objs := sn95031.o snd-soc-spdif-tx-objs := spdif_transmitter.o snd-soc-spdif-rx-objs := spdif_receiver.o snd-soc-ssm2518-objs := ssm2518.o
sound/soc/codecs/sn95031.c deleted +0 -936
936 lines not on this page · raw message
sound/soc/codecs/sn95031.h deleted +0 -133
133 lines not on this page · raw message
Signature · 1 line
2.7.4
Mark Brown
maintainerApplied "ASoC: sn95031: remove this code" to the asoc tree
The patch
ASoC: sn95031: remove this code
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
987da3fe175933c28aab2293505c3597052ff0e2Mon Sep 17 00:00:00 2001
From: Vinod Koul <[email protected]>
Date: Wed, 10 Jan 2018 15:59:35 +0530
Subject: [PATCH] ASoC: sn95031: remove this code
This codec was used in MFLD systems in the PMIC chip, we no longer have users for this, so remove it
--- sound/soc/codecs/Kconfig | 4 - sound/soc/codecs/Makefile | 1 - sound/soc/codecs/sn95031.c | 936 --------------------------------------------- sound/soc/codecs/sn95031.h | 133 ------- 4 files changed, 1074 deletions(-) delete mode 100644 sound/soc/codecs/sn95031.c delete mode 100644 sound/soc/codecs/sn95031.h
sound/soc/codecs/Kconfig +0 -4
@@ -133,7 +133,6 @@ config SND_SOC_ALL_CODECS select SND_SOC_SGTL5000 if I2C select SND_SOC_SI476X if MFD_SI476X_CORE select SND_SOC_SIRF_AUDIO_CODEC - select SND_SOC_SN95031 if INTEL_SCU_IPC select SND_SOC_SPDIF select SND_SOC_SSM2518 if I2C select SND_SOC_SSM2602_SPI if SPI_MASTER
@@ -818,9 +817,6 @@ config SND_SOC_SIRF_AUDIO_CODEC tristate "SiRF SoC internal audio codec" select REGMAP_MMIO -config SND_SOC_SN95031 - tristate - config SND_SOC_SPDIF tristate "S/PDIF CODEC"
sound/soc/codecs/Makefile +0 -1
@@ -140,7 +140,6 @@ snd-soc-sigmadsp-i2c-objs := sigmadsp-i2c.o snd-soc-sigmadsp-regmap-objs := sigmadsp-regmap.o snd-soc-si476x-objs := si476x.o snd-soc-sirf-audio-codec-objs := sirf-audio-codec.o -snd-soc-sn95031-objs := sn95031.o snd-soc-spdif-tx-objs := spdif_transmitter.o snd-soc-spdif-rx-objs := spdif_receiver.o snd-soc-ssm2518-objs := ssm2518.o
sound/soc/codecs/sn95031.c deleted +0 -936
936 lines not on this page · raw message
sound/soc/codecs/sn95031.h deleted +0 -133
133 lines not on this page · raw message
Signature · 1 line
2.15.1
Quoted 2 lines · Vinod Koul
Medfield machine was not compiling for long on mainline. Since no one complained, lets remove the dead code and associated codec.
While this change seems okay per se, please keep in mind that Intel Merrifield would be still in use (yes, we have no confirmation right now about the status of the driver in vanilla kernel, I hope in the future with SOF it could be much easier to get into working solution on Intel Edison platform).
Quoted 17 lines
Vinod Koul (2):
ASoC: Intel: removemfld_machine
ASoC: sn95031: remove this codesound/soc/codecs/Kconfig | 4 - sound/soc/codecs/Makefile | 1 - sound/soc/codecs/sn95031.c | 936 ----------------------- ----------- sound/soc/codecs/sn95031.h | 133 ----- sound/soc/intel/boards/Kconfig | 14 - sound/soc/intel/boards/mfld_machine.c | 430 ---------------- 6 files changed, 1518 deletions(-) delete mode 100644 sound/soc/codecs/sn95031.c delete mode 100644 sound/soc/codecs/sn95031.h delete mode 100644 sound/soc/intel/boards/mfld_machine.c
Signature · 2 lines
Andy Shevchenko <[email protected]> Intel Finland Oy
Quoted 9 lines · Andy Shevchenko
Quoted 2 lines · Vinod Koul
Medfield machine was not compiling for long on mainline. Since no one complained, lets remove the dead code and associated codec.
While this change seems okay per se, please keep in mind that Intel Merrifield would be still in use (yes, we have no confirmation right now about the status of the driver in vanilla kernel, I hope in the future with SOF it could be much easier to get into working solution on Intel Edison platform).
This is the mfld machine and codec, mrfld machine is separate and platform is supported by the mfld pcm driver (which also supports byt, bsw, cht and so on) that is not removed so wont impact tng core work.
Signature · 1 line
~Vinod
Quoted 15 lines · Vinod Koul
Quoted 5 lines · Andy Shevchenko
Quoted 3 lines · Vinod Koul
Medfield machine was not compiling for long on mainline. Since no one
complained, lets remove the dead code and associated codec.Quoted 8 lines
While this change seems okay per se, please keep in mind that Intel Merrifield would be still in use (yes, we have no confirmation right now
about the status of the driver in vanilla kernel, I hope in the future
with SOF it could be much easier to get into working solution on Intel
Edison platform).
Quoted 5 lines
This is the mfld machine and codec, mrfld machine is separate and platform
is supported by the mfld pcm driver (which also supports byt, bsw, cht and
so on) that is not removed so wont impact tng core work.
Thank you for confirmation.
Signature · 2 lines
Andy Shevchenko <[email protected]> Intel Finland Oy
Quoted 11 lines · Vinod Koul
Quoted 9 lines · Andy Shevchenko
Quoted 2 lines · Vinod Koul
Medfield machine was not compiling for long on mainline. Since no one complained, lets remove the dead code and associated codec.
While this change seems okay per se, please keep in mind that Intel Merrifield would be still in use (yes, we have no confirmation right now about the status of the driver in vanilla kernel, I hope in the future with SOF it could be much easier to get into working solution on Intel Edison platform).
Quoted 3 lines
This is the mfld machine and codec, mrfld machine is separate and platform is supported by the mfld pcm driver (which also supports byt, bsw, cht and so on) that is not removed so wont impact tng core work.
Getting Merrifield/Edison to work with both SOF and the closed-source firmware is one of my objectives when I find spare cycles.