Patch "iw_cxgb4: only call the cq comp_handler when the cq is armed" has been added to the 4.14-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
iw_cxgb4: only call the cq comp_handler when the cq is armed
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
iw_cxgb4-only-call-the-cq-comp_handler-when-the-cq-is-armed.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
cbb40fadd31c6bbc59104e58ac95c6ef492d038bMon Sep 17 00:00:00 2001
From: Steve Wise <[email protected]>
Date: Thu, 9 Nov 2017 07:14:43 -0800
Subject: iw_cxgb4: only call the cq comp_handler when the cq is armed
From: Steve Wise <[email protected]>
commit cbb40fadd31c6bbc59104e58ac95c6ef492d038b upstream.
The ULPs completion handler should only be called if the CQ is armed for notification.
--- drivers/infiniband/hw/cxgb4/ev.c | 8 +++++--- drivers/infiniband/hw/cxgb4/qp.c | 20 ++++++++++++-------- 2 files changed, 17 insertions(+), 11 deletions(-)
drivers/infiniband/hw/cxgb4/ev.c +5 -3
@@ -109,9 +109,11 @@ static void post_qp_event(struct c4iw_deif (qhp->ibqp.event_handler) (*qhp->ibqp.event_handler)(&event, qhp->ibqp.qp_context); -spin_lock_irqsave (&chp->comp_handler_lock, flag); - (*chp->ibcq.comp_handler)(&chp->ibcq, chp->ibcq.cq_context); -spin_unlock_irqrestore (&chp->comp_handler_lock, flag); +if (t4_clear_cq_armed (&chp->cq)) { +spin_lock_irqsave (&chp->comp_handler_lock, flag); + (*chp->ibcq.comp_handler)(&chp->ibcq, chp->ibcq.cq_context); +spin_unlock_irqrestore (&chp->comp_handler_lock, flag); + } }void c4iw_ev_dispatch (struct c4iw_dev *dev,struct t4_cqe *err_cqe)
drivers/infiniband/hw/cxgb4/qp.c +12 -8
@@ -817,10 +817,12 @@ static void complete_sq_drain_wr(structt4_swcq_produce (cq);spin_unlock_irqrestore (&schp->lock, flag); -spin_lock_irqsave (&schp->comp_handler_lock, flag); - (*schp->ibcq.comp_handler)(&schp->ibcq, - schp->ibcq.cq_context); -spin_unlock_irqrestore (&schp->comp_handler_lock, flag); +if (t4_clear_cq_armed (&schp->cq)) { +spin_lock_irqsave (&schp->comp_handler_lock, flag); + (*schp->ibcq.comp_handler)(&schp->ibcq, + schp->ibcq.cq_context); +spin_unlock_irqrestore (&schp->comp_handler_lock, flag); + } }static void complete_rq_drain_wr (struct c4iw_qp *qhp,struct ib_recv_wr *wr)
@@ -846,10 +848,12 @@ static void complete_rq_drain_wr(structt4_swcq_produce (cq);spin_unlock_irqrestore (&rchp->lock, flag); -spin_lock_irqsave (&rchp->comp_handler_lock, flag); - (*rchp->ibcq.comp_handler)(&rchp->ibcq, - rchp->ibcq.cq_context); -spin_unlock_irqrestore (&rchp->comp_handler_lock, flag); +if (t4_clear_cq_armed (&rchp->cq)) { +spin_lock_irqsave (&rchp->comp_handler_lock, flag); + (*rchp->ibcq.comp_handler)(&rchp->ibcq, + rchp->ibcq.cq_context); +spin_unlock_irqrestore (&rchp->comp_handler_lock, flag); + } } int c4iw_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr,
Patches currently in stable-queue which might be from [email protected] are
queue-4.14/iw_cxgb4-only-clear-the-armed-bit-if-a-notification-is-needed.patch queue-4.14/iw_cxgb4-atomically-flush-the-qp.patch queue-4.14/iw_cxgb4-when-flushing-complete-all-wrs-in-a-chain.patch queue-4.14/iw_cxgb4-reflect-the-original-wr-opcode-in-drain-cqes.patch queue-4.14/iw_cxgb4-only-call-the-cq-comp_handler-when-the-cq-is-armed.patch