Patch "kdump: write correct address of mem_section into vmcoreinfo" has been added to the 4.14-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
kdump: write correct address of mem_section into vmcoreinfo
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
kdump-write-correct-address-of-mem_section-into-vmcoreinfo.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
a0b1280368d1e91ab72f849ef095b4f07a39bbf1Mon Sep 17 00:00:00 2001
From: "Kirill A. Shutemov" <[email protected]>
Date: Fri, 12 Jan 2018 16:53:14 -0800
Subject: kdump: write correct address of mem_section into vmcoreinfo
From: Kirill A. Shutemov <[email protected]>
commit a0b1280368d1e91ab72f849ef095b4f07a39bbf1 upstream.
Depending on configuration mem_section can now be an array or a pointer to an array allocated dynamically. In most cases, we can continue to refer to it as 'mem_section' regardless of what it is.
But there's one exception: '&mem_section' means "address of the array" if mem_section is an array, but if mem_section is a pointer, it would mean "address of the pointer".
We've stepped onto this in kdump code. VMCOREINFO_SYMBOL(mem_section) writes down address of pointer into vmcoreinfo, not array as we wanted.
Let's introduce VMCOREINFO_SYMBOL_ARRAY() that would handle the situation correctly for both cases.
--- include/linux/crash_core.h | 2 ++ kernel/crash_core.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)
include/linux/crash_core.h +2 -0
@@ -42,6 +42,8 @@ phys_addr_t paddr_vmcoreinfo_note(void); vmcoreinfo_append_str("PAGESIZE=%ld\n", value)#define VMCOREINFO_SYMBOL (name) \ vmcoreinfo_append_str("SYMBOL(%s)=%lx\n", #name, (unsigned long)&name) +#define VMCOREINFO_SYMBOL_ARRAY (name) \ + vmcoreinfo_append_str("SYMBOL(%s)=%lx\n", #name, (unsigned long)name)#define VMCOREINFO_SIZE (name) \ vmcoreinfo_append_str("SIZE(%s)=%lu\n", #name, \ (unsigned long)sizeof(name))
kernel/crash_core.c +1 -1
@@ -409,7 +409,7 @@ static int __init crash_save_vmcoreinfo_VMCOREINFO_SYMBOL (contig_page_data);#endif #ifdef CONFIG_SPARSEMEM -VMCOREINFO_SYMBOL (mem_section); +VMCOREINFO_SYMBOL_ARRAY (mem_section);VMCOREINFO_LENGTH (mem_section,NR_SECTION_ROOTS );VMCOREINFO_STRUCT_SIZE (mem_section);VMCOREINFO_OFFSET (mem_section, section_mem_map);
Patches currently in stable-queue which might be from [email protected] are
queue-4.14/kdump-write-correct-address-of-mem_section-into-vmcoreinfo.patch