Adding NV12 support
Subsystems (2)
cover Adding NV12 support
This patch series is adding NV12 support for Broxton display after rebasing on latest drm-tip.
Initial series of the patches can be found here:
https://lists.freedesktop.org/archives/intel-gfx/2015-May/066786.html
Previous revision history:
The first version of patches were reviewed when floated by Chandra in 2015 but currently there was a design change with respect to
- the way fb offset is handled
- the way rotation is handled
Current NV12 patch series has been ported as per the
current changes on drm-tip
Review comments from Ville (12th June 2017) have been addressed Review comments from Clinton A Taylor (7th July 2017) have been addressed
Review comments from Clinton A Taylor (10th July 2017)
have been addressed. Had missed out tested-by/reviewed-by in the patches.
Fixed that error in this series.
Review comments from Ville (11th July 2017) addressed. Review comments from Paauwe, Bob (29th July 2017) addressed.
Update from rev 28 Aug 2017
Rebased the series. Tested with IGT for rotation, sprite and tiling combinations. IGT Links: https://patchwork.kernel.org/patch/9995943/ https://patchwork.kernel.org/patch/9995945/
Update from last rev (Jan 4th 2018):
Rebased the series.
Review comments by Maarten are addressed in this series.
Patches are tested (dependent on) watermark necessary changes
https://patchwork.freedesktop.org/series/33439/
Chandra Konduru (6):
drm/i915: Set scaler mode for NV12
drm/i915: Update format_is_yuv() to include NV12 drm/i915: Upscale scaler max scale for NV12 drm/i915: Add NV12 as supported format for primary plane drm/i915: Add NV12 as supported format for sprite plane drm/i915: Add NV12 support to intel_framebuffer_init
Mahesh Kumar (9):
drm/i915/skl+: rename skl_wm_values struct to skl_ddb_values drm/i915/skl+: refactor WM calculation for NV12 drm/i915/skl+: add NV12 in skl_format_to_fourcc drm/i915/skl+: support verification of DDB HW state for NV12 drm/i915/skl+: NV12 related changes for WM drm/i915/skl+: pass skl_wm_level struct to wm compute func drm/i915/skl+: make sure higher latency level has higher wm value drm/i915/skl+: nv12 workaround disable WM level 1-7 drm/i915/skl: split skl_compute_ddb function
drivers/gpu/drm/i915/i915_drv.h | 9 +- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_atomic.c | 8 +- drivers/gpu/drm/i915/intel_display.c | 71 ++++-- drivers/gpu/drm/i915/intel_drv.h | 8 +- drivers/gpu/drm/i915/intel_pm.c | 433 ++++++++++++++++++++++------------- drivers/gpu/drm/i915/intel_sprite.c | 34 ++- 7 files changed, 374 insertions(+), 190 deletions(-)
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/15 drm/i915/skl+: rename skl_wm_values struct to skl_ddb_values
From: Mahesh Kumar <[email protected]>
skl_wm_values struct contains values of pipe/plane DDB only. so rename it for better readability of code. Similarly skl_copy_wm_for_pipe copies DDB values.
s/skl_wm_values/skl_ddb_values
s/skl_copy_wm_for_pipe/skl_copy_ddb_for_pipe
Changes since V1:
- also change name of skl_copy_wm_for_pipe
--- drivers/gpu/drm/i915/i915_drv.h | 4 ++-- drivers/gpu/drm/i915/intel_drv.h | 2 +- drivers/gpu/drm/i915/intel_pm.c | 14 +++++++------- 3 files changed, 10 insertions(+), 10 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +2 -2
@@ -1437,7 +1437,7 @@ struct skl_ddb_allocation {struct skl_ddb_entry y_plane[I915_MAX_PIPES ][I915_MAX_PLANES ]; }; -struct skl_wm_values { +struct skl_ddb_values {unsigned dirty_pipes;struct skl_ddb_allocation ddb; };
@@ -2131,7 +2131,7 @@ struct drm_i915_private {/* current hardware state */ union {struct ilk_wm_values hw; -struct skl_wm_values skl_hw; +struct skl_ddb_values skl_hw;struct vlv_wm_values vlv;struct g4x_wm_values g4x; };
drivers/gpu/drm/i915/intel_drv.h +1 -1
@@ -476,7 +476,7 @@ struct intel_atomic_state {bool skip_intermediate_wm;/* Gen9+ only */ -struct skl_wm_values wm_results; +struct skl_ddb_values wm_results;struct i915_sw_fence commit_ready;
drivers/gpu/drm/i915/intel_pm.c +7 -7
@@ -4997,8 +4997,8 @@ skl_compute_ddb(struct drm_atomic_state *state) }static void -skl_copy_wm_for_pipe (struct skl_wm_values *dst, -struct skl_wm_values *src, +skl_copy_ddb_for_pipe (struct skl_ddb_values *dst, +struct skl_ddb_values *src,enum pipe pipe) { memcpy(dst->ddb.y_plane[pipe], src->ddb.y_plane[pipe],
@@ -5050,7 +5050,7 @@ skl_compute_wm(struct drm_atomic_state *state)struct drm_crtc *crtc;struct drm_crtc_state *cstate;struct intel_atomic_state *intel_state =to_intel_atomic_state (state); -struct skl_wm_values *results = &intel_state->wm_results; +struct skl_ddb_values *results = &intel_state->wm_results;struct drm_device *dev = state->dev;struct skl_pipe_wm *pipe_wm;bool changed = false;
@@ -5152,8 +5152,8 @@ static void skl_initial_wm(struct intel_atomic_state *state,struct intel_crtc *intel_crtc =to_intel_crtc (cstate->base.crtc);struct drm_device *dev = intel_crtc->base.dev;struct drm_i915_private *dev_priv =to_i915 (dev); -struct skl_wm_values *results = &state->wm_results; -struct skl_wm_values *hw_vals = &dev_priv->wm.skl_hw; +struct skl_ddb_values *results = &state->wm_results; +struct skl_ddb_values *hw_vals = &dev_priv->wm.skl_hw;enum pipe pipe = intel_crtc->pipe;if ((results->dirty_pipes &drm_crtc_mask (&intel_crtc->base)) ==0 )
@@ -5164,7 +5164,7 @@ static void skl_initial_wm(struct intel_atomic_state *state,if (cstate->base.active_changed)skl_atomic_update_crtc_wm (state, cstate); -skl_copy_wm_for_pipe (hw_vals, results, pipe); +skl_copy_ddb_for_pipe (hw_vals, results, pipe);mutex_unlock (&dev_priv->wm.wm_mutex); }
@@ -5296,7 +5296,7 @@ void skl_pipe_wm_get_hw_state(struct drm_crtc *crtc,void skl_wm_get_hw_state (struct drm_device *dev) {struct drm_i915_private *dev_priv =to_i915 (dev); -struct skl_wm_values *hw = &dev_priv->wm.skl_hw; +struct skl_ddb_values *hw = &dev_priv->wm.skl_hw;struct skl_ddb_allocation *ddb = &dev_priv->wm.skl_hw.ddb;struct drm_crtc *crtc;struct intel_crtc *intel_crtc;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/15 drm/i915/skl+: refactor WM calculation for NV12
In reply to Vidya SrinivasFrom: Mahesh Kumar <[email protected]>
Current code calculates DDB for planar formats in such a way that we store DDB of plane-0 in plane 1 & vice-versa.
In order to make this clean this patch refactors WM/DDB calculation for NV12 planar formats.
v2: Addressed review comments by Maarten
--- drivers/gpu/drm/i915/i915_drv.h | 4 +- drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 121 ++++++++++++++++++++------------------- 3 files changed, 64 insertions(+), 62 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +2 -2
@@ -1433,8 +1433,8 @@ static inline bool skl_ddb_entry_equal(const struct skl_ddb_entry *e1, }struct skl_ddb_allocation { -struct skl_ddb_entry plane[I915_MAX_PIPES ][I915_MAX_PLANES ];/* packed/uv */ -struct skl_ddb_entry y_plane[I915_MAX_PIPES ][I915_MAX_PLANES ]; +struct skl_ddb_entry plane[I915_MAX_PIPES ][I915_MAX_PLANES ];/* packed/y */ +struct skl_ddb_entry uv_plane[I915_MAX_PIPES ][I915_MAX_PLANES ]; };struct skl_ddb_values {
drivers/gpu/drm/i915/intel_drv.h +1 -0
@@ -592,6 +592,7 @@ struct intel_pipe_wm {struct skl_plane_wm {struct skl_wm_level wm[8 ];struct skl_wm_level trans_wm; +bool is_nv12; };struct skl_pipe_wm {
drivers/gpu/drm/i915/intel_pm.c +61 -60
274 lines not on this page · raw message
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
kbuild test robot
build botRe: [PATCH 02/15] drm/i915/skl+: refactor WM calculation for NV12
Thank you for the patch! Perhaps something to improve:
Hi Mahesh,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v4.15-rc8 next-20180119]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Vidya-Srinivas/Adding-NV12-support/20180120-064213 base: git://anongit.freedesktop.org/drm-intel for-linux-next reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/i915/intel_pm.c:4794:73: sparse: Using plain integer as NULL pointer
vim +4794 drivers/gpu/drm/i915/intel_pm.c
4764
4765 static void skl_write_plane_wm(struct intel_crtc *intel_crtc,
4766 const struct skl_plane_wm *wm,
4767 const struct skl_ddb_allocation *ddb,
4768 enum plane_id plane_id)
4769 {
4770 struct drm_crtc *crtc = &intel_crtc->base;
4771 struct drm_device *dev = crtc->dev;
4772 struct drm_i915_private *dev_priv = to_i915(dev);
4773 int level, max_level = ilk_wm_max_level(dev_priv);
4774 enum pipe pipe = intel_crtc->pipe;
4775
4776 for (level = 0; level <= max_level; level++) {
4777 skl_write_wm_level(dev_priv, PLANE_WM(pipe, plane_id, level),
4778 &wm->wm[level]);
4779 }
4780 skl_write_wm_level(dev_priv, PLANE_WM_TRANS(pipe, plane_id),
4781 &wm->trans_wm);
4782
4783 if (wm->is_nv12) {
4784 skl_ddb_entry_write(dev_priv, PLANE_BUF_CFG(pipe, plane_id),
4785 &ddb->uv_plane[pipe][plane_id]);
4786 skl_ddb_entry_write(dev_priv,
4787 PLANE_NV12_BUF_CFG(pipe, plane_id),
4788 &ddb->plane[pipe][plane_id]);
4789 } else {
4790 skl_ddb_entry_write(dev_priv, PLANE_BUF_CFG(pipe, plane_id),
4791 &ddb->plane[pipe][plane_id]);
4792 /* No NV12 buffer allocation for non NV12 pixel formats */
4793 skl_ddb_entry_write(dev_priv,
> 4794 PLANE_NV12_BUF_CFG(pipe, plane_id), 0x0); 4795 }
4796 }
4797
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/15 drm/i915/skl+: add NV12 in skl_format_to_fourcc
In reply to Vidya SrinivasFrom: Mahesh Kumar <[email protected]>
Add support of recognizing DRM_FORMAT_NV12 from plane_format register value.
--- drivers/gpu/drm/i915/intel_display.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/intel_display.c +2 -0
@@ -2612,6 +2612,8 @@ static int skl_format_to_fourcc(int format, bool rgb_order, bool alpha)switch (format) {case PLANE_CTL_FORMAT_RGB_565 :return DRM_FORMAT_RGB565 ; +case PLANE_CTL_FORMAT_NV12 : +return DRM_FORMAT_NV12 ;default :case PLANE_CTL_FORMAT_XRGB_8888 :if (rgb_order) {
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 03/15] drm/i915/skl+: add NV12 in skl_format_to_fourcc
Quoted 5 lines · Vidya Srinivas
From: Mahesh Kumar <[email protected]>
Add support of recognizing
DRM_FORMAT_NV12fromplane_formatregister value.
Quoted 20 lines
Signed-off-by Mahesh Kumar <[email protected]>---
drivers/gpu/drm/i915/intel_display.c | 2 ++1 file changed, 2 insertions(+)drivers/gpu/drm/i915/intel_display.c +0
-0@@ -2612,6 +2612,8 @@ static int skl_format_to_fourcc(int format, bool rgb_order, bool alpha) switch (format) {case
PLANE_CTL_FORMAT_RGB_565:
returnDRM_FORMAT_RGB565;drivers/gpu/drm/i915/intel_display.c +2
-0+case PLANE_CTL_FORMAT_NV12 : +return DRM_FORMAT_NV12 ;default:
casePLANE_CTL_FORMAT_XRGB_8888:
if (rgb_order) {
Signature · 6 lines
Mika Kahola - Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/15 drm/i915/skl+: support verification of DDB HW state for NV12
In reply to Vidya SrinivasFrom: Mahesh Kumar <[email protected]>
NV12 formats have two registers for DDB. Verify both the registers for NV12 during verify_wm_state.
v2: Addressed review comments by Maarten.
--- drivers/gpu/drm/i915/intel_display.c | 2 +- drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 50 ++++++++++++++++++++++++++++-------- 3 files changed, 42 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/intel_display.c +1 -1
@@ -2607,7 +2607,7 @@ static int i9xx_format_to_fourcc(int format) } } -static int skl_format_to_fourcc (int format,bool rgb_order,bool alpha) +int skl_format_to_fourcc (int format,bool rgb_order,bool alpha) {switch (format) {case PLANE_CTL_FORMAT_RGB_565 :
drivers/gpu/drm/i915/intel_drv.h +1 -0
@@ -1591,6 +1591,7 @@ u32 skl_plane_stride(const struct drm_framebuffer *fb, int plane, unsigned int rotation);int skl_check_plane_surface (struct intel_plane_state *plane_state);int i9xx_check_plane_surface (struct intel_plane_state *plane_state); +int skl_format_to_fourcc (int format,bool rgb_order,bool alpha);/* intel_csr.c */ void intel_csr_ucode_init (struct drm_i915_private *);
drivers/gpu/drm/i915/intel_pm.c +40 -10
62 lines not on this page · raw message
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 5/15 drm/i915/skl+: NV12 related changes for WM
In reply to Vidya SrinivasFrom: Mahesh Kumar <[email protected]>
NV12 requires WM calculation for UV plane as well.
UV plane WM should also fulfill all the WM related restrictions.
--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 54 ++++++++++++++++++++++++++++++++-------- 3 files changed, 45 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +1 -0
@@ -1452,6 +1452,7 @@ struct skl_wm_level {struct skl_wm_params {bool x_tiled, y_tiled;bool rc_surface; +bool is_nv12;uint32_t width;uint8_t cpp;uint32_t plane_pixel_rate;
drivers/gpu/drm/i915/intel_drv.h +1 -0
@@ -591,6 +591,7 @@ struct intel_pipe_wm {struct skl_plane_wm {struct skl_wm_level wm[8 ]; +struct skl_wm_level uv_wm[8 ];struct skl_wm_level trans_wm;bool is_nv12; };
drivers/gpu/drm/i915/intel_pm.c +43 -11
120 lines not on this page · raw message
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 6/15 drm/i915/skl+: pass skl_wm_level struct to wm compute func
In reply to Vidya SrinivasFrom: Mahesh Kumar <[email protected]>
This will reduce number of arguments required to be passed in skl_compute_plane_wm function.
--- drivers/gpu/drm/i915/intel_pm.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/intel_pm.c +7 -11
@@ -4514,9 +4514,7 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv,uint16_t ddb_allocation, int level, const struct skl_wm_params *wp, - uint16_t *out_blocks, /* out */ - uint8_t *out_lines, /* out */ - bool *enabled /* out */) + struct skl_wm_level *result /* out */) { const struct drm_plane_state *pstate = &intel_pstate->base;uint32_t latency = dev_priv->wm.skl_latency[level];
@@ -4529,7 +4527,7 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv,if (latency ==0 || !intel_wm_plane_visible (cstate, intel_pstate)) { - *enabled = false; + result->plane_en = false;return 0 ; }
@@ -4584,7 +4582,7 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv, }if (res_blocks >= ddb_allocation || res_lines >31 ) { - *enabled = false; + result->plane_en = false;/* * If there are no valid level 0 watermarks, then we can't
@@ -4603,9 +4601,9 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv, } } - *out_blocks = res_blocks; - *out_lines = res_lines; - *enabled = true; + result->plane_res_b = res_blocks; + result->plane_res_l = res_lines; + result->plane_en = true;return 0 ; }
@@ -4646,9 +4644,7 @@ skl_compute_wm_levels(const struct drm_i915_private *dev_priv, ddb_blocks, level, wm_params, - &result->plane_res_b, - &result->plane_res_l, - &result->plane_en); + result);if (ret)return ret; }
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 7/15 drm/i915/skl+: make sure higher latency level has higher wm value
In reply to Vidya SrinivasFrom: Mahesh Kumar <[email protected]>
DDB allocation optimization algorithm requires/assumes ddb allocation for any memory C-state level DDB value to be as high as level below. Render decompression requires level WM to be as high as wm level-0. This patch fulfils both the requirements.
--- drivers/gpu/drm/i915/intel_pm.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
drivers/gpu/drm/i915/intel_pm.c +18 -0
@@ -4514,6 +4514,7 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv,uint16_t ddb_allocation, int level, const struct skl_wm_params *wp, + const struct skl_wm_level *result_prev, struct skl_wm_level *result /* out */) { const struct drm_plane_state *pstate = &intel_pstate->base;
@@ -4579,6 +4580,15 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv, }else { res_blocks++; } + +/* +* Make sure result blocks for higher latency levels are atleast +* as high as level below. +* Assumption in DDB algorithm optimization for special cases. +* Also covers Display WA #1125 for RC. +*/ +if (result_prev->plane_res_b > res_blocks) + res_blocks = result_prev->plane_res_b; }if (res_blocks >= ddb_allocation || res_lines >31 ) {
@@ -4637,6 +4647,13 @@ skl_compute_wm_levels(const struct drm_i915_private *dev_priv,for (level =0 ; level <= max_level; level++) {struct skl_wm_level *result = plane_num ? &wm->uv_wm[level] : &wm->wm[level]; +struct skl_wm_level *result_prev; + +if (level) + result_prev = plane_num ? &wm->uv_wm[level -1 ] : + &wm->wm[level -1 ]; +else + result_prev = plane_num ? &wm->uv_wm[0 ] : &wm->wm[0 ]; ret = skl_compute_plane_wm(dev_priv, cstate,
@@ -4644,6 +4661,7 @@ skl_compute_wm_levels(const struct drm_i915_private *dev_priv, ddb_blocks, level, wm_params, + result_prev, result);if (ret)return ret;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 8/15 drm/i915/skl+: nv12 workaround disable WM level 1-7
In reply to Vidya SrinivasFrom: Mahesh Kumar <[email protected]>
Display Workaround #0826 (SKL:ALL BXT:ALL) & #1059(CNL:A) Hardware sometimes fails to wake memory from pkg C states fetching the last few lines of planar YUV 420 (NV12) planes. This causes intermittent underflow and corruption.
WA: Disable package C states or do not enable latency levels 1 through 7 (WM1 - WM7) on NV12 planes.
v2: Addressed review comments by Maarten.
--- drivers/gpu/drm/i915/intel_pm.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/gpu/drm/i915/intel_pm.c +11 -0
@@ -4611,6 +4611,17 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv, } } +/* +* Display WA #826 (SKL:ALL, BXT:ALL) & #1059 (CNL:A) +* disable wm level 1-7 on NV12 planes +*/ +if (wp->is_nv12 && (level >=1 ) && + (IS_SKYLAKE (dev_priv) ||IS_BROXTON (dev_priv) || +IS_CNL_REVID (dev_priv,CNL_REVID_A0 ,CNL_REVID_A0 ))) { + result->plane_en = false; +return 0 ; + } + result->plane_res_b = res_blocks; result->plane_res_l = res_lines; result->plane_en = true;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 9/15 drm/i915/skl: split skl_compute_ddb function
In reply to Vidya SrinivasFrom: Mahesh Kumar <[email protected]>
This patch splits skl_compute_wm/ddb functions into two parts. One adds all affected pipes after the commit to atomic_state structure and second part does compute the DDB.
--- drivers/gpu/drm/i915/intel_pm.c | 157 ++++++++++++++++++++++------------------ 1 file changed, 88 insertions(+), 69 deletions(-)
drivers/gpu/drm/i915/intel_pm.c +88 -69
@@ -5009,69 +5009,16 @@ skl_ddb_add_affected_planes(struct intel_crtc_state *cstate)static int skl_compute_ddb (struct drm_atomic_state *state) { -struct drm_device *dev = state->dev; -struct drm_i915_private *dev_priv =to_i915 (dev); +const struct drm_i915_private *dev_priv =to_i915 (state->dev);struct intel_atomic_state *intel_state =to_intel_atomic_state (state); -struct intel_crtc *intel_crtc;struct skl_ddb_allocation *ddb = &intel_state->wm_results.ddb; -uint32_t realloc_pipes =pipes_modified (state); -int ret; - -/* -* If this is our first atomic update following hardware readout, -* we can't trust the DDB that the BIOS programmed for us. Let's -* pretend that all pipes switched active status so that we'll -* ensure a full DDB recompute. -*/ -if (dev_priv->wm.distrust_bios_wm) { - ret =drm_modeset_lock (&dev->mode_config.connection_mutex, - state->acquire_ctx); -if (ret) -return ret; - - intel_state->active_pipe_changes = ~0 ; - -/* -* We usually only initialize intel_state->active_crtcs if we -* we're doing a modeset; make sure this field is always -* initialized during the sanitization process that happens -* on the first commit too. -*/ -if (!intel_state->modeset) - intel_state->active_crtcs = dev_priv->active_crtcs; - } - -/* -* If the modeset changes which CRTC's are active, we need to -* recompute the DDB allocation for *all* active pipes, even -* those that weren't otherwise being modified in any way by this -* atomic commit. Due to the shrinking of the per-pipe allocations -* when new active CRTC's are added, it's possible for a pipe that -* we were already using and aren't changing at all here to suddenly -* become invalid if its DDB needs exceeds its new allocation. -* -* Note that if we wind up doing a full DDB recompute, we can't let -* any other display updates race with this transaction, so we need -* to grab the lock on *all* CRTC's. -*/ -if (intel_state->active_pipe_changes) { - realloc_pipes = ~0 ; - intel_state->wm_results.dirty_pipes = ~0 ; - } +struct intel_crtc *crtc; +struct intel_crtc_state *cstate; +int ret, i; -/* -* We're not recomputing for the pipes not included in the commit, so -* make sure we start with the current state. -*/ memcpy (ddb, &dev_priv->wm.skl_hw.ddb,sizeof (*ddb)); -for_each_intel_crtc_mask (dev, intel_crtc, realloc_pipes) { -struct intel_crtc_state *cstate; - - cstate =intel_atomic_get_crtc_state (state, intel_crtc); -if (IS_ERR (cstate)) -return PTR_ERR (cstate); - +for_each_new_intel_crtc_in_state (intel_state, crtc, cstate, i) { ret =skl_allocate_pipe_ddb (cstate, ddb);if (ret)return ret;
@@ -5133,23 +5080,23 @@ skl_print_wm_changes(const struct drm_atomic_state *state) }static int -skl_compute_wm (struct drm_atomic_state *state) +skl_ddb_add_affected_pipes (struct drm_atomic_state *state,bool *changed) { -struct drm_crtc *crtc; -struct drm_crtc_state *cstate; -struct intel_atomic_state *intel_state =to_intel_atomic_state (state); -struct skl_ddb_values *results = &intel_state->wm_results;struct drm_device *dev = state->dev; -struct skl_pipe_wm *pipe_wm; -bool changed = false; +const struct drm_i915_private *dev_priv =to_i915 (dev); +const struct drm_crtc *crtc; +const struct drm_crtc_state *cstate; +struct intel_crtc *intel_crtc; +struct intel_atomic_state *intel_state =to_intel_atomic_state (state); +uint32_t realloc_pipes =pipes_modified (state);int ret, i;/* * When we distrust bios wm we always need to recompute to set the * expected DDB allocations for each CRTC. */ -if (to_i915 (dev)->wm.distrust_bios_wm) - changed = true; +if (dev_priv->wm.distrust_bios_wm) + *changed = true;/* * If this transaction isn't actually touching any CRTC's, don't
@@ -5160,14 +5107,86 @@ skl_compute_wm(struct drm_atomic_state *state)* hold _all_ CRTC state mutexes. */ for_each_new_crtc_in_state (state, crtc, cstate, i) - changed = true; + *changed = true; -if (!changed) +if (!*changed)return 0 ; +/* +* If this is our first atomic update following hardware readout, +* we can't trust the DDB that the BIOS programmed for us. Let's +* pretend that all pipes switched active status so that we'll +* ensure a full DDB recompute. +*/ +if (dev_priv->wm.distrust_bios_wm) { + ret =drm_modeset_lock (&dev->mode_config.connection_mutex, + state->acquire_ctx); +if (ret) +return ret; + + intel_state->active_pipe_changes = ~0 ; + +/* +* We usually only initialize intel_state->active_crtcs if we +* we're doing a modeset; make sure this field is always +* initialized during the sanitization process that happens +* on the first commit too. +*/ +if (!intel_state->modeset) + intel_state->active_crtcs = dev_priv->active_crtcs; + } + +/* +* If the modeset changes which CRTC's are active, we need to +* recompute the DDB allocation for *all* active pipes, even +* those that weren't otherwise being modified in any way by this +* atomic commit. Due to the shrinking of the per-pipe allocations +* when new active CRTC's are added, it's possible for a pipe that +* we were already using and aren't changing at all here to suddenly +* become invalid if its DDB needs exceeds its new allocation. +* +* Note that if we wind up doing a full DDB recompute, we can't let +* any other display updates race with this transaction, so we need +* to grab the lock on *all* CRTC's. +*/ +if (intel_state->active_pipe_changes) { + realloc_pipes = ~0 ; + intel_state->wm_results.dirty_pipes = ~0 ; + } + +/* +* We're not recomputing for the pipes not included in the commit, so +* make sure we start with the current state. +*/ +for_each_intel_crtc_mask (dev, intel_crtc, realloc_pipes) { +struct intel_crtc_state *cstate; + + cstate =intel_atomic_get_crtc_state (state, intel_crtc); +if (IS_ERR (cstate)) +return PTR_ERR (cstate); + } + +return 0 ; +} + +static int +skl_compute_wm (struct drm_atomic_state *state) +{ +struct drm_crtc *crtc; +struct drm_crtc_state *cstate; +struct intel_atomic_state *intel_state =to_intel_atomic_state (state); +struct skl_ddb_values *results = &intel_state->wm_results; +struct skl_pipe_wm *pipe_wm; +bool changed = false; +int ret, i; +/* Clear all dirty flags */ results->dirty_pipes =0 ; + ret =skl_ddb_add_affected_pipes (state, &changed); +if (ret || !changed) +return ret; + ret =skl_compute_ddb (state);if (ret)return ret;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 10/15 drm/i915: Set scaler mode for NV12
In reply to Vidya SrinivasFrom: Chandra Konduru <[email protected]>
This patch sets appropriate scaler mode for NV12 format. In this mode, skylake scaler does either chroma-upsampling or chroma-upsampling and resolution scaling
v2: Review comments from Ville addressed
NV12 case to be checked first for setting
the scaler
v3: Rebased (me)
v4: Rebased (me)
v5: Missed the Tested-by/Reviewed-by in the previous series Adding the same to commit message in this version.
v6: Rebased (me)
v7: Rebased (me)
v8: Rebased (me)
Restricting the NV12 change for scaler to BXT and KBL in this series.
v9: Rebased (me)
--- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_atomic.c | 8 +++++++- 2 files changed, 8 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_reg.h +1 -0
@@ -6656,6 +6656,7 @@ enum {#define PS_SCALER_MODE_MASK (3 << 28)#define PS_SCALER_MODE_DYN (0 << 28)#define PS_SCALER_MODE_HQ (1 << 28) +#define PS_SCALER_MODE_NV12 (2 << 28)#define PS_PLANE_SEL_MASK (7 << 25)#define PS_PLANE_SEL (plane) (((plane) + 1) << 25)#define PS_FILTER_MASK (3 << 23)
drivers/gpu/drm/i915/intel_atomic.c +7 -1
@@ -327,7 +327,13 @@ int intel_atomic_setup_scalers(struct drm_i915_private *dev_priv, }/* set scaler mode */ -if (IS_GEMINILAKE (dev_priv) ||IS_CANNONLAKE (dev_priv)) { +if ((IS_BROXTON (dev_priv) ||IS_KABYLAKE (dev_priv)) && + plane_state && plane_state->base.fb && + plane_state->base.fb->format->format == +DRM_FORMAT_NV12 ) { + scaler_state->scalers[*scaler_id].mode = +PS_SCALER_MODE_NV12 ; + }else if (IS_GEMINILAKE (dev_priv) ||IS_CANNONLAKE (dev_priv)) { scaler_state->scalers[*scaler_id].mode =0 ; }else if (num_scalers_need ==1 && intel_crtc->pipe !=PIPE_C ) {/*
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 11/15 drm/i915: Update format_is_yuv() to include NV12
In reply to Vidya SrinivasFrom: Chandra Konduru <[email protected]>
This patch adds NV12 to format_is_yuv() function
for sprite planes.
v2:
-Use intel_ prefix for format_is_yuv (Ville)
v3: Rebased (me)
v4: Rebased and addressed review comments from Clinton A Taylor. "static function in intel_sprite.c is not available
to the primary plane functions".
Changed commit message - function modified for
sprite planes.
v5: Missed the Tested-by/Reviewed-by in the previous series Adding the same to commit message in this version.
v6: Rebased (me)
v7: Rebased (me)
v8: Rebased (me)
v9: Rebased (me)
--- drivers/gpu/drm/i915/intel_sprite.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_sprite.c +4 -3
@@ -42,13 +42,14 @@#include "i915_drv.h" static bool -format_is_yuv (uint32_t format) +intel_format_is_yuv (uint32_t format) {switch (format) {case DRM_FORMAT_YUYV :case DRM_FORMAT_UYVY :case DRM_FORMAT_VYUY :case DRM_FORMAT_YVYU : +case DRM_FORMAT_NV12 :return true;default :return false;
@@ -352,7 +353,7 @@ chv_update_csc(struct intel_plane *plane, uint32_t format)enum plane_id plane_id = plane->id;/* Seems RGB data bypasses the CSC always */ -if (!format_is_yuv (format)) +if (!intel_format_is_yuv (format))return ;/*
@@ -974,7 +975,7 @@ intel_check_sprite_plane(struct intel_plane *plane, src_y = src->y1 >>16 ; src_h =drm_rect_height (src) >>16 ; -if (format_is_yuv (fb->format->format)) { +if (intel_format_is_yuv (fb->format->format)) { src_x &= ~1 ; src_w &= ~1 ;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 12/15 drm/i915: Upscale scaler max scale for NV12
In reply to Vidya SrinivasFrom: Chandra Konduru <[email protected]>
This patch updates scaler max limit support for NV12
v2: Rebased (me)
v3: Rebased (me)
v4: Missed the Tested-by/Reviewed-by in the previous series Adding the same to commit message in this version.
v5: Addressed review comments from Ville and rebased
- calculation of max_scale to be made
less convoluted by splitting it up a bit
- Indentation errors to be fixed in the series
v6: Rebased (me)
Fixed review comments from Paauwe, Bob J
Previous version, where a split of calculation
was done, was wrong. Fixed that issue here.
v7: Rebased (me)
v8: Rebased (me)
v9: Rebased (me)
--- drivers/gpu/drm/i915/intel_display.c | 33 +++++++++++++++++++++++---------- drivers/gpu/drm/i915/intel_drv.h | 3 ++- drivers/gpu/drm/i915/intel_sprite.c | 3 ++- 3 files changed, 27 insertions(+), 12 deletions(-)
drivers/gpu/drm/i915/intel_display.c +23 -10
@@ -3405,6 +3405,8 @@ static u32 skl_plane_ctl_format(uint32_t pixel_format)return PLANE_CTL_FORMAT_YUV422 |PLANE_CTL_YUV422_UYVY ;case DRM_FORMAT_VYUY :return PLANE_CTL_FORMAT_YUV422 |PLANE_CTL_YUV422_VYUY ; +case DRM_FORMAT_NV12 : +return PLANE_CTL_FORMAT_NV12 ;default :MISSING_CASE (pixel_format); }
@@ -4628,7 +4630,8 @@ static void cpt_verify_modeset(struct drm_device *dev, int pipe)static int skl_update_scaler (struct intel_crtc_state *crtc_state,bool force_detach,unsigned int scaler_user,int *scaler_id, -int src_w,int src_h,int dst_w,int dst_h) +int src_w,int src_h,int dst_w,int dst_h, +uint32_t pixel_format) {struct intel_crtc_scaler_state *scaler_state = &crtc_state->scaler_state;
@@ -4644,7 +4647,8 @@ skl_update_scaler(struct intel_crtc_state *crtc_state, bool force_detach,* the 90/270 degree plane rotation cases (to match the * GTT mapping), hence no need to account for rotation here. */ - need_scaling = src_w != dst_w || src_h != dst_h; + need_scaling = src_w != dst_w || src_h != dst_h || + (pixel_format ==DRM_FORMAT_NV12 );if (crtc_state->ycbcr420 && scaler_user ==SKL_CRTC_INDEX ) need_scaling = true;
@@ -4723,7 +4727,7 @@ int skl_update_scaler_crtc(struct intel_crtc_state *state)return skl_update_scaler (state, !state->base.active,SKL_CRTC_INDEX , &state->scaler_state.scaler_id, state->pipe_src_w, state->pipe_src_h, - adjusted_mode->crtc_hdisplay, adjusted_mode->crtc_vdisplay); + adjusted_mode->crtc_hdisplay, adjusted_mode->crtc_vdisplay,0 ); }/**
@@ -4753,7 +4757,8 @@ static int skl_update_scaler_plane(struct intel_crtc_state *crtc_state,drm_rect_width (&plane_state->base.src) >>16 ,drm_rect_height (&plane_state->base.src) >>16 ,drm_rect_width (&plane_state->base.dst), - drm_rect_height(&plane_state->base.dst)); +drm_rect_height (&plane_state->base.dst), + fb ? fb->format->format : 0);if (ret || plane_state->scaler_id <0 )return ret;
@@ -4779,6 +4784,7 @@ static int skl_update_scaler_plane(struct intel_crtc_state *crtc_state,case DRM_FORMAT_YVYU :case DRM_FORMAT_UYVY :case DRM_FORMAT_VYUY : +case DRM_FORMAT_NV12 :break ;default : DRM_DEBUG_KMS("[PLANE:%d:%s] FB:%d unsupported scaling format 0x%x\n",
@@ -12703,11 +12709,12 @@ intel_cleanup_plane_fb(struct drm_plane *plane, }int -skl_max_scale (struct intel_crtc *intel_crtc,struct intel_crtc_state *crtc_state) +skl_max_scale (struct intel_crtc *intel_crtc, +struct intel_crtc_state *crtc_state,uint32_t pixel_format) {struct drm_i915_private *dev_priv; -int max_scale; -int crtc_clock, max_dotclk; +int max_scale, mult; +int crtc_clock, max_dotclk, tmpclk1, tmpclk2;if (!intel_crtc || !crtc_state->base.enable)return DRM_PLANE_HELPER_NO_SCALING ;
@@ -12729,8 +12736,10 @@ skl_max_scale(struct intel_crtc *intel_crtc, struct intel_crtc_state *crtc_state* or * cdclk/crtc_clock */ - max_scale =min ((1 <<16 ) *3 -1 , - (1 <<8 ) * ((max_dotclk <<8 ) / crtc_clock)); + mult = pixel_format ==DRM_FORMAT_NV12 ?2 :3 ; + tmpclk1 = (1 <<16 ) * mult -1 ; + tmpclk2 = (1 <<8 ) * ((max_dotclk <<8 ) / crtc_clock); + max_scale =min (tmpclk1, tmpclk2);return max_scale; }
@@ -12751,7 +12760,11 @@ intel_check_primary_plane(struct intel_plane *plane,/* use scaler when colorkey is not required */ if (state->ckey.flags ==I915_SET_COLORKEY_NONE ) { min_scale =1 ; - max_scale =skl_max_scale (to_intel_crtc (crtc), crtc_state); + max_scale =skl_max_scale (to_intel_crtc (crtc), + crtc_state, + state->base.fb ? + state->base.fb->format->format : +0 ); } can_position = true; }
drivers/gpu/drm/i915/intel_drv.h +2 -1
@@ -1577,7 +1577,8 @@ void intel_mode_from_pipe_config(struct drm_display_mode *mode, struct intel_crtc_state *pipe_config);int skl_update_scaler_crtc (struct intel_crtc_state *crtc_state); -int skl_max_scale (struct intel_crtc *crtc,struct intel_crtc_state *crtc_state); +int skl_max_scale (struct intel_crtc *crtc,struct intel_crtc_state *crtc_state, +uint32_t pixel_format);static inline u32 intel_plane_ggtt_offset (const struct intel_plane_state *state) {
drivers/gpu/drm/i915/intel_sprite.c +2 -1
@@ -897,7 +897,8 @@ intel_check_sprite_plane(struct intel_plane *plane,if (state->ckey.flags ==I915_SET_COLORKEY_NONE ) { can_scale =1 ; min_scale =1 ; - max_scale =skl_max_scale (crtc, crtc_state); + max_scale =skl_max_scale (crtc, crtc_state, + fb->format->format); }else { can_scale =0 ; min_scale =DRM_PLANE_HELPER_NO_SCALING ;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 13/15 drm/i915: Add NV12 as supported format for primary plane
In reply to Vidya SrinivasFrom: Chandra Konduru <[email protected]>
This patch adds NV12 to list of supported formats for primary plane
v2: Rebased (Chandra Konduru)
v3: Rebased (me)
v4: Review comments by Ville addressed
Removed the skl_primary_formats_with_nv12 and
added NV12 case in existing skl_primary_formats
v5: Rebased (me)
v6: Missed the Tested-by/Reviewed-by in the previous series Adding the same to commit message in this version.
v7: Review comments by Ville addressed
Restricting the NV12 for BXT and on PIPE A and B
Rebased (me)
v8: Rebased (me)
Modified restricting the NV12 support for both BXT and KBL.
v9: Rebased (me)
--- drivers/gpu/drm/i915/intel_display.c | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_display.c +24 -2
@@ -106,6 +106,22 @@ static const uint64_t skl_format_modifiers_ccs[] = {DRM_FORMAT_MOD_INVALID }; +static const uint32_t nv12_primary_formats[] = { +DRM_FORMAT_C8 , +DRM_FORMAT_RGB565 , +DRM_FORMAT_XRGB8888 , +DRM_FORMAT_XBGR8888 , +DRM_FORMAT_ARGB8888 , +DRM_FORMAT_ABGR8888 , +DRM_FORMAT_XRGB2101010 , +DRM_FORMAT_XBGR2101010 , +DRM_FORMAT_YUYV , +DRM_FORMAT_YVYU , +DRM_FORMAT_UYVY , +DRM_FORMAT_VYUY , +DRM_FORMAT_NV12 , +}; +/* Cursor formats */ static const uint32_t intel_cursor_formats[] = {DRM_FORMAT_ARGB8888 ,
@@ -13180,8 +13196,14 @@ intel_primary_plane_create(struct drm_i915_private *dev_priv, enum pipe pipe) primary->disable_plane = skl_disable_plane; primary->get_hw_state = skl_plane_get_hw_state; }else if (INTEL_GEN (dev_priv) >=9 ) { - intel_primary_formats = skl_primary_formats; - num_formats =ARRAY_SIZE (skl_primary_formats); +if ((IS_BROXTON (dev_priv) ||IS_KABYLAKE (dev_priv)) && + ((pipe ==PIPE_A || pipe ==PIPE_B ))) { + intel_primary_formats = nv12_primary_formats; + num_formats =ARRAY_SIZE (nv12_primary_formats); + }else { + intel_primary_formats = skl_primary_formats; + num_formats =ARRAY_SIZE (skl_primary_formats); + }if (pipe <PIPE_C ) modifiers = skl_format_modifiers_ccs;else
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 14/15 drm/i915: Add NV12 as supported format for sprite plane
In reply to Vidya SrinivasFrom: Chandra Konduru <[email protected]>
This patch adds NV12 to list of supported formats for sprite plane.
v2: Rebased (me)
v3: Review comments by Ville addressed
- Removed skl_plane_formats_with_nv12 and added
NV12 case in existing skl_plane_formats
- Added the 10bpc RGB formats
v4: Addressed review comments from Clinton A Taylor
"Why are we adding 10 bit RGB formats with the NV12 series patches? Trying to set XR30 or AB30 results in error returned even though the modes are advertised for the planes"
- Removed 10bit RGB formats added previously with NV12 series
v5: Missed the Tested-by/Reviewed-by in the previous series Adding the same to commit message in this version. Addressed review comments from Clinton A Taylor
"Why are we adding 10 bit RGB formats with the NV12 series patches? Trying to set XR30 or AB30 results in error returned even though the modes are advertised for the planes"
- Previous version has 10bit RGB format removed from VLV formats by mistake. Fixing that in this version.
Removed 10bit RGB formats added previously with NV12 series for SKL.
v6: Addressed review comments by Ville
Restricting the NV12 to BXT and PIPE A and B
v7: Rebased (me)
v8: Rebased (me)
Restricting NV12 changes to BXT and KBL
Restricting NV12 changes for plane 0 (overlay)
v9: Rebased (me)
--- drivers/gpu/drm/i915/intel_sprite.c | 24 +++++++++++++++++++++--- 1 file changed, 21 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_sprite.c +21 -3
@@ -1279,6 +1279,19 @@ static const struct drm_plane_funcs intel_sprite_plane_funcs = { .format_mod_supported = intel_sprite_plane_format_mod_supported, }; +static uint32_t nv12_plane_formats[] = { +DRM_FORMAT_RGB565 , +DRM_FORMAT_ABGR8888 , +DRM_FORMAT_ARGB8888 , +DRM_FORMAT_XBGR8888 , +DRM_FORMAT_XRGB8888 , +DRM_FORMAT_YUYV , +DRM_FORMAT_YVYU , +DRM_FORMAT_UYVY , +DRM_FORMAT_VYUY , +DRM_FORMAT_NV12 , +}; +struct intel_plane *intel_sprite_plane_create (struct drm_i915_private *dev_priv,enum pipe pipe,int plane)
@@ -1323,9 +1336,14 @@ intel_sprite_plane_create(struct drm_i915_private *dev_priv, intel_plane->update_plane = skl_update_plane; intel_plane->disable_plane = skl_disable_plane; intel_plane->get_hw_state = skl_plane_get_hw_state; - - plane_formats = skl_plane_formats; - num_plane_formats =ARRAY_SIZE (skl_plane_formats); +if ((IS_BROXTON (dev_priv) ||IS_KABYLAKE (dev_priv)) && + (pipe ==PIPE_A || pipe ==PIPE_B ) && plane ==0 ) { + plane_formats = nv12_plane_formats; + num_plane_formats =ARRAY_SIZE (nv12_plane_formats); + }else { + plane_formats = skl_plane_formats; + num_plane_formats =ARRAY_SIZE (skl_plane_formats); + } modifiers = skl_plane_format_modifiers; }else if (IS_VALLEYVIEW (dev_priv) ||IS_CHERRYVIEW (dev_priv)) { intel_plane->can_scale = false;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 15/15 drm/i915: Add NV12 support to intel_framebuffer_init
In reply to Vidya SrinivasFrom: Chandra Konduru <[email protected]>
This patch adds NV12 as supported format
to intel_framebuffer_init and performs various checks.
v2:
-Fix an issue in checks added (Chandra Konduru)
v3: rebased (me)
v4: Review comments by Ville addressed
Added platform check for NV12 in intel_framebuffer_init Removed offset checks for NV12 case
v5: Addressed review comments by Clinton A Taylor
This NV12 support only correctly works on SKL.
Plane color space conversion is different on GLK and later platforms causing the colors to display incorrectly.
Ville's plane color space property patch series
in review will fix this issue.
- Restricted the NV12 case in intel_framebuffer_init to SKL and BXT only.
v6: Rebased (me)
v7: Addressed review comments by Ville
Restricting the NV12 to BXT for now.
v8: Rebased (me)
Restricting the NV12 changes to BXT and KBL for now.
v9: Rebased (me)
--- drivers/gpu/drm/i915/intel_display.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/gpu/drm/i915/intel_display.c +8 -0
@@ -14005,6 +14005,14 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb, goto err; }break ; +case DRM_FORMAT_NV12 : +if (!IS_BROXTON (dev_priv) && !IS_KABYLAKE (dev_priv)) { +DRM_DEBUG_KMS ("unsupported pixel format: %s\n" , +drm_get_format_name (mode_cmd->pixel_format, + &format_name)); + goto err; + } +break ;default :DRM_DEBUG_KMS ("unsupported pixel format: %s\n" ,drm_get_format_name (mode_cmd->pixel_format, &format_name));
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 15/15] drm/i915: Add NV12 support to intel_framebuffer_init
Op 20-01-18 om 22:45 schreef Vidya Srinivas:
Quoted 48 lines
From: Chandra Konduru <[email protected]>
This patch adds NV12 as supported format
tointel_framebuffer_initand performs various checks.v2:
-Fix an issue in checks added (Chandra Konduru)v3: rebased (me)
v4: Review comments by Ville addressed
Added platform check for NV12 inintel_framebuffer_initRemoved offset checks for NV12 casev5: Addressed review comments by Clinton A Taylor
This NV12 support only correctly works on SKL.
Plane color space conversion is different on GLK and later platforms causing the colors to display incorrectly.
Ville's plane color space property patch series
in review will fix this issue.
- Restricted the NV12 case inintel_framebuffer_initto SKL and BXT only.v6: Rebased (me)
v7: Addressed review comments by Ville
Restricting the NV12 to BXT for now.v8: Rebased (me)
Restricting the NV12 changes to BXT and KBL for now.v9: Rebased (me)
Tested-by Clinton Taylor <[email protected]>Reviewed-by Clinton Taylor <[email protected]>Signed-off-by Chandra Konduru <[email protected]>Signed-off-by Nabendu Maiti <[email protected]>Signed-off-by Vidya Srinivas <[email protected]>--- drivers/gpu/drm/i915/intel_display.c | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/gpu/drm/i915/intel_display.c +0
-0@@ -14005,6 +14005,14 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb, goto err;
drivers/gpu/drm/i915/intel_display.c static int intel_framebuffer_init(struct intel_framebuffer *intel_fb, · line 14015
Quoted 10 lines
drivers/gpu/drm/i915/intel_display.c +8
-0}break ; +case DRM_FORMAT_NV12 : +if (!IS_BROXTON (dev_priv) && !IS_KABYLAKE (dev_priv)) { +DRM_DEBUG_KMS ("unsupported pixel format: %s\n" , +drm_get_format_name (mode_cmd->pixel_format, + &format_name)); + goto err; + } +break ;
I started implementing the IGT side of this but as far as I can tell, the specification will allow you to set different handles for each plane. But intel doesn't support this right now..
Could this assumption be fixed first? There's nothing stopping the drm core or applications from having separate buffer objects, and for blitting it would make sense to have a R8 plane for Y', and a R8G8 plane for Cb'Cr'
Probably needs i915 to compile with something like below, then handling all corner cases..
---
drivers/gpu/drm/i915/intel_drv.h +2 -2
@@ -186,7 +186,7 @@ enum intel_output_type {struct intel_framebuffer {struct drm_framebuffer base; -struct drm_i915_gem_object *obj; +struct drm_i915_gem_object *objs[2 ];struct intel_rotation_info rot_info;/* for each plane in the normal GTT view */
@@ -996,7 +996,7 @@ struct cxsr_latency {#define to_intel_framebuffer (x) container_of(x, struct intel_framebuffer, base)#define to_intel_plane (x) container_of(x, struct intel_plane, base)#define to_intel_plane_state (x) container_of(x, struct intel_plane_state, base) -#define intel_fb_obj (x) (x ? to_intel_framebuffer(x)->obj : NULL) +#define intel_fb_obj (x, n) (x ? to_intel_framebuffer(x)->objs[n] : NULL)struct intel_hdmi {i915_reg_t hdmi_reg;
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 15/15] drm/i915: Add NV12 support to intel_framebuffer_init
Op 18-01-18 om 15:21 schreef Maarten Lankhorst:
Quoted 61 lines
Op 20-01-18 om 22:45 schreef Vidya Srinivas:
Quoted 48 lines
From: Chandra Konduru <[email protected]>
This patch adds NV12 as supported format
tointel_framebuffer_initand performs various checks.v2:
-Fix an issue in checks added (Chandra Konduru)v3: rebased (me)
v4: Review comments by Ville addressed
Added platform check for NV12 inintel_framebuffer_initRemoved offset checks for NV12 casev5: Addressed review comments by Clinton A Taylor
This NV12 support only correctly works on SKL.
Plane color space conversion is different on GLK and later platforms causing the colors to display incorrectly.
Ville's plane color space property patch series
in review will fix this issue.
- Restricted the NV12 case inintel_framebuffer_initto SKL and BXT only.v6: Rebased (me)
v7: Addressed review comments by Ville
Restricting the NV12 to BXT for now.v8: Rebased (me)
Restricting the NV12 changes to BXT and KBL for now.v9: Rebased (me)
Tested-by Clinton Taylor <[email protected]>Reviewed-by Clinton Taylor <[email protected]>Signed-off-by Chandra Konduru <[email protected]>Signed-off-by Nabendu Maiti <[email protected]>Signed-off-by Vidya Srinivas <[email protected]>--- drivers/gpu/drm/i915/intel_display.c | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/gpu/drm/i915/intel_display.c +0
-0@@ -14005,6 +14005,14 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb, goto err;drivers/gpu/drm/i915/intel_display.c static int intel_framebuffer_init(struct intel_framebuffer *intel_fb, · line 14015
Quoted 10 lines
drivers/gpu/drm/i915/intel_display.c +8
-0}break ; +case DRM_FORMAT_NV12 : +if (!IS_BROXTON (dev_priv) && !IS_KABYLAKE (dev_priv)) { +DRM_DEBUG_KMS ("unsupported pixel format: %s\n" , +drm_get_format_name (mode_cmd->pixel_format, + &format_name)); + goto err; + } +break ;I started implementing the IGT side of this but as far as I can tell, the specification will allow you to set different handles for each plane. But intel doesn't support this right now..
Quoted 3 lines
Could this assumption be fixed first? There's nothing stopping the drm core or applications from having separate buffer objects, and for blitting it would make sense to have a R8 plane for Y', and a R8G8 plane for Cb'Cr'
Probably needs i915 to compile with something like below, then handling all corner cases..
Never mind, seems this is a hardware limitation that bo for plane2 must be higher mapped than plane1 so having separate bo's won't do much. And there was already a check for handles[i] == handles[0].
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 15/15] drm/i915: Add NV12 support to intel_framebuffer_init
In reply to Vidya SrinivasOp 20-01-18 om 22:45 schreef Vidya Srinivas:
Quoted 51 lines
From: Chandra Konduru <[email protected]>
This patch adds NV12 as supported format
tointel_framebuffer_initand performs various checks.v2:
-Fix an issue in checks added (Chandra Konduru)v3: rebased (me)
v4: Review comments by Ville addressed
Added platform check for NV12 inintel_framebuffer_initRemoved offset checks for NV12 casev5: Addressed review comments by Clinton A Taylor
This NV12 support only correctly works on SKL.
Plane color space conversion is different on GLK and later platforms causing the colors to display incorrectly.
Ville's plane color space property patch series
in review will fix this issue.
- Restricted the NV12 case inintel_framebuffer_initto SKL and BXT only.v6: Rebased (me)
v7: Addressed review comments by Ville
Restricting the NV12 to BXT for now.v8: Rebased (me)
Restricting the NV12 changes to BXT and KBL for now.v9: Rebased (me)
Tested-by Clinton Taylor <[email protected]>Reviewed-by Clinton Taylor <[email protected]>Signed-off-by Chandra Konduru <[email protected]>Signed-off-by Nabendu Maiti <[email protected]>Signed-off-by Vidya Srinivas <[email protected]>--- drivers/gpu/drm/i915/intel_display.c | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/gpu/drm/i915/intel_display.c +1
-0@@ -14005,6 +14005,14 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb, goto err; }break ; +case DRM_FORMAT_NV12 :
drivers/gpu/drm/i915/intel_display.c static int intel_framebuffer_init(struct intel_framebuffer *intel_fb, · line 14018
Quoted 10 lines
drivers/gpu/drm/i915/intel_display.c +7
-0+if (!IS_BROXTON (dev_priv) && !IS_KABYLAKE (dev_priv)) { +DRM_DEBUG_KMS ("unsupported pixel format: %s\n" , +drm_get_format_name (mode_cmd->pixel_format, + &format_name)); + goto err; + } +break ;default :DRM_DEBUG_KMS ("unsupported pixel format: %s\n" ,drm_get_format_name (mode_cmd->pixel_format, &format_name));
Hey,
When implementing this for IGT I've noticed a small gap in documentation, which will definitely need clarification somewhere. intel_framebuffer_init is probably good enough since it's specific to how intel works internally.. The Yf tiling mode depends on BPP, is it correct to say that plane 0 has 8 bpp and plane 1 16 bpp for tiling calculations?
What bpp is used?
Are macroblock sizes always the same for Y and UV?
~Maarten
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 15/15] drm/i915: Add NV12 support to intel_framebuffer_init
Quoted 84 lines
-----Original Message-----
From: Maarten Lankhorst [mailto:[email protected]]
Sent: Monday, January 29, 2018 5:12 PM
To: Srinivas, Vidya <[email protected]>; intel- [email protected]
Subject: Re: [Intel-gfx] [PATCH 15/15] drm/i915: Add NV12 support tointel_framebuffer_initOp 20-01-18 om 22:45 schreef Vidya Srinivas:
drivers/gpu/drm/i915/intel_display.c static int intel_framebuffer_init(struct
Quoted 47 lines
From: Chandra Konduru <[email protected]>
This patch adds NV12 as supported format to
intel_framebuffer_initand performs various checks.v2:
-Fix an issue in checks added (Chandra Konduru)v3: rebased (me)
v4: Review comments by Ville addressed Added platform check for NV12 in
intel_framebuffer_initRemoved offset checks for NV12 casev5: Addressed review comments by Clinton A Taylor This NV12 support only correctly works on SKL.
Plane color space conversion is different on GLK and later platforms causing the colors to display incorrectly.
Ville's plane color space property patch series in review will fix this issue.
- Restricted the NV12 case inintel_framebuffer_initto SKL and BXT only.v6: Rebased (me)
v7: Addressed review comments by Ville Restricting the NV12 to BXT for now.
v8: Rebased (me)
Restricting the NV12 changes to BXT and KBL for now.v9: Rebased (me)
Tested-by Clinton Taylor <[email protected]>Reviewed-by Clinton Taylor <[email protected]>Signed-off-by Chandra Konduru <[email protected]>Signed-off-by Nabendu Maiti <[email protected]>Signed-off-by Vidya Srinivas <[email protected]>--- drivers/gpu/drm/i915/intel_display.c | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/gpu/drm/i915/intel_display.c +0
-0@@ -14005,6 +14005,14 @@ static int intel_framebuffer_init(struct
intel_framebuffer*intel_fb,drivers/gpu/drm/i915/intel_display.c static int intel_framebuffer_init(struct intel_framebuffer *intel_fb,
Quoted 6 lines
drivers/gpu/drm/i915/intel_display.c +3
-0goto err; }break ; +case DRM_FORMAT_NV12 : +if (!IS_BROXTON (dev_priv) && !IS_KABYLAKE (dev_priv)) { + DRM_DEBUG_KMS("unsupported pixel format:%s\n",
Quoted 9 lines
drivers/gpu/drm/i915/intel_display.c +5
-0+drm_get_format_name (mode_cmd->pixel_format, + &format_name)); + goto err; + } +break ;default : DRM_DEBUG_KMS("unsupported pixel format: %s\n", drm_get_format_name(mode_cmd-
pixel_format,&format_name));Hey,
When implementing this for IGT I've noticed a small gap in documentation, which will definitely need clarification somewhere.
intel_framebuffer_initis probably good enough since it's specific to how intel works internally.. The Yf tiling mode depends on BPP, is it correct to say that plane 0 has 8 bpp and plane 1 16 bpp for tiling calculations?
Quoted 3 lines
What bpp is used?
Are macroblock sizes always the same for Y and UV?
I think, under display buffer programming it is mentioned that: For NV12 Bpp is 1 for Y and 2 for UV. This is for all SKL+, it says.
Quoted 2 lines
~Maarten
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 15/15] drm/i915: Add NV12 support to intel_framebuffer_init
In reply to Vidya SrinivasOp 20-01-18 om 22:45 schreef Vidya Srinivas:
Quoted 25 lines
From: Chandra Konduru <[email protected]>
This patch adds NV12 as supported format
tointel_framebuffer_initand performs various checks.v2:
-Fix an issue in checks added (Chandra Konduru)v3: rebased (me)
v4: Review comments by Ville addressed
Added platform check for NV12 inintel_framebuffer_initRemoved offset checks for NV12 casev5: Addressed review comments by Clinton A Taylor
This NV12 support only correctly works on SKL.
Plane color space conversion is different on GLK and later platforms causing the colors to display incorrectly.
Ville's plane color space property patch series
in review will fix this issue.
- Restricted the NV12 case inintel_framebuffer_initto SKL and BXT only.v6: Rebased (me)
Quoted 7 lines
v7: Addressed review comments by Ville
Restricting the NV12 to BXT for now.v8: Rebased (me)
Restricting the NV12 changes to BXT and KBL for now.v9: Rebased (me)
Hey,
Has NV12 been tested at all on skylake with rotation?
y_min_scanlines = 16 for 90°/270° rotation with cpp=1skl_needs_memory_bw_wa() doubles the scanlines required,
which will trigger the following error quite easily when patching kms_rotation_crc to use NV12:
[ 67.049190] [drm:skl_compute_wm_levels [i915]] Requested display configuration exceeds system watermark limitations [ 67.049212] [drm:skl_compute_wm_levels [i915]] [PLANE:28:plane 1A] blocks required = 161/572, lines required = 32/31
If we violate the spec for the workaround, by using 31 lines instead of 32 for 90/270 rotation, the tests work but this needs to be solved first before we can move forward.
~Maarten
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 15/15] drm/i915: Add NV12 support to intel_framebuffer_init
Quoted 51 lines
-----Original Message-----
From: Maarten Lankhorst [mailto:[email protected]]
Sent: Monday, January 29, 2018 10:47 PM
To: Srinivas, Vidya <[email protected]>; intel- [email protected]
Subject: Re: [Intel-gfx] [PATCH 15/15] drm/i915: Add NV12 support tointel_framebuffer_initOp 20-01-18 om 22:45 schreef Vidya Srinivas:
Quoted 24 lines
From: Chandra Konduru <[email protected]>
This patch adds NV12 as supported format to
intel_framebuffer_initand performs various checks.v2:
-Fix an issue in checks added (Chandra Konduru)v3: rebased (me)
v4: Review comments by Ville addressed Added platform check for NV12 in
intel_framebuffer_initRemoved offset checks for NV12 casev5: Addressed review comments by Clinton A Taylor This NV12 support only correctly works on SKL.
Plane color space conversion is different on GLK and later platforms causing the colors to display incorrectly.
Ville's plane color space property patch series in review will fix this issue.
- Restricted the NV12 case inintel_framebuffer_initto SKL and BXT only.v6: Rebased (me)
Quoted 7 lines
v7: Addressed review comments by Ville Restricting the NV12 to BXT for now.
v8: Rebased (me)
Restricting the NV12 changes to BXT and KBL for now.v9: Rebased (me)
Hey,
Has NV12 been tested at all on skylake with rotation?
y_min_scanlines= 16 for 90°/270° rotation with cpp=1skl_needs_memory_bw_wa()doubles the scanlines required, which will trigger the following error quite easily when patchingkms_rotation_crcto use NV12:
Quoted 9 lines
[ 67.049190] [drm:skl_compute_wm_levels [i915]] Requested display configuration exceeds system watermark limitations [ 67.049212] [drm:skl_compute_wm_levels [i915]] [PLANE:28:plane 1A] blocks required = 161/572, lines required = 32/31
If we violate the spec for the workaround, by using 31 lines instead of 32 for 90/270 rotation, the tests work but this needs to be solved first before we can move forward.
We came across many such scenarios during NV12 testing on BXT. During downscaling,
the "Max supported pixel clock with scaling exceeded" is seen if the user layer tries to downscale
much. And rotation, as you mentioned we have seen such messages. We discussed the same during the meeting
long back and mentioned that if we remove the limitations, it works. But as per discussion, if limitations are removed, it may work, but there may be certain conditions where it may not work. Hence we concluded that some such cases are expected not to work. However, I will discuss once again with Mahesh Kumar (CC) who works on WM implementation to re-confirm on the same.
Quoted 1 line
~Maarten
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 15/15] drm/i915: Add NV12 support to intel_framebuffer_init
Hi,
Quoted 50 lines · Vidya
Quoted 50 lines
-----Original Message-----
From: Maarten Lankhorst [mailto:[email protected]]
Sent: Monday, January 29, 2018 10:47 PM
To: Srinivas, Vidya <[email protected]>; intel- [email protected]
Subject: Re: [Intel-gfx] [PATCH 15/15] drm/i915: Add NV12 support tointel_framebuffer_initOp 20-01-18 om 22:45 schreef Vidya Srinivas:
Quoted 24 lines
From: Chandra Konduru <[email protected]>
This patch adds NV12 as supported format to
intel_framebuffer_initand performs various checks.v2:
-Fix an issue in checks added (Chandra Konduru)v3: rebased (me)
v4: Review comments by Ville addressed Added platform check for NV12 in
intel_framebuffer_initRemoved offset checks for NV12 casev5: Addressed review comments by Clinton A Taylor This NV12 support only correctly works on SKL.
Plane color space conversion is different on GLK and later platforms causing the colors to display incorrectly.
Ville's plane color space property patch series in review will fix this issue.
- Restricted the NV12 case inintel_framebuffer_initto SKL and BXT only.v6: Rebased (me)
Quoted 7 lines
v7: Addressed review comments by Ville Restricting the NV12 to BXT for now.
v8: Rebased (me)
Restricting the NV12 changes to BXT and KBL for now.v9: Rebased (me)
Hey,
Has NV12 been tested at all on skylake with rotation?
y_min_scanlines= 16 for 90°/270° rotation with cpp=1skl_needs_memory_bw_wa()doubles the scanlines required, which will trigger the following error quite easily when patchingkms_rotation_crcto use NV12:
Quoted 8 lines
Quoted 8 lines
[ 67.049190] [drm:skl_compute_wm_levels [i915]] Requested display configuration exceeds system watermark limitations [ 67.049212] [drm:skl_compute_wm_levels [i915]] [PLANE:28:plane 1A] blocks required = 161/572, lines required = 32/31
If we violate the spec for the workaround, by using 31 lines instead of 32 for 90/270 rotation, the tests work but this needs to be solved first before we can move forward.
We are hitting this issue due to memory_bw_wa (this is applicable for GEN-9 only) & we are applying WA irrespective of it's required or not. I had plan to apply this WA based on our discussion, but it never materialized :(
https://www.spinics.net/lists/intel-gfx/msg124872.html
Quoted 5 lines
We came across many such scenarios during NV12 testing on BXT. During downscaling,
the "Max supported pixel clock with scaling exceeded" is seen if the user layer tries to downscale
much. And rotation, as you mentioned we have seen such messages. We discussed the same during the meeting
long back and mentioned that if we remove the limitations, it works. But as per discussion, if limitations are removed, it may work, but there may be certain conditions where it may not work. Hence we concluded that some such cases are expected not to work.
Either we can conclude that as a limitation (as expected behavior) OR we can enable WA only when it's required (as discussed, assuming all the planes are enabled with max supported scaling to avoid taking mutex in each flip). what you say?
-Mahesh
Quoted 3 lines
However, I will discuss once again with Mahesh Kumar (CC) who works on WM implementation to re-confirm on the same.
Quoted 1 line
~Maarten
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 15/15] drm/i915: Add NV12 support to intel_framebuffer_init
Op 30-01-18 om 07:16 schreef Kumar, Mahesh:
Quoted 65 lines
Hi,
Quoted 50 lines · Vidya
Quoted 50 lines
-----Original Message-----
From: Maarten Lankhorst [mailto:[email protected]]
Sent: Monday, January 29, 2018 10:47 PM
To: Srinivas, Vidya <[email protected]>; intel- [email protected]
Subject: Re: [Intel-gfx] [PATCH 15/15] drm/i915: Add NV12 support tointel_framebuffer_initOp 20-01-18 om 22:45 schreef Vidya Srinivas:
Quoted 24 lines
From: Chandra Konduru <[email protected]>
This patch adds NV12 as supported format to
intel_framebuffer_initand performs various checks.v2:
-Fix an issue in checks added (Chandra Konduru)v3: rebased (me)
v4: Review comments by Ville addressed Added platform check for NV12 in
intel_framebuffer_initRemoved offset checks for NV12 casev5: Addressed review comments by Clinton A Taylor This NV12 support only correctly works on SKL.
Plane color space conversion is different on GLK and later platforms causing the colors to display incorrectly.
Ville's plane color space property patch series in review will fix this issue.
- Restricted the NV12 case inintel_framebuffer_initto SKL and BXT only.v6: Rebased (me)
Quoted 7 lines
v7: Addressed review comments by Ville Restricting the NV12 to BXT for now.
v8: Rebased (me)
Restricting the NV12 changes to BXT and KBL for now.v9: Rebased (me)
Hey,
Has NV12 been tested at all on skylake with rotation?
y_min_scanlines= 16 for 90°/270° rotation with cpp=1skl_needs_memory_bw_wa()doubles the scanlines required, which will trigger the following error quite easily when patchingkms_rotation_crcto use NV12:Quoted 8 lines
Quoted 8 lines
[ 67.049190] [drm:skl_compute_wm_levels [i915]] Requested display configuration exceeds system watermark limitations [ 67.049212] [drm:skl_compute_wm_levels [i915]] [PLANE:28:plane 1A] blocks required = 161/572, lines required = 32/31
If we violate the spec for the workaround, by using 31 lines instead of 32 for 90/270 rotation, the tests work but this needs to be solved first before we can move forward.
We are hitting this issue due to
memory_bw_wa(this is applicable for GEN-9 only) & we are applying WA irrespective of it's required or not. I had plan to apply this WA based on our discussion, but it never materialized :(
https://www.spinics.net/lists/intel-gfx/msg124872.html
Quoted 6 lines
Quoted 5 lines
We came across many such scenarios during NV12 testing on BXT. During downscaling,
the "Max supported pixel clock with scaling exceeded" is seen if the user layer tries to downscale
much. And rotation, as you mentioned we have seen such messages. We discussed the same during the meeting
long back and mentioned that if we remove the limitations, it works. But as per discussion, if limitations are removed, it may work, but there may be certain conditions where it may not work. Hence we concluded that some such cases are expected not to work.Either we can conclude that as a limitation (as expected behavior) OR we can enable WA only when it's required (as discussed, assuming all the planes are enabled with max supported scaling to avoid taking mutex in each flip). what you say?
I think both. We should enable the wa only when required, but also make sure we have sufficient testing that we know whether the below patch would break. It's still almost doubling, 1.9375x the original values for 8 bit planes, but this falls within the wm limitation checks.
---
drivers/gpu/drm/i915/intel_pm.c +3 -1
@@ -4693,7 +4693,9 @@ skl_compute_plane_wm_params(const struct drm_i915_private *dev_priv, wp->y_min_scanlines =4 ; } -if (apply_memory_bw_wa) +if (apply_memory_bw_wa && wp->y_min_scanlines ==16 ) + wp->y_min_scanlines =31 ; +else if (apply_memory_bw_wa) wp->y_min_scanlines *=2 ; wp->plane_bytes_per_line = wp->width * wp->cpp;
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for Adding NV12 support (rev5)
In reply to Vidya Srinivas== Series Details ==
== Series Details ==
Series: Adding NV12 support (rev5)
URL : https://patchwork.freedesktop.org/series/28103/
State : success
== Summary ==
Series 28103v5 Adding NV12 support
https://patchwork.freedesktop.org/api/1.0/series/28103/revisions/5/mbox/
Test debugfs_test:
Subgroup read_all_entries:
dmesg-warn -> PASS (fi-elk-e7500) fdo#103989 +1fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:423s fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:422s fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:372s fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:484s fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:281s fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:464s fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:464s fi-elk-e7500 total:224 pass:168 dwarn:10 dfail:0 fail:0 skip:45 fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:276s fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:391s fi-hsw-4770r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:399s fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:416s fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:450s fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:415s fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:586s fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:527s fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:396s
fi-bxt-dsi failed to collect. IGT log at Patchwork_7663/fi-bxt-dsi/igt.log fi-bxt-j4205 failed to connect after reboot
fi-cfl-s2 failed to collect. IGT log at Patchwork_7663/fi-cfl-s2/igt.log fi-glk-1 failed to collect. IGT log at Patchwork_7663/fi-glk-1/igt.log fi-kbl-7560u failed to collect. IGT log at Patchwork_7663/fi-kbl-7560u/igt.log fi-kbl-7567u failed to collect. IGT log at Patchwork_7663/fi-kbl-7567u/igt.log fi-kbl-r failed to collect. IGT log at Patchwork_7663/fi-kbl-r/igt.log fi-skl-6260u failed to collect. IGT log at Patchwork_7663/fi-skl-6260u/igt.log fi-skl-6700hq failed to connect after reboot
fi-skl-6700k2 failed to collect. IGT log at Patchwork_7663/fi-skl-6700k2/igt.log fi-skl-6770hq failed to collect. IGT log at Patchwork_7663/fi-skl-6770hq/igt.log
53240c7f68af57b5b470158d6cafe5eed4ed9743 drm-tip: 2018y-01m-14d-16h-38m-35s UTC integration manifest c55d5d09d833 drm/i915: Add NV12 support to intel_framebuffer_init4fda17afbf80 drm/i915: Add NV12 as supported format for sprite plane3598957b5900 drm/i915: Add NV12 as supported format for primary planed82acc481065 drm/i915: Upscale scaler max scale for NV1274cbaae3449c drm/i915: Update format_is_yuv() to include NV1224a7bcb42cfd drm/i915: Set scaler mode for NV126dd4969a56de drm/i915/skl: split skl_compute_ddb function4720d5e7c1fc drm/i915/skl+: nv12 workaround disable WM level 1-78f5a1d69ccc3 drm/i915/skl+: make sure higher latency level has higher wm value 9dabaa3e5bc3 drm/i915/skl+: pass skl_wm_level struct to wm compute funcbddec573e7ca drm/i915/skl+: NV12 related changes for WM3a630e91d4a0 drm/i915/skl+: support verification of DDB HW state for NV12 cff341c9a554 drm/i915/skl+: add NV12 in skl_format_to_fourccca8aa855fd41 drm/i915/skl+: refactor WM calculation for NV12916fd6344a86 drm/i915/skl+: rename skl_wm_values struct to skl_ddb_values
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7663/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for Adding NV12 support (rev5)
In reply to Vidya Srinivas== Series Details ==
== Series Details ==
Series: Adding NV12 support (rev5)
URL : https://patchwork.freedesktop.org/series/28103/
State : success
== Summary ==
Test kms_flip:
Subgroup flip-vs-absolute-wf_vblank-interruptible:
pass -> FAIL (shard-snb) fdo#100368
Subgroup vblank-vs-modeset-suspend:
pass -> SKIP (shard-snb) fdo#102365
Subgroup dpms-off-confusion-interruptible:
incomplete -> PASS (shard-hsw)
Test kms_cursor_crc:
Subgroup cursor-64x64-suspend:
incomplete -> PASS (shard-hsw) fdo#103540 +1fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102365 https://bugs.freedesktop.org/show_bug.cgi?id=102365
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
shard-hsw total:2713 pass:1537 dwarn:1 dfail:0 fail:11 skip:1164 time:9100s shard-snb total:2713 pass:1309 dwarn:1 dfail:0 fail:11 skip:1392 time:7823s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7663/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for Adding NV12 support (rev5)
In reply to Vidya Srinivas== Series Details ==
== Series Details ==
Series: Adding NV12 support (rev5)
URL : https://patchwork.freedesktop.org/series/28103/
State : success
== Summary ==
Series 28103v5 Adding NV12 support
https://patchwork.freedesktop.org/api/1.0/series/28103/revisions/5/mbox/
Test debugfs_test:
Subgroup read_all_entries:
dmesg-warn -> DMESG-FAIL (fi-elk-e7500) fdo#103989
Test gem_ringfill:
Subgroup basic-default:
skip -> PASS (fi-bsw-n3050)fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:421s fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:428s fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:371s fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:484s fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:280s fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:468s fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:459s fi-elk-e7500 total:224 pass:168 dwarn:9 dfail:1 fail:0 skip:45 fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:390s fi-hsw-4770r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:401s fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:417s fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:449s fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:412s fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:579s fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:522s fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:397s
fi-bxt-dsi failed to collect. IGT log at Patchwork_7664/fi-bxt-dsi/igt.log fi-bxt-j4205 failed to connect after reboot
fi-cfl-s2 failed to collect. IGT log at Patchwork_7664/fi-cfl-s2/igt.log fi-gdg-551 failed to collect. IGT log at Patchwork_7664/fi-gdg-551/igt.log fi-glk-1 failed to collect. IGT log at Patchwork_7664/fi-glk-1/igt.log fi-glk-dsi failed to collect. IGT log at Patchwork_7664/fi-glk-dsi/igt.log fi-kbl-7500u failed to collect. IGT log at Patchwork_7664/fi-kbl-7500u/igt.log fi-kbl-7560u failed to collect. IGT log at Patchwork_7664/fi-kbl-7560u/igt.log fi-kbl-7567u failed to collect. IGT log at Patchwork_7664/fi-kbl-7567u/igt.log fi-kbl-r failed to collect. IGT log at Patchwork_7664/fi-kbl-r/igt.log fi-skl-6260u failed to collect. IGT log at Patchwork_7664/fi-skl-6260u/igt.log fi-skl-6600u failed to collect. IGT log at Patchwork_7664/fi-skl-6600u/igt.log fi-skl-6700hq failed to collect. IGT log at Patchwork_7664/fi-skl-6700hq/igt.log fi-skl-6700k2 failed to collect. IGT log at Patchwork_7664/fi-skl-6700k2/igt.log fi-skl-6770hq failed to collect. IGT log at Patchwork_7664/fi-skl-6770hq/igt.log fi-skl-gvtdvm failed to collect. IGT log at Patchwork_7664/fi-skl-gvtdvm/igt.log
e96cbac0c1751d045065a49bf20ea134739e2dbb drm-tip: 2018y-01m-15d-05h-55m-36s UTC integration manifest d19f9064681f drm/i915: Add NV12 support to intel_framebuffer_init420b315f2392 drm/i915: Add NV12 as supported format for sprite plane4f54f455147b drm/i915: Add NV12 as supported format for primary planee521e0b5b531 drm/i915: Upscale scaler max scale for NV12e8d508d50d81 drm/i915: Update format_is_yuv() to include NV12a449444b4453 drm/i915: Set scaler mode for NV122c6f947a9b2e drm/i915/skl: split skl_compute_ddb function21c70676d051 drm/i915/skl+: nv12 workaround disable WM level 1-7855807a0e29b drm/i915/skl+: make sure higher latency level has higher wm value f6c1e1570324 drm/i915/skl+: pass skl_wm_level struct to wm compute funce7d0a3539737 drm/i915/skl+: NV12 related changes for WM411196b713cb drm/i915/skl+: support verification of DDB HW state for NV12 d3531892bd0a drm/i915/skl+: add NV12 in skl_format_to_fourcce1790b4eb0a4 drm/i915/skl+: refactor WM calculation for NV1221ece85a2cb6 drm/i915/skl+: rename skl_wm_values struct to skl_ddb_values
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7664/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✓ Fi.CI.BAT: success for Adding NV12 support (rev5)
Hi.
Quoted 68 lines
-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Patchwork
Sent: maanantai 15. tammikuuta 2018 10.47
To: Srinivas, Vidya <[email protected]>
Cc: [email protected]
Subject: [Intel-gfx] ✓ Fi.CI.BAT: success for Adding NV12 support (rev5)== Series Details ==
Series: Adding NV12 support (rev5)
URL : https://patchwork.freedesktop.org/series/28103/
State : success== Summary ==
Series 28103v5 Adding NV12 support
https://patchwork.freedesktop.org/api/1.0/series/28103/revisions/5/mbox/Test
debugfs_test:Subgroup read_all_entries: dmesg-warn -> DMESG-FAIL (fi-elk-e7500) fdo#103989 Test gem_ringfill: Subgroup basic-default: skip -> PASS (fi-bsw-n3050)fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21
time:421s
fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24
time:428s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64
time:371s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46
time:484s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105
time:280sfi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:468s fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:459s fi-elk-e7500 total:224 pass:168 dwarn:9 dfail:1 fail:0 skip:45 fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:390s fi-hsw-4770r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:401s fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:417s fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:449s fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:412s fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65time:579s
fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40
time:522s
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40
time:397s
fi-bxt-dsi failed to collect. IGT log at Patchwork_7664/fi-bxt-dsi/igt.log fi-bxt-j4205 failed to connect after reboot
fi-cfl-s2 failed to collect. IGT log at Patchwork_7664/fi-cfl-s2/igt.log fi-gdg-551 failed to collect. IGT log at Patchwork_7664/fi-gdg-551/igt.log fi-glk-1 failed to collect. IGT log at Patchwork_7664/fi-glk-1/igt.log fi-glk-dsi failed to collect. IGT log at Patchwork_7664/fi-glk-dsi/igt.log fi-kbl-7500u failed to collect. IGT log at Patchwork_7664/fi-kbl-7500u/igt.log fi-kbl-7560u failed to collect. IGT log at Patchwork_7664/fi-kbl-7560u/igt.log fi-kbl-7567u failed to collect. IGT log at Patchwork_7664/fi-kbl-7567u/igt.log fi-kbl-r failed to collect. IGT log at Patchwork_7664/fi-kbl-r/igt.log fi-skl- 6260u failed to collect. IGT log at Patchwork_7664/fi-skl-6260u/igt.log fi-skl-6600u failed to collect. IGT log at Patchwork_7664/fi-skl-6600u/igt.log
Quoted 8 lines
fi-skl-6700hq failed to collect. IGT log at Patchwork_7664/fi-skl- 6700hq/igt.log
fi-skl-6700k2 failed to collect. IGT log at Patchwork_7664/fi-skl- 6700k2/igt.log
fi-skl-6770hq failed to collect. IGT log at Patchwork_7664/fi-skl- 6770hq/igt.log
fi-skl-gvtdvm failed to collect. IGT log at Patchwork_7664/fi-skl- gvtdvm/igt.log
I see this very alarming that all gen9+ systems eg. has issues booting up. This also now 2nd time in a row. So not really considering this as success.
Quoted 20 lines
e96cbac0c1751d045065a49bf20ea134739e2dbbdrm-tip: 2018y-01m-15d- 05h-55m-36s UTC integration manifestd19f9064681fdrm/i915: Add NV12 support tointel_framebuffer_init420b315f2392drm/i915: Add NV12 as supported format for sprite plane4f54f455147bdrm/i915: Add NV12 as supported format for primary planee521e0b5b531drm/i915: Upscale scaler max scale for NV12e8d508d50d81drm/i915: Updateformat_is_yuv()to include NV12a449444b4453drm/i915: Set scaler mode for NV122c6f947a9b2edrm/i915/skl: splitskl_compute_ddbfunction21c70676d051drm/i915/skl+: nv12 workaround disable WM level 1-7855807a0e29bdrm/i915/skl+: make sure higher latency level has higher wm valuef6c1e1570324drm/i915/skl+: passskl_wm_levelstruct to wm compute funce7d0a3539737drm/i915/skl+: NV12 related changes for WM411196b713cbdrm/i915/skl+: support verification of DDB HW state for NV12d3531892bd0adrm/i915/skl+: add NV12 inskl_format_to_fourcce1790b4eb0a4drm/i915/skl+: refactor WM calculation for NV1221ece85a2cb6drm/i915/skl+: renameskl_wm_valuesstruct toskl_ddb_values
Quoted 4 lines
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-
tip/Patchwork_7664/issues.html
Jani Saarinen
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for Adding NV12 support (rev5)
In reply to Vidya Srinivas== Series Details ==
== Series Details ==
Series: Adding NV12 support (rev5)
URL : https://patchwork.freedesktop.org/series/28103/
State : success
== Summary ==
Test gem_tiled_swapping:
Subgroup non-threaded:
incomplete -> PASS (shard-hsw) fdo#104218 +1
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
pass -> SKIP (shard-hsw) fdo#103375 +1
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-shrfb-draw-blt:
fail -> PASS (shard-snb) fdo#101623fdo#104218 https://bugs.freedesktop.org/show_bug.cgi?id=104218
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
shard-hsw total:2698 pass:1528 dwarn:1 dfail:0 fail:9 skip:1159 time:8797s shard-snb total:2713 pass:1311 dwarn:1 dfail:0 fail:10 skip:1391 time:7897s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7664/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for Adding NV12 support (rev5)
In reply to Vidya Srinivas== Series Details ==
== Series Details ==
Series: Adding NV12 support (rev5)
URL : https://patchwork.freedesktop.org/series/28103/
State : failure
== Summary ==
Series 28103v5 Adding NV12 support
https://patchwork.freedesktop.org/api/1.0/series/28103/revisions/5/mbox/
Test core_auth:
Subgroup basic-auth:
pass -> INCOMPLETE (fi-skl-6700hq)
pass -> INCOMPLETE (fi-kbl-7500u)
Test debugfs_test:
Subgroup read_all_entries:
incomplete -> PASS (fi-snb-2520m) fdo#103713fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:418s fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:425s fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:372s fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:487s fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:280s fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:470s fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:466s fi-elk-e7500 total:224 pass:168 dwarn:10 dfail:0 fail:0 skip:45 fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:271s fi-hsw-4770r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:401s fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:459s fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:413s fi-kbl-7500u total:1 pass:0 dwarn:0 dfail:0 fail:0 skip:0 fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:581s fi-skl-6700hq total:1 pass:0 dwarn:0 dfail:0 fail:0 skip:0 fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:529s fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:400s
fi-bxt-dsi failed to collect. IGT log at Patchwork_7672/fi-bxt-dsi/igt.log fi-bxt-j4205 failed to connect after reboot
fi-cfl-s2 failed to collect. IGT log at Patchwork_7672/fi-cfl-s2/igt.log fi-cnl-y2 failed to collect. IGT log at Patchwork_7672/fi-cnl-y2/igt.log fi-glk-1 failed to collect. IGT log at Patchwork_7672/fi-glk-1/igt.log fi-glk-dsi failed to collect. IGT log at Patchwork_7672/fi-glk-dsi/igt.log fi-kbl-7560u failed to collect. IGT log at Patchwork_7672/fi-kbl-7560u/igt.log fi-kbl-7567u failed to collect. IGT log at Patchwork_7672/fi-kbl-7567u/igt.log fi-kbl-r failed to collect. IGT log at Patchwork_7672/fi-kbl-r/igt.log fi-skl-6260u failed to collect. IGT log at Patchwork_7672/fi-skl-6260u/igt.log fi-skl-6600u failed to collect. IGT log at Patchwork_7672/fi-skl-6600u/igt.log fi-skl-6700k2 failed to collect. IGT log at Patchwork_7672/fi-skl-6700k2/igt.log fi-skl-6770hq failed to collect. IGT log at Patchwork_7672/fi-skl-6770hq/igt.log fi-skl-gvtdvm failed to collect. IGT log at Patchwork_7672/fi-skl-gvtdvm/igt.log
254125b984264731491e1eafbe58bc50e84a032d drm-tip: 2018y-01m-15d-09h-31m-31s UTC integration manifest 27f05af422f7 drm/i915: Add NV12 support to intel_framebuffer_inite558e7ff13c6 drm/i915: Add NV12 as supported format for sprite plane0b6028045fd5 drm/i915: Add NV12 as supported format for primary planebbbf0943fbfc drm/i915: Upscale scaler max scale for NV126063e680c38e drm/i915: Update format_is_yuv() to include NV122132b64159d1 drm/i915: Set scaler mode for NV1241861f10a416 drm/i915/skl: split skl_compute_ddb function9e0b5f63e088 drm/i915/skl+: nv12 workaround disable WM level 1-720e661c2375f drm/i915/skl+: make sure higher latency level has higher wm value 04965e783bba drm/i915/skl+: pass skl_wm_level struct to wm compute func366ef9c698e5 drm/i915/skl+: NV12 related changes for WM412b4e9f13d4 drm/i915/skl+: support verification of DDB HW state for NV12 535f80001279 drm/i915/skl+: add NV12 in skl_format_to_fourccb151bacc823e drm/i915/skl+: refactor WM calculation for NV12eabc0f15ba55 drm/i915/skl+: rename skl_wm_values struct to skl_ddb_values
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7672/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx