drm/dp: Add HBR3 support in existing DRM DP helpers
Subsystems (2)
PATCH 1/2 drm/dp: Add HBR3 support in existing DRM DP helpers
Existing helpers add support upto HBR2. This patch adds support for HBR3 rate (8.1 Gbps) introduced as part of DP 1.4 specification.
--- drivers/gpu/drm/drm_dp_helper.c | 4 ++++ drivers/gpu/drm/drm_dp_mst_topology.c | 3 +++ include/drm/drm_dp_helper.h | 1 + 3 files changed, 8 insertions(+)
drivers/gpu/drm/drm_dp_helper.c +4 -0
@@ -146,6 +146,8 @@ u8 drm_dp_link_rate_to_bw_code(int link_rate)return DP_LINK_BW_2_7 ;case 540000 :return DP_LINK_BW_5_4 ; +case 810000 : +return DP_LINK_BW_8_1 ; } }EXPORT_SYMBOL (drm_dp_link_rate_to_bw_code);
@@ -161,6 +163,8 @@ int drm_dp_bw_code_to_link_rate(u8 link_bw)return 270000 ;case DP_LINK_BW_5_4 :return 540000 ; +case DP_LINK_BW_8_1 : +return 810000 ; } }EXPORT_SYMBOL (drm_dp_bw_code_to_link_rate);
drivers/gpu/drm/drm_dp_mst_topology.c +3 -0
@@ -2087,6 +2087,9 @@ static bool drm_dp_get_vc_payload_bw(int dp_link_bw,case DP_LINK_BW_5_4 : *out =10 * dp_link_count;break ; +case DP_LINK_BW_8_1 : + *out =15 * dp_link_count; +break ; }return true; }
include/drm/drm_dp_helper.h +1 -0
@@ -334,6 +334,7 @@# define DP_LINK_BW_1_62 0x06# define DP_LINK_BW_2_7 0x0a# define DP_LINK_BW_5_4 0x14/* 1.2 */ +# define DP_LINK_BW_8_1 0x1e/* 1.4 */ #define DP_LANE_COUNT_SET 0x101# define DP_LANE_COUNT_MASK 0x0f
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/2 drm/dp: Add definitions for TPS4 bits and macros to check the support
DP 1.4 spec adds a TPS4 training pattern sequence required for HBR3. This patch adds the corresponding bit definitions in MAX_DOWNSPREAD register and TRAINING_PATTERN_SET and inline functions to check if this bit is set and for selecting a proper TRAINING_PATTERN_MASK that changed to 0x7 on DP spec 1.4
--- include/drm/drm_dp_helper.h | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
include/drm/drm_dp_helper.h +17 -0
@@ -75,6 +75,7 @@#define DP_MAX_DOWNSPREAD 0x003# define DP_MAX_DOWNSPREAD_0_5 (1 << 0)# define DP_NO_AUX_HANDSHAKE_LINK_TRAINING (1 << 6) +# define DP_TPS4_SUPPORTED (1 << 7)#define DP_NORP 0x004
@@ -345,7 +346,9 @@# define DP_TRAINING_PATTERN_1 1# define DP_TRAINING_PATTERN_2 2# define DP_TRAINING_PATTERN_3 3/* 1.2 */ +# define DP_TRAINING_PATTERN_4 7/* 1.4 */ # define DP_TRAINING_PATTERN_MASK 0x3 +# define DP_TRAINING_PATTERN_MASK_1_4 0xf/* DPCD 1.1 only. For DPCD >= 1.2 see per-lane DP_LINK_QUAL_LANEn_SET */ # define DP_LINK_QUAL_PATTERN_11_DISABLE (0 << 2)
@@ -989,6 +992,20 @@ drm_dp_tps3_supported(const u8 dpcd[DP_RECEIVER_CAP_SIZE]) }static inline bool +drm_dp_tps4_supported (const u8 dpcd[DP_RECEIVER_CAP_SIZE ]) +{ +return dpcd[DP_DPCD_REV ] >=0x14 && + dpcd[DP_MAX_DOWNSPREAD ] &DP_TPS4_SUPPORTED ; +} + +static inline u8 +drm_dp_training_pattern_mask (const u8 dpcd[DP_RECEIVER_CAP_SIZE ]) +{ +return (dpcd[DP_DPCD_REV ] >=0x14 ) ?DP_TRAINING_PATTERN_MASK_1_4 : +DP_TRAINING_PATTERN_MASK ; +} + +static inline bool drm_dp_is_branch (const u8 dpcd[DP_RECEIVER_CAP_SIZE ]) {return dpcd[DP_DOWNSTREAMPORT_PRESENT ] &DP_DWN_STRM_PORT_PRESENT ;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [1/2] drm/dp: Add HBR3 support in existing DRM DP helpers
In reply to Manasi Navare== Series Details ==
== Series Details ==
Series: series starting with [1/2] drm/dp: Add HBR3 support in existing DRM DP helpers
URL : https://patchwork.freedesktop.org/series/36931/
State : success
== Summary ==
Series 36931v1 series starting with [1/2] drm/dp: Add HBR3 support in existing DRM DP helpers
https://patchwork.freedesktop.org/api/1.0/series/36931/revisions/1/mbox/
Test debugfs_test:
Subgroup read_all_entries:
dmesg-fail -> DMESG-WARN (fi-elk-e7500) fdo#103989
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
incomplete -> PASS (fi-snb-2520m) fdo#103713fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:427s fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:426s fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:374s fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:487s fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:280s fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:486s fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:485s fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:467s fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:458s fi-elk-e7500 total:224 pass:168 dwarn:10 dfail:0 fail:0 skip:45 fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:280s fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:512s fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:390s fi-hsw-4770r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:406s fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:411s fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:465s fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:412s fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:457s fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:500s fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:454s fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:503s fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:585s fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:433s fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:510s fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:528s fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:490s fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:475s fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:415s fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:432s fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:536s fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:404s Blacklisted hosts: fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:577s fi-glk-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:475s
06c8efda323ac918fad0e26d81e8884574ec8b84 drm-tip: 2018y-01m-22d-17h-43m-26s UTC integration manifest fc0af05dea6f drm/dp: Add definitions for TPS4 bits and macros to check the support 398f509336f9 drm/dp: Add HBR3 support in existing DRM DP helpers
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7747/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: failure for series starting with [1/2] drm/dp: Add HBR3 support in existing DRM DP helpers
In reply to Manasi Navare== Series Details ==
== Series Details ==
Series: series starting with [1/2] drm/dp: Add HBR3 support in existing DRM DP helpers
URL : https://patchwork.freedesktop.org/series/36931/
State : failure
== Summary ==
Test kms_cursor_legacy:
Subgroup short-flip-after-cursor-atomic-transitions:
pass -> FAIL (shard-apl) fdo#103792
Subgroup cursor-vs-flip-legacy:
fail -> PASS (shard-apl) fdo#103355
Test kms_frontbuffer_tracking:
Subgroup fbc-tilingchange:
fail -> PASS (shard-apl)
Subgroup fbc-1p-offscren-pri-shrfb-draw-render:
fail -> PASS (shard-snb) fdo#101623
Test drv_suspend:
Subgroup fence-restore-tiled2untiled-hibernate:
fail -> SKIP (shard-snb) fdo#103375
Test kms_flip:
Subgroup flip-vs-panning-vs-hang-interruptible:
dmesg-warn -> PASS (shard-snb) fdo#103821
Subgroup vblank-vs-suspend-interruptible:
pass -> FAIL (shard-apl) fdo#100368
Test pm_rpm:
Subgroup gem-execbuf-stress:
pass -> INCOMPLETE (shard-hsw)fdo#103792 https://bugs.freedesktop.org/show_bug.cgi?id=103792
fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#103821 https://bugs.freedesktop.org/show_bug.cgi?id=103821
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
shard-apl total:2753 pass:1713 dwarn:1 dfail:0 fail:26 skip:1013 time:13962s shard-hsw total:2728 pass:1712 dwarn:1 dfail:0 fail:11 skip:1002 time:14880s shard-snb total:2753 pass:1319 dwarn:1 dfail:0 fail:9 skip:1424 time:7883s
Blacklisted hosts:
shard-kbl total:2753 pass:1838 dwarn:1 dfail:1 fail:24 skip:889 time:10774s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7747/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 8 lines · Manasi Navare
Existing helpers add support upto HBR2. This patch adds support for HBR3 rate (8.1 Gbps) introduced as part of DP 1.4 specification.
Cc Rodrigo Vivi <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Manasi Navare <[email protected]>
Both patches look right according to DP 1.4 spec.
Series is
Harry
Quoted 48 lines
--- drivers/gpu/drm/drm_dp_helper.c | 4 ++++ drivers/gpu/drm/drm_dp_mst_topology.c | 3 +++ include/drm/drm_dp_helper.h | 1 + 3 files changed, 8 insertions(+)drivers/gpu/drm/drm_dp_helper.c +4
-0@@ -146,6 +146,8 @@ u8 drm_dp_link_rate_to_bw_code(int link_rate)return DP_LINK_BW_2_7 ;case 540000 :return DP_LINK_BW_5_4 ; +case 810000 : +return DP_LINK_BW_8_1 ; } }EXPORT_SYMBOL (drm_dp_link_rate_to_bw_code);@@ -161,6 +163,8 @@ int drm_dp_bw_code_to_link_rate(u8 link_bw)return 270000 ;case DP_LINK_BW_5_4 :return 540000 ; +case DP_LINK_BW_8_1 : +return 810000 ; } }EXPORT_SYMBOL (drm_dp_bw_code_to_link_rate);drivers/gpu/drm/drm_dp_mst_topology.c +3
-0@@ -2087,6 +2087,9 @@ static bool drm_dp_get_vc_payload_bw(int dp_link_bw,case DP_LINK_BW_5_4 : *out =10 * dp_link_count;break ; +case DP_LINK_BW_8_1 : + *out =15 * dp_link_count; +break ; }return true; }include/drm/drm_dp_helper.h +0
-0
include/drm/drm_dp_helper.h line 340
Quoted 7 lines
include/drm/drm_dp_helper.h +1
-0@@ -334,6 +334,7 @@# define DP_LINK_BW_1_62 0x06# define DP_LINK_BW_2_7 0x0a# define DP_LINK_BW_5_4 0x14/* 1.2 */ +# define DP_LINK_BW_8_1 0x1e/* 1.4 */ #define DP_LANE_COUNT_SET 0x101# define DP_LANE_COUNT_MASK 0x0f
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 10 lines · Harry Wentland
Quoted 8 lines · Manasi Navare
Existing helpers add support upto HBR2. This patch adds support for HBR3 rate (8.1 Gbps) introduced as part of DP 1.4 specification.
Cc Rodrigo Vivi <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Manasi Navare <[email protected]>
Quoted 4 lines
Both patches look right according to DP 1.4 spec.
Series is
Reviewed-by Harry Wentland <[email protected]>
Both pushed to drm-misc-next, thanks for the patches and review.
BR,
Jani.
Quoted 62 lines
Harry
Quoted 48 lines
--- drivers/gpu/drm/drm_dp_helper.c | 4 ++++ drivers/gpu/drm/drm_dp_mst_topology.c | 3 +++ include/drm/drm_dp_helper.h | 1 + 3 files changed, 8 insertions(+)drivers/gpu/drm/drm_dp_helper.c +4
-0@@ -146,6 +146,8 @@ u8 drm_dp_link_rate_to_bw_code(int link_rate)return DP_LINK_BW_2_7 ;case 540000 :return DP_LINK_BW_5_4 ; +case 810000 : +return DP_LINK_BW_8_1 ; } }EXPORT_SYMBOL (drm_dp_link_rate_to_bw_code);@@ -161,6 +163,8 @@ int drm_dp_bw_code_to_link_rate(u8 link_bw)return 270000 ;case DP_LINK_BW_5_4 :return 540000 ; +case DP_LINK_BW_8_1 : +return 810000 ; } }EXPORT_SYMBOL (drm_dp_bw_code_to_link_rate);drivers/gpu/drm/drm_dp_mst_topology.c +3
-0@@ -2087,6 +2087,9 @@ static bool drm_dp_get_vc_payload_bw(int dp_link_bw,case DP_LINK_BW_5_4 : *out =10 * dp_link_count;break ; +case DP_LINK_BW_8_1 : + *out =15 * dp_link_count; +break ; }return true; }include/drm/drm_dp_helper.h +0
-0include/drm/drm_dp_helper.h line 340
Quoted 7 lines
include/drm/drm_dp_helper.h +1
-0@@ -334,6 +334,7 @@# define DP_LINK_BW_1_62 0x06# define DP_LINK_BW_2_7 0x0a# define DP_LINK_BW_5_4 0x14/* 1.2 */ +# define DP_LINK_BW_8_1 0x1e/* 1.4 */ #define DP_LANE_COUNT_SET 0x101# define DP_LANE_COUNT_MASK 0x0f_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx