Patch "be2net: restore properly promisc mode after queues reconfiguration" has been added to the 4.14-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
be2net: restore properly promisc mode after queues reconfiguration
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
be2net-restore-properly-promisc-mode-after-queues-reconfiguration.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Sun Jan 28 17:35:08 CET 2018
From: Ivan Vecera <[email protected]>
Date: Fri, 19 Jan 2018 20:23:50 +0100
Subject: be2net: restore properly promisc mode after queues reconfiguration
From: Ivan Vecera <[email protected]>
[ Upstream commit 52acf06451930eb4cefabd5ecea56e2d46c32f76 ]
The commit 622190669403 ("be2net: Request RSS capability of Rx interface depending on number of Rx rings") modified be_update_queues() so the IFACE (HW representation of the netdevice) is destroyed and then re-created. This causes a regression because potential promiscuous mode is not restored properly during be_open() because the driver thinks that the HW has promiscuous mode already enabled.
Note that Lancer is not affected by this bug because RX-filter flags are disabled during be_close() for this chipset.
--- drivers/net/ethernet/emulex/benet/be_main.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/net/ethernet/emulex/benet/be_main.c +9 -0
@@ -4634,6 +4634,15 @@ int be_update_queues(struct be_adapter *be_schedule_worker (adapter); +/* +* The IF was destroyed and re-created. We need to clear +* all promiscuous flags valid for the destroyed IF. +* Without this promisc mode is not restored during +* be_open() because the driver thinks that it is +* already enabled in HW. +*/ + adapter->if_flags &= ~BE_IF_FLAGS_ALL_PROMISCUOUS ; +if (netif_running (netdev)) status =be_open (netdev);
Patches currently in stable-queue which might be from [email protected] are
queue-4.14/be2net-restore-properly-promisc-mode-after-queues-reconfiguration.patch