Patch "netlink: reset extack earlier in netlink_rcv_skb" has been added to the 4.14-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
netlink: reset extack earlier in netlink_rcv_skb
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
netlink-reset-extack-earlier-in-netlink_rcv_skb.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Sun Jan 28 17:35:08 CET 2018
From: Xin Long <[email protected]>
Date: Thu, 18 Jan 2018 14:48:03 +0800
Subject: netlink: reset extack earlier in netlink_rcv_skb
From: Xin Long <[email protected]>
[ Upstream commit cd443f1e91ca600a092e780e8250cd6a2954b763 ]
Move up the extack reset/initialization in netlink_rcv_skb, so that those 'goto ack' will not skip it. Otherwise, later on netlink_ack may use the uninitialized extack and cause kernel crash.
--- net/netlink/af_netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/netlink/af_netlink.c +1 -1
@@ -2400,6 +2400,7 @@ int netlink_rcv_skb(struct sk_buff *skb,while (skb->len >=nlmsg_total_size (0 )) {int msglen; +memset (&extack,0 ,sizeof (extack)); nlh =nlmsg_hdr (skb); err =0 ;
@@ -2414,7 +2415,6 @@ int netlink_rcv_skb(struct sk_buff *skb,if (nlh->nlmsg_type <NLMSG_MIN_TYPE ) goto ack; -memset (&extack,0 ,sizeof (extack)); err =cb (skb, nlh, &extack);if (err == -EINTR ) goto skip;
Patches currently in stable-queue which might be from [email protected] are
queue-4.14/sctp-do-not-allow-the-v4-socket-to-bind-a-v4mapped-v6-address.patch queue-4.14/sctp-reinit-stream-if-stream-outcnt-has-been-change-by-sinit-in-sendmsg.patch queue-4.14/pppoe-take-needed_headroom-of-lower-device-into-account-on-xmit.patch queue-4.14/sctp-return-error-if-the-asoc-has-been-peeled-off-in-sctp_wait_for_sndbuf.patch queue-4.14/netlink-reset-extack-earlier-in-netlink_rcv_skb.patch