Patch "scsi: aacraid: Fix udev inquiry race condition" has been added to the 4.14-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
scsi: aacraid: Fix udev inquiry race condition
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
scsi-aacraid-fix-udev-inquiry-race-condition.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
f4e8708d3104437fd7716e957f38c265b0c509efMon Sep 17 00:00:00 2001
From: Raghava Aditya Renukunta <[email protected]>
Date: Tue, 26 Dec 2017 20:34:22 -0800
Subject: scsi: aacraid: Fix udev inquiry race condition
From: Raghava Aditya Renukunta <[email protected]>
commit f4e8708d3104437fd7716e957f38c265b0c509ef upstream.
When udev requests for a devices inquiry string, it might create multiple threads causing a race condition on the shared inquiry resource string.
Created a buffer with the string for each thread.
--- drivers/scsi/aacraid/aachba.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)
drivers/scsi/aacraid/aachba.c +12 -4
@@ -913,8 +913,16 @@ static void setinqstr(struct aac_dev *dememset (str,' ' ,sizeof (*str));if (sup_adap_info->adapter_type_text[0 ]) { -char *cp = sup_adap_info->adapter_type_text;int c; +char *cp; +char *cname =kmemdup (sup_adap_info->adapter_type_text, +sizeof (sup_adap_info->adapter_type_text), +GFP_ATOMIC ); + +if (!cname) +return ; + + cp = cname;if ((cp[0 ] =='A' ) && (cp[1 ] =='O' ) && (cp[2 ] =='C' ))inqstrcpy ("SMC" , str->vid);else {
@@ -923,7 +931,7 @@ static void setinqstr(struct aac_dev *de ++cp; c = *cp; *cp ='\0' ; -inqstrcpy (sup_adap_info->adapter_type_text, str->vid); +inqstrcpy (cname, str->vid); *cp = c;while (*cp && *cp !=' ' ) ++cp;
@@ -937,8 +945,8 @@ static void setinqstr(struct aac_dev *de cp[sizeof (str->pid)] ='\0' ; }inqstrcpy (cp, str->pid); -if (c) - cp[sizeof (str->pid)] = c; + +kfree (cname); }else {struct aac_driver_ident *mp =aac_get_driver_ident (dev->cardtype);
Patches currently in stable-queue which might be from [email protected] are
queue-4.14/scsi-aacraid-fix-udev-inquiry-race-condition.patch queue-4.14/scsi-aacraid-fix-hang-in-kdump.patch