Patch "ACPI / bus: Leave modalias empty for devices which are not present" has been added to the 4.14-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
ACPI / bus: Leave modalias empty for devices which are not present
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
acpi-bus-leave-modalias-empty-for-devices-which-are-not-present.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Thu Feb 1 13:45:42 CET 2018
From: Hans de Goede <[email protected]>
Date: Sun, 15 Oct 2017 21:24:49 +0200
Subject: ACPI / bus: Leave modalias empty for devices which are not present
From: Hans de Goede <[email protected]>
[ Upstream commit 10809bb976648ac58194a629e3d7af99e7400297 ]
Most Bay and Cherry Trail devices use a generic DSDT with all possible peripheral devices present in the DSDT, with their _STA returning 0x00 or 0x0f based on AML variables which describe what is actually present on the board.
Since ACPI device objects with a 0x00 status (not present) still get an entry under /sys/bus/acpi/devices, and those entry had an acpi:PNPID modalias, userspace would end up loading modules for non present hardware.
This commit fixes this by leaving the modalias empty for non present devices. This results in 10 modules less being loaded with a generic distro kernel config on my Cherry Trail test-device (a GPD pocket).
--- drivers/acpi/device_sysfs.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/acpi/device_sysfs.c +4 -0
@@ -146,6 +146,10 @@ static int create_pnp_modalias(struct acint count;struct acpi_hardware_id *id; +/* Avoid unnecessarily loading modules for non present devices. */ +if (!acpi_device_is_present (acpi_dev)) +return 0 ; +/* * Since we skip ACPI_DT_NAMESPACE_HID from the modalias below, 0 should * be returned if ACPI_DT_NAMESPACE_HID is the only ACPI/PNP ID in the
Patches currently in stable-queue which might be from [email protected] are
queue-4.14/acpi-bus-leave-modalias-empty-for-devices-which-are-not-present.patch
Hi,
Quoted 8 lines · On 01-02-18 14:11, [email protected] wrote:
This is a note to let you know that I've just added the patch titled
ACPI / bus: Leave modalias empty for devices which are not present
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
Quoted 6 lines
The filename of the patch is:
acpi-bus-leave-modalias-empty-for-devices-which-are-not-present.patch
and it can be found in the queue-4.14 subdirectory.If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Interesting ... I was not directly expecting this to go to stable, I guess it cannot hurt, but since there where some doubts about this patch during review I do find this a bit surprising...
Rafael?
Regards,
Hans
Quoted 52 lines
From foo@baz Thu Feb 1 13:45:42 CET 2018
From: Hans de Goede <[email protected]>
Date: Sun, 15 Oct 2017 21:24:49 +0200
Subject: ACPI / bus: Leave modalias empty for devices which are not presentFrom: Hans de Goede <[email protected]>
[ Upstream commit
10809bb976648ac58194a629e3d7af99e7400297]Most Bay and Cherry Trail devices use a generic DSDT with all possible peripheral devices present in the DSDT, with their
_STAreturning0x00or0x0fbased on AML variables which describe what is actually present on the board.Since ACPI device objects with a
0x00status (not present) still get an entry under/sys/bus/acpi/devices, and those entry had an acpi:PNPID modalias, userspace would end up loading modules for non present hardware.This commit fixes this by leaving the modalias empty for non present devices. This results in 10 modules less being loaded with a generic distro kernel config on my Cherry Trail test-device (a GPD pocket).
Signed-off-by Hans de Goede <[email protected]>Signed-off-by Rafael J. Wysocki <[email protected]>Signed-off-by Sasha Levin <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>--- drivers/acpi/device_sysfs.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/acpi/device_sysfs.c +4
-0@@ -146,6 +146,10 @@ static int create_pnp_modalias(struct acint count;struct acpi_hardware_id *id; +/* Avoid unnecessarily loading modules for non present devices. */ +if (!acpi_device_is_present (acpi_dev)) +return 0 ; +/* * Since we skip ACPI_DT_NAMESPACE_HID from the modalias below, 0 should * be returned if ACPI_DT_NAMESPACE_HID is the only ACPI/PNP ID in the Patches currently in stable-queue which might be from [email protected] are
queue-4.14/acpi-bus-leave-modalias-empty-for-devices-which-are-not-present.patch