Patch "drm/bridge: tc358767: fix timing calculations" has been added to the 4.14-stable tree
Subsystems (4)
This is a note to let you know that I've just added the patch titled
drm/bridge: tc358767: fix timing calculations
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
drm-bridge-tc358767-fix-timing-calculations.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Thu Feb 1 13:45:42 CET 2018
From: Andrey Gusakov <[email protected]>
Date: Tue, 7 Nov 2017 19:56:22 +0300
Subject: drm/bridge: tc358767: fix timing calculations
From: Andrey Gusakov <[email protected]>
[ Upstream commit 66d1c3b94d5d59e4325e61a78d520f92c043d645 ]
Fields in HTIM01 and HTIM02 regs should be even. Recomended thresh_dly value is max_tu_symbol. Remove set of VPCTRL0.VSDELAY as it is related to DSI input interface. Currently driver supports only DPI.
--- drivers/gpu/drm/bridge/tc358767.c | 34 ++++++++++++++++++++-------------- 1 file changed, 20 insertions(+), 14 deletions(-)
drivers/gpu/drm/bridge/tc358767.c +20 -14
@@ -659,6 +659,14 @@ static int tc_set_video_mode(struct tc_dint lower_margin = mode->vsync_start - mode->vdisplay;int vsync_len = mode->vsync_end - mode->vsync_start; +/* +* Recommended maximum number of symbols transferred in a transfer unit: +* DIV_ROUND_UP((input active video bandwidth in bytes) * tu_size, +* (output active video bandwidth in bytes)) +* Must be less than tu_size. +*/ + max_tu_symbol =TU_SIZE_RECOMMENDED -1 ; +dev_dbg (tc->dev,"set mode %dx%d\n" , mode->hdisplay, mode->vdisplay); dev_dbg(tc->dev, "H margin %d,%d sync %d\n",
@@ -668,13 +676,18 @@ static int tc_set_video_mode(struct tc_ddev_dbg (tc->dev,"total: %dx%d\n" , mode->htotal, mode->vtotal); -/* LCD Ctl Frame Size */ -tc_write (VPCTRL0 , (0x40 <<20 )/* VSDELAY */ | +/* +* LCD Ctl Frame Size +* datasheet is not clear of vsdelay in case of DPI +* assume we do not need any delay when DPI is a source of +* sync signals +*/ +tc_write (VPCTRL0 , (0 <<20 )/* VSDELAY */ |OPXLFMT_RGB888 |FRMSYNC_DISABLED |MSF_DISABLED ); -tc_write (HTIM01 , (left_margin <<16 ) |/* H back porch */ - (hsync_len <<0 ));/* Hsync */ -tc_write (HTIM02 , (right_margin <<16 ) |/* H front porch */ - (mode->hdisplay <<0 ));/* width */ +tc_write (HTIM01 , (ALIGN (left_margin,2 ) <<16 ) |/* H back porch */ + (ALIGN (hsync_len,2 ) <<0 ));/* Hsync */ +tc_write (HTIM02 , (ALIGN (right_margin,2 ) <<16 ) |/* H front porch */ + (ALIGN (mode->hdisplay,2 ) <<0 ));/* width */ tc_write (VTIM01 , (upper_margin <<16 ) |/* V back porch */ (vsync_len <<0 ));/* Vsync */ tc_write(VTIM02, (lower_margin << 16) | /* V front porch */
@@ -693,7 +706,7 @@ static int tc_set_video_mode(struct tc_d/* DP Main Stream Attributes */ vid_sync_dly = hsync_len + left_margin + mode->hdisplay;tc_write (DP0_VIDSYNCDELAY , - (0x003e <<16 ) |/* thresh_dly */ + (max_tu_symbol <<16 ) |/* thresh_dly */ (vid_sync_dly <<0 ));tc_write (DP0_TOTALVAL , (mode->vtotal <<16 ) | (mode->htotal));
@@ -709,13 +722,6 @@ static int tc_set_video_mode(struct tc_dtc_write (DPIPXLFMT ,VS_POL_ACTIVE_LOW |HS_POL_ACTIVE_LOW |DE_POL_ACTIVE_HIGH |SUB_CFG_TYPE_CONFIG1 |DPI_BPP_RGB888 ); -/* -* Recommended maximum number of symbols transferred in a transfer unit: -* DIV_ROUND_UP((input active video bandwidth in bytes) * tu_size, -* (output active video bandwidth in bytes)) -* Must be less than tu_size. -*/ - max_tu_symbol =TU_SIZE_RECOMMENDED -1 ;tc_write (DP0_MISC , (max_tu_symbol <<23 ) | (TU_SIZE_RECOMMENDED <<16 ) |BPC_8 );
Patches currently in stable-queue which might be from [email protected] are
queue-4.14/drm-bridge-tc358767-fix-timing-calculations.patch queue-4.14/drm-bridge-tc358767-fix-auxdatan-registers-access.patch queue-4.14/drm-bridge-tc358767-filter-out-too-high-modes.patch queue-4.14/drm-bridge-tc358767-fix-1-lane-behavior.patch queue-4.14/drm-bridge-tc358767-fix-dp0_misc-register-set.patch queue-4.14/drm-bridge-tc358767-do-no-fail-on-hi-res-displays.patch